Remove superfluous base/gtest_prod_util.h includes from headers [chromium/src : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Dec 9, 2025, 11:54:01 AM (3 days ago) Dec 9
to Lei Zhang, Mark Mentovai, Menard, Alexis, Avi Drissman, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Olga Gerchikov, Heron Yang, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Mangesh Ghiware, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, Rijubrata Bhaumik, James Su, Ian Vollick, Wanming Lin, AyeAye Python Dispatcher, Chromium LUCI CQ, abigailbk...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, bici...@google.com, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+wa...@google.com, cros-ed...@google.com, dcheng+c...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading...@chromium.org, longbowei+watc...@google.com, lucasrada...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, nona+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, performance-m...@chromium.org, print-revi...@chromium.org, pushi+watc...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-...@chromium.org, scheduler-b...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, toshikikikuch...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zol...@webkit.org
Attention needed from Mark Mentovai

Lei Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie998958f1622dd7bc6a7bfafd7dd6f737abbc909
Gerrit-Change-Number: 7240634
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: Daniel Andersson <dande...@chromium.org>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 16:53:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Dec 11, 2025, 3:00:39 PM (yesterday) Dec 11
to Lei Zhang, Code Review Nudger, Menard, Alexis, Avi Drissman, chromium...@chromium.org, chromotin...@chromium.org, Daniel Andersson, devtools...@chromium.org, Olga Gerchikov, Heron Yang, Hongchan Choi, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, Mangesh Ghiware, Hiroki Nakagawa, Nikhil Nayunigari, Peter Beverloo, Rijubrata Bhaumik, James Su, Ian Vollick, Wanming Lin, AyeAye Python Dispatcher, Chromium LUCI CQ, abigailbk...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, bici...@google.com, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+wa...@google.com, cros-ed...@google.com, dcheng+c...@chromium.org, dewitt...@chromium.org, dfried...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hashimo...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jbauma...@chromium.org, jdonnel...@chromium.org, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-re...@chromium.org, loading...@chromium.org, longbowei+watc...@google.com, lucasrada...@google.com, mac-r...@chromium.org, marinacio...@chromium.org, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nickdiego+wa...@igalia.com, nikhilcn+wat...@google.com, nona+...@chromium.org, nwoked...@chromium.org, olka+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, performance-m...@chromium.org, print-revi...@chromium.org, pushi+watc...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-...@chromium.org, scheduler-b...@chromium.org, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, toshikikikuch...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, twifka...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zol...@webkit.org
Attention needed from Lei Zhang

Mark Mentovai voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie998958f1622dd7bc6a7bfafd7dd6f737abbc909
Gerrit-Change-Number: 7240634
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Daniel Andersson <dande...@chromium.org>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 20:00:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages