[HiC] Invalidate body background images in iframes [chromium/src : main]
Stephen Chenney (Gerrit)
Stephen Chenney added 1 comment![]( "Open in Gerrit")
Related details
- Philip Rogers
- Stefan Zager
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Rogers (Gerrit)
Philip Rogers added 1 comment![]( "Open in Gerrit")
if (layout_view->StyleRef().HasBackgroundImage()) {WDYT of removing the background image check and just always invalidate? For example, background-color and color is also propagated to the viewport in PropagateStyleToViewport and that may also be affected by read-back-aware rendering.
Related details
- Stefan Zager
- Stephen Chenney
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stephen Chenney (Gerrit)
Stephen Chenney voted and added 1 comment![]( "Open in Gerrit")
Votes added by Stephen Chenney
| Commit-Queue | +1 |
1 comment
WDYT of removing the background image check and just always invalidate? For example, background-color and color is also propagated to the viewport in PropagateStyleToViewport and that may also be affected by read-back-aware rendering.
I think it would be reasonable to always invalidate, yes. It's not like we expect things to frequently move into and out of the subtree from other active parts of the DOM, so performance is likely not a big deal. I presume if an author wants to hide the frame until drawn they would remove it from the dom entirely or otherwise set it up such that the display items would need regeneration regardless. New CL shortly.
Related details
- Philip Rogers
- Stefan Zager
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |