[AdTracker] Fix missing highlighted ads [chromium/src : main]

0 views
Skip to first unread message

Josh Karlin (Gerrit)

unread,
Dec 17, 2025, 3:36:08 PM (2 days ago) Dec 17
to Josh Karlin, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar

Josh Karlin added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Josh Karlin . resolved

Joey, PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I896651a4f88ec7c9ec6d5f75b13f070a930214a5
Gerrit-Change-Number: 7266525
Gerrit-PatchSet: 4
Gerrit-Owner: Josh Karlin <jka...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Dec 2025 20:36:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Dec 18, 2025, 12:20:53 PM (19 hours ago) Dec 18
to Josh Karlin, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Josh Karlin

Joey Arhar added 1 comment

File third_party/blink/renderer/core/html/display_ad_element_monitor.cc
Joey Arhar . unresolved

Are there tests for this class?

Open in Gerrit

Related details

Attention is currently required from:
  • Josh Karlin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I896651a4f88ec7c9ec6d5f75b13f070a930214a5
    Gerrit-Change-Number: 7266525
    Gerrit-PatchSet: 4
    Gerrit-Owner: Josh Karlin <jka...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
    Gerrit-Attention: Josh Karlin <jka...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Dec 2025 17:20:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages