[iframe] Clear the natural size if navigated to non-responsive page [chromium/src : main]
0 views
Skip to first unread message
Koji Ishii (Gerrit)
Apr 14, 2026, 11:22:49 PMApr 14
to Kent Tamura, Ian Kilpatrick, Nate Chapin, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, ipc-securi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Ian Kilpatrick and Kent Tamura
Koji Ishii added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Ian Kilpatrick
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Apr 14, 2026, 11:32:09 PMApr 14
to Koji Ishii, Kent Tamura, Ian Kilpatrick, Nate Chapin, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, ipc-securi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Ian Kilpatrick and Koji Ishii
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/core/frame/remote_frame_owner.cc
Line 87, Patchset 5 (Latest):
auto sizing_info = mojom::blink::IntrinsicSizingInfo::New();
sizing_info->is_cleared = true;
if (auto* web_frame = WebLocalFrameImpl::FromFrame(local_frame)) {Kent Tamura . unresolved
nit: these lines should be inside the inner-most `if` block.
Related details
Attention is currently required from:
- Ian Kilpatrick
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
Apr 15, 2026, 1:57:16 AMApr 15
to Kent Tamura, Ian Kilpatrick, Nate Chapin, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, ipc-securi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Ian Kilpatrick
Koji Ishii added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/frame/remote_frame_owner.cc
Line 87, Patchset 5:
auto sizing_info = mojom::blink::IntrinsicSizingInfo::New();
sizing_info->is_cleared = true;
if (auto* web_frame = WebLocalFrameImpl::FromFrame(local_frame)) {Kent Tamura . resolved
nit: these lines should be inside the inner-most `if` block.
Koji Ishii
Done, good catch, thanks.
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
Apr 15, 2026, 1:59:18 AMApr 15
to Chromium IPC Reviews, Kent Tamura, Ian Kilpatrick, Nate Chapin, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, ipc-securi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Chromium IPC Reviews and Ian Kilpatrick
Koji Ishii added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Koji Ishii . resolved
@chrome-ipc-reviews, PTAL `intrinsic_sizing_info.mojom`
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Apr 15, 2026, 2:00:45 AMApr 15
to Koji Ishii, Chromium IPC Reviews, Sam McNally, Kent Tamura, Ian Kilpatrick, Nate Chapin, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, ipc-securi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Ian Kilpatrick and Sam McNally
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: sa...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): sa...@chromium.org
Reviewer source(s):
sa...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Ian Kilpatrick
- Sam McNally
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
Apr 15, 2026, 3:34:15 PMApr 15
to Koji Ishii, Chromium IPC Reviews, Sam McNally, Kent Tamura, Nate Chapin, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, Daniel Cheng, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, ipc-securi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Koji Ishii and Sam McNally
Ian Kilpatrick voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Koji Ishii
- Sam McNally
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam McNally (Gerrit)
Apr 15, 2026, 11:39:13 PMApr 15
to Koji Ishii, Sam McNally, Ian Kilpatrick, Chromium IPC Reviews, Kent Tamura, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, ipc-securi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Koji Ishii
Sam McNally voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 16, 2026, 12:00:58 AMApr 16
to Koji Ishii, Sam McNally, Ian Kilpatrick, Chromium IPC Reviews, Kent Tamura, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, ipc-securi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Koji Ishii
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59253.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
Apr 16, 2026, 1:04:57 AMApr 16
to Blink W3C Test Autoroller, Sam McNally, Ian Kilpatrick, Chromium IPC Reviews, Kent Tamura, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, ipc-securi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Chromium LUCI CQ (Gerrit)
Apr 16, 2026, 1:09:42 AMApr 16
to Koji Ishii, Blink W3C Test Autoroller, Sam McNally, Ian Kilpatrick, Chromium IPC Reviews, Kent Tamura, Nate Chapin, chromium...@chromium.org, Daniel Cheng, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, ipc-securi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iframe] Clear the natural size if navigated to non-responsive page
This patch implements one of the CSS WG resolutions[1]:
> RESOLVED: Once we know the new page is not opted-in, we
> clear the size
To do this across renderer processes for OOPIF, a new flag
`is_cleared` is added to the mojo `IntrinsicSizingInfo` struct.
This flag is set when an `<iframe>` content starts processing
`<body>` without seeing the `<meta>` tag that opts-in to the
responsive sizing of the `<iframe>`, to clear natural sizes
received from its previous content.
[1]: https://github.com/w3c/csswg-drafts/issues/13589
Bug: 418397278
Change-Id: I19676dd72273fa66ba48894117aff77822f7ea75
Reviewed-by: Sam McNally <sa...@chromium.org>
Commit-Queue: Koji Ishii <ko...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1615630}
Files:
- M third_party/blink/public/mojom/frame/intrinsic_sizing_info.mojom
- M third_party/blink/renderer/core/dom/document.cc
- M third_party/blink/renderer/core/frame/frame_owner.h
- M third_party/blink/renderer/core/frame/remote_frame.cc
- M third_party/blink/renderer/core/frame/remote_frame_owner.cc
- M third_party/blink/renderer/core/frame/remote_frame_owner.h
- M third_party/blink/renderer/core/frame/remote_frame_view.cc
- M third_party/blink/renderer/core/frame/remote_frame_view.h
- M third_party/blink/renderer/core/frame/web_local_frame_impl.cc
- M third_party/blink/renderer/core/html/html_frame_owner_element.cc
- M third_party/blink/renderer/core/html/html_frame_owner_element.h
- M third_party/blink/renderer/core/html/html_iframe_element.cc
- M third_party/blink/renderer/core/html/html_iframe_element.h
- M third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
- M third_party/blink/web_tests/external/wpt/css/css-sizing/responsive-iframe/resources/iframe-contents-navigation.html
- A third_party/blink/web_tests/external/wpt/css/css-sizing/responsive-iframe/responsive-iframe-navigation-unsized.tentative.html
Change size: M
Delta: 16 files changed, 96 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kent Tamura, +1 by Ian Kilpatrick, +1 by Sam McNally
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 16, 2026, 10:16:05 PM (13 days ago) Apr 16
to Chromium LUCI CQ, Koji Ishii, Sam McNally, Ian Kilpatrick, Chromium IPC Reviews, Kent Tamura, Nate Chapin, chromium...@chromium.org, Daniel Cheng, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, ipc-securi...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59253
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages