[Mojo/Content] Support Immersive Picture-in-Picture playback [chromium/src : main]

[Oleh Desiatyrikov (xWF) (Gerrit)]

Attention needed from Andrey Kosyakov, Foromo Daniel Soromou, Frank Liberato, Giovanni Ortuno Urquidi, Joey Arhar, Rakina Zata Amni, Tommy Steimel and Wenyu Fu

Oleh Desiatyrikov (xWF) added 1 comment

File third_party/blink/public/mojom/picture_in_picture/picture_in_picture.mojom

Line 132, Patchset 26: RequestImmersivePlaybackConfirmation()

Giovanni Ortuno Urquidi . resolved

Doesn't look like this is called by anything? Mojo reviews require all methods to have non-test usage. You'll have to add this when it's used.

Oleh Desiatyrikov (xWF)

The next CL [1] in the chain is adding a use case for this method. I've made it separate so it's easier to review. Should I combine these two?

[1] https://chromium-review.git.corp.google.com/c/chromium/src/+/7716732

Giovanni Ortuno Urquidi

Is there going to be a browser-side check that ensure the renderer has user confirmation for immersive PiP?

What about removing it from the Mojo interface and the service and adding it in the next CL? Would that add too much to the follow up CL?

Oleh Desiatyrikov (xWF)

I removed the `RequestImmersivePlaybackConfirmation` call from this CL and will submit it as a part of the follow-up CL.

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Foromo Daniel Soromou
• Frank Liberato
• Giovanni Ortuno Urquidi
• Joey Arhar
• Rakina Zata Amni
• Tommy Steimel
• Wenyu Fu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0464e30e1a2ca3bd4267d0b23dd0cc251fce5b88

Gerrit-Change-Number: 7717398

Gerrit-PatchSet: 28

Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Reviewer: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Gurmeet Kalra <gurm...@google.com>

Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Wang, Wei4 <wei4...@intel.com>

Gerrit-CC: Yizhi Zhao <yi...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Tommy Steimel <ste...@chromium.org>

Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Frank Liberato <libe...@chromium.org>

Gerrit-Attention: Wenyu Fu <wen...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Tue, 21 Apr 2026 17:05:40 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Comment-In-Reply-To: Giovanni Ortuno Urquidi <ort...@chromium.org>

[Giovanni Ortuno Urquidi (Gerrit)]

Attention needed from Andrey Kosyakov, Foromo Daniel Soromou, Frank Liberato, Joey Arhar, Oleh Desiatyrikov (xWF), Rakina Zata Amni, Tommy Steimel and Wenyu Fu

Giovanni Ortuno Urquidi voted and added 2 comments

Votes added by Giovanni Ortuno Urquidi

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 28 (Latest):

Giovanni Ortuno Urquidi . resolved

mojo lgtm

File content/browser/picture_in_picture/video_picture_in_picture_window_controller_impl.cc

Line 305, Patchset 28 (Latest): CHECK_EQ(IsImmersive(), !immersive_options.is_null());

Giovanni Ortuno Urquidi . unresolved

Since a compromised renderer could send this, could we call ReportBadMessage() to kill it instead of crashing the browser?

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Foromo Daniel Soromou
• Frank Liberato

• Joey Arhar
• Oleh Desiatyrikov (xWF)

• Rakina Zata Amni
• Tommy Steimel
• Wenyu Fu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Attention: Frank Liberato <libe...@chromium.org>

Gerrit-Attention: Wenyu Fu <wen...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Tue, 21 Apr 2026 17:11:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Oleh Desiatyrikov (xWF) (Gerrit)]

Attention needed from Andrey Kosyakov, Foromo Daniel Soromou, Frank Liberato, Giovanni Ortuno Urquidi, Joey Arhar, Rakina Zata Amni, Tommy Steimel and Wenyu Fu

Oleh Desiatyrikov (xWF) added 1 comment

File content/browser/picture_in_picture/video_picture_in_picture_window_controller_impl.cc

Line 305, Patchset 28: CHECK_EQ(IsImmersive(), !immersive_options.is_null());

Giovanni Ortuno Urquidi . resolved

Since a compromised renderer could send this, could we call ReportBadMessage() to kill it instead of crashing the browser?

Oleh Desiatyrikov (xWF)

Good point. Done.

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Foromo Daniel Soromou
• Frank Liberato

• Giovanni Ortuno Urquidi
• Joey Arhar

• Rakina Zata Amni
• Tommy Steimel
• Wenyu Fu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0464e30e1a2ca3bd4267d0b23dd0cc251fce5b88

Gerrit-Change-Number: 7717398

Gerrit-PatchSet: 29

Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Reviewer: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Tommy Steimel <ste...@chromium.org>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Gurmeet Kalra <gurm...@google.com>

Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Wang, Wei4 <wei4...@intel.com>

Gerrit-CC: Yizhi Zhao <yi...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Tommy Steimel <ste...@chromium.org>

Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Frank Liberato <libe...@chromium.org>

Gerrit-Attention: Wenyu Fu <wen...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Tue, 21 Apr 2026 17:25:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Giovanni Ortuno Urquidi <ort...@chromium.org>

[Giovanni Ortuno Urquidi (Gerrit)]

Attention needed from Andrey Kosyakov, Foromo Daniel Soromou, Frank Liberato, Joey Arhar, Oleh Desiatyrikov (xWF), Rakina Zata Amni, Tommy Steimel and Wenyu Fu

Giovanni Ortuno Urquidi voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Foromo Daniel Soromou
• Frank Liberato

• Joey Arhar
• Oleh Desiatyrikov (xWF)

• Rakina Zata Amni
• Tommy Steimel
• Wenyu Fu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Attention: Frank Liberato <libe...@chromium.org>

Gerrit-Attention: Wenyu Fu <wen...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Tue, 21 Apr 2026 17:26:25 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Wenyu Fu (Gerrit)]

Attention needed from Andrey Kosyakov, Foromo Daniel Soromou, Frank Liberato, Joey Arhar, Oleh Desiatyrikov (xWF), Rakina Zata Amni and Tommy Steimel

Wenyu Fu voted and added 1 comment

Votes added by Wenyu Fu

Code-Review

+1

1 comment

File chrome/browser/android/tab_web_contents_delegate_android.cc

Line 454, Patchset 30 (Parent): if (!IsPictureInPictureEnabled()) {

Wenyu Fu . unresolved

Sorry I don't know why I missed this earlier - just to make sure, this is moved from here to `PictureInPictureWindowManager::GetInstance()` (effectively VideoPictureInPictureWindowController), since Is immersive mode enabled can control this too.

Is that the right understanding?

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Foromo Daniel Soromou
• Frank Liberato
• Joey Arhar
• Oleh Desiatyrikov (xWF)
• Rakina Zata Amni
• Tommy Steimel

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0464e30e1a2ca3bd4267d0b23dd0cc251fce5b88

Gerrit-Change-Number: 7717398

Gerrit-PatchSet: 30

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Tue, 21 Apr 2026 23:20:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Frank Liberato (Gerrit)]

Attention needed from Andrey Kosyakov, Foromo Daniel Soromou, Joey Arhar, Oleh Desiatyrikov (xWF), Rakina Zata Amni and Tommy Steimel

Frank Liberato voted and added 1 comment

Votes added by Frank Liberato

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 30 (Latest):

Frank Liberato . resolved

media/ still lgtm.

-fl

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Foromo Daniel Soromou

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Wed, 22 Apr 2026 00:05:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Oleh Desiatyrikov (xWF) (Gerrit)]

Attention needed from Andrey Kosyakov, Foromo Daniel Soromou, Joey Arhar, Rakina Zata Amni and Tommy Steimel

Oleh Desiatyrikov (xWF) added 1 comment

File chrome/browser/android/tab_web_contents_delegate_android.cc

Line 454, Patchset 30 (Parent): if (!IsPictureInPictureEnabled()) {

Wenyu Fu . resolved

Sorry I don't know why I missed this earlier - just to make sure, this is moved from here to `PictureInPictureWindowManager::GetInstance()` (effectively VideoPictureInPictureWindowController), since Is immersive mode enabled can control this too.

Is that the right understanding?

Oleh Desiatyrikov (xWF)

Correct. We've discussed this part with @libe...@chromium.org here [1] and it was the way to avoid duplicating the `EnterPictureInPicture` path for Immersive.

[1] https://chromium-review.git.corp.google.com/c/chromium/src/+/7717398/comment/2d79c3a3_226014fc/

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Foromo Daniel Soromou
• Joey Arhar

• Rakina Zata Amni
• Tommy Steimel

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Wed, 22 Apr 2026 01:23:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Wenyu Fu <wen...@chromium.org>

[Rakina Zata Amni (Gerrit)]

Attention needed from Andrey Kosyakov, Foromo Daniel Soromou, Joey Arhar, Oleh Desiatyrikov (xWF) and Tommy Steimel

Rakina Zata Amni voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Foromo Daniel Soromou
• Joey Arhar

• Oleh Desiatyrikov (xWF)
• Tommy Steimel

Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>

Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>

Gerrit-Comment-Date: Wed, 22 Apr 2026 01:44:03 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes