Move anchorElement IDLs from Element to HTMLElement [chromium/src : main]
David Baron (Gerrit)
David Baron voted and added 2 comments![]( "Open in Gerrit")
Votes added by David Baron
| Code-Review | +1 |
2 comments
XML documents which caused crashes becuase there was other code whichbecause
AnchorElementObserver& EnsureAnchorElementObserver();Do we have other HTML-specific things in ElementRareData? Is it worth leaving a comment that it could potentially move if there were a separate `HTMLElementRareData` or similar?
Related details
- Joey Arhar
- Mason Freed
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/45724.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
- Joey Arhar
- Mason Freed
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Joey Arhar added 2 comments![]( "Open in Gerrit")
XML documents which caused crashes becuase there was other code whichJoey Arharbecause
Done
AnchorElementObserver& EnsureAnchorElementObserver();Do we have other HTML-specific things in ElementRareData? Is it worth leaving a comment that it could potentially move if there were a separate `HTMLElementRareData` or similar?
Yeah we have PopoverData which I think is for HTMLElements only. I could add a comment to ElementRareDataVector which says that AnchorElementObserver is only used for HTMLElements, but then I should probably audit all the other ones and find out if they are HTMLElement-only, right...? I think a lot of them might be for HTMLElements only.
Related details
- David Baron
- Mason Freed
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Joey Arhar added 1 comment![]( "Open in Gerrit")
depends_on: ["CSSAnchorPositioning"],Mason, is it OK for me to add this? Is my assumption true that we only want to have the anchor attribute if anchor positioning is enabled?
Related details
- David Baron
- Mason Freed
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
David Baron added 1 comment![]( "Open in Gerrit")
Joey ArharDo we have other HTML-specific things in ElementRareData? Is it worth leaving a comment that it could potentially move if there were a separate `HTMLElementRareData` or similar?
Yeah we have PopoverData which I think is for HTMLElements only. I could add a comment to ElementRareDataVector which says that AnchorElementObserver is only used for HTMLElements, but then I should probably audit all the other ones and find out if they are HTMLElement-only, right...? I think a lot of them might be for HTMLElements only.
Yeah, leaving it as-is is fine if there are a bunch of others.
Related details
- Joey Arhar
- Mason Freed
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Mason Freed added 1 comment![]( "Open in Gerrit")
Would you mind waiting just a bit to land this (and for me to review)? I need to work through the consequences of the `anchor` attribute not shipping, and I'm afraid this will make it tougher to merge things back to M125...
Related details
- Joey Arhar
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |