overscroll: Rename ::backdrop to ::overscroll-backdrop [chromium/src : main]

0 views

Skip to first unread message

Robert Flack (Gerrit)

unread,

Jun 24, 2026, 1:09:03 PM (14 hours ago) Jun 24

to Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org

Attention needed from Vladimir Levin

Robert Flack voted and added 3 comments

Votes added by Robert Flack

Code-Review

3 comments

Patchset-level comments

File-level comment, Patchset 2:

Robert Flack . resolved

LGTM with nits

File third_party/blink/renderer/core/dom/pseudo_element.cc

Line 762, Patchset 2: return RuntimeEnabledFeatures::OverscrollGesturesEnabled();

Robert Flack . unresolved

Maybe just move this to the return true case? If you have such a pseudo id the feature must be enabled and it should be supported.

Line 791, Patchset 2: if (pseudo_id_ == kPseudoIdOverscrollBackdrop) {

Robert Flack . unresolved

This case is unnecessary, we already support it in the function called on line 794.

Open in Gerrit

Related details

Attention is currently required from:

Vladimir Levin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vladimir Levin (Gerrit)

unread,

Jun 24, 2026, 4:47:59 PM (10 hours ago) Jun 24

to Philip Pfaffe, Robert Flack, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org

Attention needed from Philip Pfaffe and Robert Flack

Vladimir Levin added 4 comments

File third_party/blink/renderer/core/dom/pseudo_element.cc

Line 762, Patchset 2: return RuntimeEnabledFeatures::OverscrollGesturesEnabled();

Robert Flack . resolved

Maybe just move this to the return true case? If you have such a pseudo id the feature must be enabled and it should be supported.

Vladimir Levin

Done

Line 762, Patchset 2: return RuntimeEnabledFeatures::OverscrollGesturesEnabled();

Robert Flack . resolved

Maybe just move this to the return true case? If you have such a pseudo id the feature must be enabled and it should be supported.

Vladimir Levin

Done

Line 791, Patchset 2: if (pseudo_id_ == kPseudoIdOverscrollBackdrop) {

Robert Flack . resolved

This case is unnecessary, we already support it in the function called on line 794.

Vladimir Levin

Done

Line 791, Patchset 2: if (pseudo_id_ == kPseudoIdOverscrollBackdrop) {

Robert Flack . resolved

This case is unnecessary, we already support it in the function called on line 794.

Vladimir Levin

Done

Open in Gerrit

Related details

Attention is currently required from:

Philip Pfaffe
Robert Flack

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages