[WebMCP] Do not compute input schema for <input disabled> [chromium/src : main]
0 views
Skip to first unread message
Fr (Gerrit)
7:58 AM (15 hours ago) 7:58 AM
to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Fr added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Fr . resolved
I'll merge this if others agree as discussed offline.
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
8:14 AM (15 hours ago) 8:14 AM
to Fr, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Fr
Anders Hartvoll Ruud voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anders Hartvoll Ruud
| Code-Review | +1 |
1 comment
Patchset-level comments
Fr . resolved
I'll merge this if others agree as discussed offline.
Attention is currently required from:
- Fr
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
3:12 PM (8 hours ago) 3:12 PM
to Fr, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Fr
Mason Freed voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Fr
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fr (Gerrit)
3:15 PM (8 hours ago) 3:15 PM
to Mason Freed, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Fr voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:27 PM (8 hours ago) 3:27 PM
to Fr, Mason Freed, Anders Hartvoll Ruud, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[WebMCP] Do not compute input schema for <input disabled>
Bug: 475972617
Change-Id: Ia4ca15099d32faf4519571db9e74b34e66fd1359
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Fr <beaufort...@gmail.com>
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1583450}
Files:
- M third_party/blink/renderer/core/html/forms/form_mcp_schema.cc
- M third_party/blink/renderer/core/html/forms/html_form_mcp_tool_test.cc
Change size: S
Delta: 2 files changed, 33 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anders Hartvoll Ruud, +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages