[WebMCP] Do not compute input schema for <input disabled> [chromium/src : main]

0 views
Skip to first unread message

Fr (Gerrit)

unread,
7:58 AM (15 hours ago) 7:58 AM
to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud

Fr added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Fr . resolved

I'll merge this if others agree as discussed offline.

Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia4ca15099d32faf4519571db9e74b34e66fd1359
Gerrit-Change-Number: 7566903
Gerrit-PatchSet: 1
Gerrit-Owner: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Fr <beaufort...@gmail.com>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Feb 2026 12:58:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Anders Hartvoll Ruud (Gerrit)

unread,
8:14 AM (15 hours ago) 8:14 AM
to Fr, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Fr

Anders Hartvoll Ruud voted and added 1 comment

Votes added by Anders Hartvoll Ruud

Code-Review+1

1 comment

Patchset-level comments
Fr . resolved

I'll merge this if others agree as discussed offline.

Anders Hartvoll Ruud

Ack.

Open in Gerrit

Related details

Attention is currently required from:
  • Fr
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia4ca15099d32faf4519571db9e74b34e66fd1359
Gerrit-Change-Number: 7566903
Gerrit-PatchSet: 1
Gerrit-Owner: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Fr <beaufort...@gmail.com>
Gerrit-Attention: Fr <beaufort...@gmail.com>
Gerrit-Comment-Date: Wed, 11 Feb 2026 13:14:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Fr <beaufort...@gmail.com>
satisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
3:12 PM (8 hours ago) 3:12 PM
to Fr, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Fr

Mason Freed voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fr
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia4ca15099d32faf4519571db9e74b34e66fd1359
Gerrit-Change-Number: 7566903
Gerrit-PatchSet: 1
Gerrit-Owner: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Fr <beaufort...@gmail.com>
Gerrit-Comment-Date: Wed, 11 Feb 2026 20:12:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Fr (Gerrit)

unread,
3:15 PM (8 hours ago) 3:15 PM
to Mason Freed, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Fr voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia4ca15099d32faf4519571db9e74b34e66fd1359
Gerrit-Change-Number: 7566903
Gerrit-PatchSet: 1
Gerrit-Owner: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Feb 2026 20:15:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
3:27 PM (8 hours ago) 3:27 PM
to Fr, Mason Freed, Anders Hartvoll Ruud, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[WebMCP] Do not compute input schema for <input disabled>
Bug: 475972617
Change-Id: Ia4ca15099d32faf4519571db9e74b34e66fd1359
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Fr <beaufort...@gmail.com>
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1583450}
Files:
  • M third_party/blink/renderer/core/html/forms/form_mcp_schema.cc
  • M third_party/blink/renderer/core/html/forms/html_form_mcp_tool_test.cc
Change size: S
Delta: 2 files changed, 33 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Anders Hartvoll Ruud, +1 by Mason Freed
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia4ca15099d32faf4519571db9e74b34e66fd1359
Gerrit-Change-Number: 7566903
Gerrit-PatchSet: 2
Gerrit-Owner: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Fr <beaufort...@gmail.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages