Revert "[html] Fix body margin precedence and iframe margin injection" [chromium/src : refs/branch-heads/7727]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
Mar 31, 2026, 1:24:49 PM (2 days ago) Mar 31
to Hyowon Kim, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, jmedle...@chromium.org
Attention needed from Hyowon Kim

Mason Freed added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Hyowon Kim
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7727
Gerrit-Change-Id: Iab50e2a11a7a88cc584f69a47b287e0c1598a95f
Gerrit-Change-Number: 7710654
Gerrit-PatchSet: 4
Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Hyowon Kim <hyo...@igalia.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 17:24:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Hyowon Kim (Gerrit)

unread,
Apr 1, 2026, 8:05:04 PM (10 hours ago) Apr 1
to Mason Freed, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, jmedle...@chromium.org
Attention needed from Mason Freed

Hyowon Kim added 1 comment

Patchset-level comments
Mason Freed . unresolved

The revert looks good, but you'll need to request merge approval first:

https://chromium.googlesource.com/chromium/src/+/HEAD/docs/process/merge_request.md#Requesting-a-merge

Hyowon Kim

I've submitted the merge request for M147: https://issues.chromium.org/issues/498381867
Is there anything else I need to do on my side?

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedLint
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7727
    Gerrit-Change-Id: Iab50e2a11a7a88cc584f69a47b287e0c1598a95f
    Gerrit-Change-Number: 7710654
    Gerrit-PatchSet: 4
    Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 00:04:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mason Freed <mas...@chromium.org>
    unsatisfied_requirement
    open
    diffy

    Mason Freed (Gerrit)

    unread,
    Apr 1, 2026, 8:09:53 PM (10 hours ago) Apr 1
    to Hyowon Kim, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, jmedle...@chromium.org
    Attention needed from Hyowon Kim

    Mason Freed added 1 comment

    Patchset-level comments
    Mason Freed . unresolved

    The revert looks good, but you'll need to request merge approval first:

    https://chromium.googlesource.com/chromium/src/+/HEAD/docs/process/merge_request.md#Requesting-a-merge

    Hyowon Kim

    I've submitted the merge request for M147: https://issues.chromium.org/issues/498381867
    Is there anything else I need to do on my side?

    Mason Freed

    Yeah, you'll have to wait for that request (which looks good now) to get approved. Also, if you set the "Auto Cherry Pick" field to "Yes", then the system will create this merge CL for you and automatically land it.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hyowon Kim
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedLint
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7727
    Gerrit-Change-Id: Iab50e2a11a7a88cc584f69a47b287e0c1598a95f
    Gerrit-Change-Number: 7710654
    Gerrit-PatchSet: 4
    Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 00:09:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mason Freed <mas...@chromium.org>
    Comment-In-Reply-To: Hyowon Kim <hyo...@igalia.com>
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages