Move scroller to listbox for <input> in <select> [chromium/src : main]
0 views
Skip to first unread message
Mason Freed (Gerrit)
Jun 23, 2026, 7:01:05 PM (4 days ago) Jun 23
to (Julie)Jeongeun Kim, Menard, Alexis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, kyungjunle...@google.com, nektar...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, yuzo+...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org
Attention needed from Joey Arhar
Mason Freed voted and added 4 comments![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
4 comments
Patchset-level comments
File third_party/blink/renderer/core/css/selector_checker.cc
Line 2505, Patchset 4 (Latest):
if (auto* select = DynamicTo<HTMLSelectElement>(element)) {Mason Freed . unresolved
Can you add a DCHECK that the feature flag is enabled here?
Line 3351, Patchset 4 (Latest):
return MatchesUAShadowElement(element,Mason Freed . unresolved
...and here?
File third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/filterable-select/filterable-select-keyboard-behavior.tentative.html
Line 103, Patchset 4 (Parent):
assert_equals(select.scrollTop, 0,Mason Freed . unresolved
I wonder if it's a problem that this no longer works reliably?
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Jun 23, 2026, 8:18:23 PM (4 days ago) Jun 23
to Alex Rudenko, Mason Freed, (Julie)Jeongeun Kim, Menard, Alexis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, kyungjunle...@google.com, nektar...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, yuzo+...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org
Attention needed from Alex Rudenko
Joey Arhar added 3 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/css/selector_checker.cc
Line 2505, Patchset 4:
if (auto* select = DynamicTo<HTMLSelectElement>(element)) {Mason Freed . resolved
Can you add a DCHECK that the feature flag is enabled here?
Joey Arhar
Done
Line 3351, Patchset 4:
return MatchesUAShadowElement(element,Mason Freed . resolved
Joey Arhar...and here?
Done
File third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/filterable-select/filterable-select-keyboard-behavior.tentative.html
Line 103, Patchset 4 (Parent):
assert_equals(select.scrollTop, 0,Mason Freed . resolved
I wonder if it's a problem that this no longer works reliably?
Joey Arhar
Not having access to the scroller is a consequence of nesting input in select, since the scroller is now an element in the ua shadowroot. alternative you could remove the scrolling styles from the new pseudo element and add a div which can scroll, but the isOptionVisible thing seemed like a good idea for this test to me.
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Jun 24, 2026, 12:37:27 AM (4 days ago) Jun 24
to Mason Freed, (Julie)Jeongeun Kim, Menard, Alexis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, kyungjunle...@google.com, nektar...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, yuzo+...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org
Attention needed from Joey Arhar
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 24, 2026, 12:50:23 AM (4 days ago) Jun 24
to Alex Rudenko, Mason Freed, (Julie)Jeongeun Kim, Menard, Alexis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, kyungjunle...@google.com, nektar...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, yuzo+...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org
Attention needed from Joey Arhar
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60849.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Jun 24, 2026, 12:29:12 PM (4 days ago) Jun 24
to Blink W3C Test Autoroller, Alex Rudenko, Mason Freed, (Julie)Jeongeun Kim, Menard, Alexis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, kyungjunle...@google.com, nektar...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, yuzo+...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org
Joey Arhar voted![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 24, 2026, 12:38:17 PM (4 days ago) Jun 24
to Blink W3C Test Autoroller, Alex Rudenko, Mason Freed, (Julie)Jeongeun Kim, Akihiro Ota, Menard, Alexis, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, yuzo+...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Move scroller to listbox for <input> in <select>
This change is fully guarded behind the FilterableSelect flag, which is
currently disabled by default.
Context: https://github.com/openui/open-ui/issues/1441
There are other alternatives to address this issue, but I think that
making the listbox which wraps the option a scroller instead of putting
position:sticky on the input for example is the best.
In order to implement this in a way that is still developer
controllable, this patch adds an element-backed pseudo-element which
authors can target called ::select-listbox which now gets the scrollable
styles.
Bug: 402429384, 453705243
Change-Id: I8c2d89367d58ddc8e0a2fa1265250dd4e108bbaa
Reviewed-by: Mason Freed <mas...@chromium.org>
Reviewed-by: Joey Arhar <jar...@chromium.org>
Commit-Queue: Joey Arhar <jar...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1651774}
Files:
- M content/test/data/accessibility/event/menulist-custom-expand-collapse-expected-win.txt
- M content/test/data/accessibility/html/select-slowly-build-expected-auralinux.txt
- M content/test/data/accessibility/html/select-slowly-build-expected-blink.txt
- M third_party/blink/public/devtools_protocol/domains/DOM.pdl
- M third_party/blink/renderer/core/css/css_selector.cc
- M third_party/blink/renderer/core/css/css_selector.h
- M third_party/blink/renderer/core/css/css_test_helpers.cc
- M third_party/blink/renderer/core/css/invalidation/rule_invalidation_data_visitor.cc
- M third_party/blink/renderer/core/css/parser/css_selector_parser.cc
- M third_party/blink/renderer/core/css/rule_set.cc
- M third_party/blink/renderer/core/css/selector_checker.cc
- M third_party/blink/renderer/core/dom/element.cc
- M third_party/blink/renderer/core/editing/text_offset_mapping_test.cc
- M third_party/blink/renderer/core/html/forms/html_select_element.cc
- M third_party/blink/renderer/core/html/forms/html_select_element_test.cc
- M third_party/blink/renderer/core/html/forms/select_type.cc
- M third_party/blink/renderer/core/html/resources/html.css
- M third_party/blink/renderer/core/html/shadow/shadow_element_names.json5
- M third_party/blink/renderer/core/html/shadow/shadow_element_utils.cc
- M third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
- M third_party/blink/renderer/core/style/computed_style_constants.h
- M third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/filterable-select/filterable-select-keyboard-behavior.tentative.html
- M third_party/blink/web_tests/fast/forms/suggested-value-after-empty-suggested-value-expected.txt
- M third_party/blink/web_tests/fast/forms/suggested-value-expected.txt
- M third_party/blink/web_tests/inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot-input-value-expected.txt
Change size: M
Delta: 25 files changed, 126 insertions(+), 33 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko, +1 by Joey Arhar, +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jun 24, 2026, 1:25:30 PM (4 days ago) Jun 24
to Chromium LUCI CQ, Alex Rudenko, Mason Freed, (Julie)Jeongeun Kim, Menard, Alexis, android-bu...@system.gserviceaccount.com, kyungjunle...@google.com, nektar...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, yuzo+...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, devtools...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/60849
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages