Rename CustomizableSelectInPage to CustomizableSelectListbox [chromium/src : main]
Mason Freed (Gerrit)
Mason Freed voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
2 comments
LGTM, even though I hate the change. 😊
Listbox is a better term to describe this feature than "in page":I don't know if I agree with this - "listbox" doesn't mean anything to me (it's a "list in a box" which could be in the page or floating above it), whereas "in page" very much does mean something literal. But I do see that this matches the spec. It's just that the spec doesn't necessary speak english, it speaks "spec" which is a different language.
Related details
- Joey Arhar
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Joey Arhar voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joey Arhar
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Listbox is a better term to describe this feature than "in page":I don't know if I agree with this - "listbox" doesn't mean anything to me (it's a "list in a box" which could be in the page or floating above it), whereas "in page" very much does mean something literal. But I do see that this matches the spec. It's just that the spec doesn't necessary speak english, it speaks "spec" which is a different language.
it's a "list in a box" which could be in the page or floating above it
I don't think that any usage of "listbox" implies that it also has a dropdown or popup. In ARIA, the popup of a combobox is a listbox but the button that opens it is not a listbox. In HTML, the popup version is called "dropdown box". In component libraries, this is called a "dropdown" or "select", not a "listbox":
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/56837.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Rename CustomizableSelectInPage to CustomizableSelectListbox
Listbox is a better term to describe this feature than "in page":
1. The HTML spec defines this rendering mode as "list box":
https://html.spec.whatwg.org/#list-box
2. ARIA defines this widget as a "listbox":
https://w3c.github.io/aria/#listbox
3. Component libraries call this a "listbox":
- https://react-spectrum.adobe.com/react-aria/ListBox.html
- https://primereact.org/listbox/
- https://headlessui.com/react/listbox
- M third_party/blink/renderer/core/html/forms/html_opt_group_element.cc
- M third_party/blink/renderer/core/html/forms/html_opt_group_element.h
- M third_party/blink/renderer/core/html/forms/html_option_element.cc
- M third_party/blink/renderer/core/html/forms/html_select_element.cc
- M third_party/blink/renderer/core/html/resources/html.css
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/TestExpectations
- M third_party/blink/web_tests/VirtualTestSuites
- R third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/customizable-select-listbox/customizable-select-listbox-appearance-ref.html
- R third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/customizable-select-listbox/customizable-select-listbox-appearance.tentative.html
- R third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/customizable-select-listbox/customizable-select-listbox-keyboard-behavior.tentative.html
- R third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/customizable-select-listbox/customizable-select-listbox-mouse-behavior.tentative.html
- R third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/customizable-select-listbox/customizable-select-listbox-sizing-ref.html
- R third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/customizable-select-listbox/customizable-select-listbox-sizing.tentative.html
- R third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/customizable-select-listbox/resources/customizable-select-listbox.css
- R third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/customizable-select-listbox/select-listbox-home-end-pagedown-pageup.optional.html
- R third_party/blink/web_tests/external/wpt/html/semantics/forms/the-select-element/customizable-select-listbox/select-listbox-typeahead.tentative.html
- R third_party/blink/web_tests/virtual/customizable-select-listbox-disabled/README.md
- R third_party/blink/web_tests/virtual/customizable-select-listbox-disabled/select-multiple-base-appearance-expected.html
- R third_party/blink/web_tests/virtual/customizable-select-listbox-disabled/select-multiple-base-appearance.html
Code-Review: +1 by Joey Arhar, +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/56837
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |