[ua-image-replacement] Add use counters to API surfaces [chromium/src : main]
0 views
Skip to first unread message
Adithya Srinivasan (Gerrit)
Jul 29, 2026, 2:02:38 PM (3 days ago) Jul 29
to Jeremy Roman, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Jeremy Roman
Adithya Srinivasan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adithya Srinivasan
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/core/html/html_image_element.idl
Line 70, Patchset 7 (Latest):
[RuntimeEnabled=UAImageReplacementAPI, Measure] readonly attribute boolean replacedByUserAgent;Adithya Srinivasan . resolved
question: if a page tried to read the attribute, but the RuntimeEnabledFeature was disabled, that wouldn't count as a use right?
Related details
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jul 29, 2026, 4:29:05 PM (2 days ago) Jul 29
to Jeremy Roman, Adithya Srinivasan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Jeremy Roman added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/html_image_element.idl
Line 70, Patchset 7 (Latest):
[RuntimeEnabled=UAImageReplacementAPI, Measure] readonly attribute boolean replacedByUserAgent;Adithya Srinivasan . resolved
question: if a page tried to read the attribute, but the RuntimeEnabledFeature was disabled, that wouldn't count as a use right?
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jul 30, 2026, 1:06:51 PM (2 days ago) Jul 30
to Jeremy Roman, Adithya Srinivasan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Jeremy Roman voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 30, 2026, 2:18:56 PM (2 days ago) Jul 30
to Jeremy Roman, Adithya Srinivasan, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: tools/metrics/histograms/metadata/blink/enums.xml
Insertions: 6, Deletions: 3.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
Insertions: 6, Deletions: 3.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[ua-image-replacement] Add use counters to API surfaces
Pages which access this boolean property or add listeners for the new
events are understood to use the feature.
Bug: b:539532036
Change-Id: I1f3176790893ac8425d8a97eef8cb9d3a22e872f
Commit-Queue: Jeremy Roman <jbr...@chromium.org>
Reviewed-by: Adithya Srinivasan <adit...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1671247}
Files:
- M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
- M third_party/blink/renderer/core/dom/events/event_target.cc
- M third_party/blink/renderer/core/html/html_image_element.idl
- M third_party/blink/renderer/core/image_replacement/image_replacement_test.cc
- M tools/metrics/histograms/metadata/blink/enums.xml
Change size: S
Delta: 5 files changed, 20 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Adithya Srinivasan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages