Replace LayoutBoxModelObject::OffsetLeft/Top with OffsetPoint() [chromium/src : main]

0 views
Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,
Apr 1, 2026, 4:37:35 AM (yesterday) Apr 1
to Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If876a2d594747ed157394b5c59d77cd507851287
Gerrit-Change-Number: 7718118
Gerrit-PatchSet: 2
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 08:37:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
Apr 1, 2026, 1:14:10 PM (17 hours ago) Apr 1
to Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Fredrik Söderquist

Ian Kilpatrick voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If876a2d594747ed157394b5c59d77cd507851287
    Gerrit-Change-Number: 7718118
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 17:13:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 1, 2026, 3:28:52 PM (15 hours ago) Apr 1
    to Fredrik Söderquist, Ian Kilpatrick, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Replace LayoutBoxModelObject::OffsetLeft/Top with OffsetPoint()

    Both implementations just have a helper that computes both at the same
    time. Modify the interface to be OffsetPoint() instead. Shrinks a bunch
    of vtables.
    Change-Id: If876a2d594747ed157394b5c59d77cd507851287
    Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
    Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
    Auto-Submit: Fredrik Söderquist <f...@opera.com>
    Cr-Commit-Position: refs/heads/main@{#1608716}
    Files:
    • M third_party/blink/renderer/core/dom/element.cc
    • M third_party/blink/renderer/core/html/html_element.cc
    • M third_party/blink/renderer/core/layout/layout_box.cc
    • M third_party/blink/renderer/core/layout/layout_box.h
    • M third_party/blink/renderer/core/layout/layout_box_model_object.h
    • M third_party/blink/renderer/core/layout/layout_inline.cc
    • M third_party/blink/renderer/core/layout/layout_inline.h
    • M third_party/blink/renderer/core/page/print_context.cc
    Change size: M
    Delta: 8 files changed, 15 insertions(+), 39 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Ian Kilpatrick
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If876a2d594747ed157394b5c59d77cd507851287
    Gerrit-Change-Number: 7718118
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages