Revert "Remove unused Screen ex-Supplementable members." [chromium/src : main]

[Steinar H Gunderson (Gerrit)]

Attention needed from Daniel Cheng

Steinar H Gunderson has uploaded the change for review

Steinar H Gunderson would like Daniel Cheng to review this change.

Commit message

Revert "Remove unused Screen ex-Supplementable members."

This reverts commit 4db1e8920e8681abe013ed9fce1246dea1ea8f5e.
(See blink-dev for background.)

Bug: 460165754

Change-Id: I5fc83d166a29591d4652429583e81f7de1fbdddd

Change diff

diff --git a/third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.cc b/third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.cc
index c66eda97..9fe60c7 100644
--- a/third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.cc
+++ b/third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.cc
@@ -15,7 +15,7 @@
 ScreenScreenOrientation& ScreenScreenOrientation::From(Screen& screen) {
   ScreenScreenOrientation* supplement = screen.GetScreenScreenOrientation();
   if (!supplement) {
-    supplement = MakeGarbageCollected<ScreenScreenOrientation>();
+    supplement = MakeGarbageCollected<ScreenScreenOrientation>(screen);
     screen.SetScreenScreenOrientation(supplement);
   }
   return *supplement;
@@ -34,8 +34,12 @@
   return self.orientation_.Get();
 }
 
+ScreenScreenOrientation::ScreenScreenOrientation(Screen& screen)
+    : screen_(screen) {}
+
 void ScreenScreenOrientation::Trace(Visitor* visitor) const {
   visitor->Trace(orientation_);
+  visitor->Trace(screen_);
 }
 
 }  // namespace blink
diff --git a/third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.h b/third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.h
index 762ce0c5..08a5c843 100644
--- a/third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.h
+++ b/third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.h
@@ -24,11 +24,12 @@
 
   static ScreenOrientation* orientation(Screen&);
 
-  explicit ScreenScreenOrientation() = default;
+  explicit ScreenScreenOrientation(Screen& screen);
 
   void Trace(Visitor*) const override;
 
  private:
+  Member<Screen> screen_;
   Member<ScreenOrientation> orientation_;
 };

Change information

Files:

• M third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.cc
• M third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.h

Change size: XS

Delta: 2 files changed, 7 insertions(+), 2 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5fc83d166a29591d4652429583e81f7de1fbdddd

Gerrit-Change-Number: 7247209

Gerrit-PatchSet: 1

Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Gyuyoung Kim <gyuyou...@chromium.org>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: Kaan Icer <ic...@chromium.org>

Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Luna Lu <loon...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Permissions Reviews <permissio...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Wang, Wei4 <wei4...@intel.com>

Gerrit-CC: Wanming Lin <wanmi...@intel.com>

Gerrit-CC: Xida Chen <xida...@chromium.org>

Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

[Daniel Cheng (Gerrit)]

Attention needed from Steinar H Gunderson

Daniel Cheng voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Steinar H Gunderson

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Dec 2025 20:23:58 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Revert "Remove unused Screen ex-Supplementable members."

This reverts commit 4db1e8920e8681abe013ed9fce1246dea1ea8f5e.
(See blink-dev for background.)

Bug: 460165754

Change-Id: I5fc83d166a29591d4652429583e81f7de1fbdddd

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7247209

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Commit-Queue: Steinar H Gunderson <se...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1557888}

Files:

• M third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.cc
• M third_party/blink/renderer/modules/screen_orientation/screen_screen_orientation.h

Change size: XS

Delta: 2 files changed, 7 insertions(+), 2 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5fc83d166a29591d4652429583e81f7de1fbdddd

Gerrit-Change-Number: 7247209

Gerrit-PatchSet: 9

Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>

Gerrit-CC: Christian Biesinger <cbies...@chromium.org>

Gerrit-CC: Daniel Cheng <dch...@chromium.org>