Revert "Optimize scroll-target-group using OrderedScopeTree" [chromium/src : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Dec 19, 2025, 2:35:19 PM (4 days ago) Dec 19
to Daniil Sakhapov, AyeAye, Chromium LUCI CQ, Rune Lillesveen, David Bokan, chromium...@chromium.org, Menard, Alexis, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org
Attention needed from Rune Lillesveen

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5bc177a70cd55de407b50e5acc422f12a5661511
Gerrit-Change-Number: 7280265
Gerrit-PatchSet: 1
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 19:35:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniil Sakhapov (Gerrit)

unread,
Dec 19, 2025, 2:45:20 PM (4 days ago) Dec 19
to Rubber Stamper, AyeAye, Chromium LUCI CQ, Rune Lillesveen, David Bokan, chromium...@chromium.org, Menard, Alexis, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org
Attention needed from Rune Lillesveen

Daniil Sakhapov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5bc177a70cd55de407b50e5acc422f12a5661511
Gerrit-Change-Number: 7280265
Gerrit-PatchSet: 1
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 19:45:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Munira Tursunova (Gerrit)

unread,
Dec 20, 2025, 5:54:57 AM (3 days ago) Dec 20
to Daniil Sakhapov, Rubber Stamper, AyeAye, Chromium LUCI CQ, Rune Lillesveen, David Bokan, chromium...@chromium.org, Menard, Alexis, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org
Attention needed from Daniil Sakhapov and Rune Lillesveen

Munira Tursunova voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5bc177a70cd55de407b50e5acc422f12a5661511
Gerrit-Change-Number: 7280265
Gerrit-PatchSet: 1
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Munira Tursunova <moo...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Sat, 20 Dec 2025 10:54:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Morten Stenshorne (Gerrit)

unread,
Dec 22, 2025, 6:49:32 AM (23 hours ago) Dec 22
to Daniil Sakhapov, Munira Tursunova, Rubber Stamper, AyeAye, Chromium LUCI CQ, Rune Lillesveen, David Bokan, chromium...@chromium.org, Menard, Alexis, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org
Attention needed from Daniil Sakhapov and Rune Lillesveen

Morten Stenshorne voted and added 1 comment

Votes added by Morten Stenshorne

Code-Review+1

1 comment

Commit Message
Line 11, Patchset 1 (Latest):Reason for revert: performance regression
Morten Stenshorne . unresolved

Link to something that shows what this is about?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5bc177a70cd55de407b50e5acc422f12a5661511
Gerrit-Change-Number: 7280265
Gerrit-PatchSet: 1
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Munira Tursunova <moo...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Dec 2025 11:49:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniil Sakhapov (Gerrit)

unread,
Dec 22, 2025, 6:53:02 AM (23 hours ago) Dec 22
to Morten Stenshorne, Munira Tursunova, Rubber Stamper, AyeAye, Chromium LUCI CQ, Rune Lillesveen, David Bokan, chromium...@chromium.org, Menard, Alexis, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org
Attention needed from Rune Lillesveen

Daniil Sakhapov voted and added 1 comment

Votes added by Daniil Sakhapov

Commit-Queue+2

1 comment

Commit Message
Line 11, Patchset 1:Reason for revert: performance regression
Morten Stenshorne . resolved

Link to something that shows what this is about?

Daniil Sakhapov

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5bc177a70cd55de407b50e5acc422f12a5661511
    Gerrit-Change-Number: 7280265
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Munira Tursunova <moo...@google.com>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Dec 2025 11:52:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Morten Stenshorne <mste...@chromium.org>
    satisfied_requirement
    open
    diffy

    Rubber Stamper (Gerrit)

    unread,
    Dec 22, 2025, 6:53:19 AM (23 hours ago) Dec 22
    to Chromium LUCI CQ, Daniil Sakhapov, Morten Stenshorne, Munira Tursunova, AyeAye, Rune Lillesveen, David Bokan, chromium...@chromium.org, Menard, Alexis, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org

    Rubber Stamper voted Bot-Commit+1

    Bot-Commit+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5bc177a70cd55de407b50e5acc422f12a5661511
    Gerrit-Change-Number: 7280265
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Munira Tursunova <moo...@google.com>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Comment-Date: Mon, 22 Dec 2025 11:53:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 22, 2025, 6:53:21 AM (23 hours ago) Dec 22
    to Daniil Sakhapov, Morten Stenshorne, Munira Tursunova, Rubber Stamper, AyeAye, Rune Lillesveen, David Bokan, chromium...@chromium.org, Menard, Alexis, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Revert "Optimize scroll-target-group using OrderedScopeTree"

    This reverts commit 8228728f96d14055cffed90012367445c14a0f7a.


    Reason for revert: performance regression
    https://crbug.com/470321420

    Original change's description:
    > Optimize scroll-target-group using OrderedScopeTree
    >
    > Improve the performance of scroll-target-group by replacing full DOM
    > traversals with an OrderedScopeTree-based management system.
    >
    > Previously, any change to an anchor or a scroll-target-group property
    > triggered a global recalculation.
    >
    > This patch integrates scroll-target-group into the OrderedScope
    > infrastructure, allowing for localized updates and efficient item
    > tracking.
    >
    > Also, this patch modifies OrderedScope to allow to control if items of
    > the scope should be saved in the scope or in some user-controlled
    > storage (e.g. in this case items will be saved in focus_group_ of
    > ScrollMarkerGroupData), so that the OrderedScopeTree infrastructure can
    > be used just for scope management and batch updates.
    >
    > Change-Id: I4927214e984f9f270f9ce46818157a0b8a9e7ca7
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7264892
    > Commit-Queue: Daniil Sakhapov <sakh...@chromium.org>
    > Reviewed-by: Rune Lillesveen <fut...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1561123}
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: I5bc177a70cd55de407b50e5acc422f12a5661511
    Reviewed-by: Morten Stenshorne <mste...@chromium.org>
    Reviewed-by: Munira Tursunova <moo...@google.com>
    Commit-Queue: Daniil Sakhapov <sakh...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1561750}
    Files:
    • M third_party/blink/renderer/core/css/build.gni
    • M third_party/blink/renderer/core/css/ordered_scope.h
    • M third_party/blink/renderer/core/css/ordered_scope_tree.h
    • D third_party/blink/renderer/core/css/scroll_target_group_scope.cc
    • D third_party/blink/renderer/core/css/scroll_target_group_scope.h
    • M third_party/blink/renderer/core/css/style_engine.cc
    • M third_party/blink/renderer/core/css/style_engine.h
    • M third_party/blink/renderer/core/dom/document.cc
    • M third_party/blink/renderer/core/dom/document.h
    • M third_party/blink/renderer/core/dom/element.cc
    • M third_party/blink/renderer/core/dom/scroll_marker_group_data.cc
    • M third_party/blink/renderer/core/dom/scroll_marker_group_data.h
    • M third_party/blink/renderer/core/html/html_anchor_element.cc
    • M third_party/blink/renderer/core/html/html_anchor_element.h
    • M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    Change size: L
    Delta: 15 files changed, 212 insertions(+), 523 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Munira Tursunova, +1 by Morten Stenshorne
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages