Keigo Oka (Gerrit)

unread,

Jan 22, 2026, 2:27:14 AMJan 22

to AyeAye, pasko...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, nyquis...@chromium.org, agriev...@chromium.org, lizeb...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org

Keigo Oka abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Jan 22, 2026, 2:29:30 PMJan 22

to Keigo Oka, Tsuyoshi Horo, Chromium LUCI CQ, Daniel Cheng, AyeAye, nyquis...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, pasko...@chromium.org, blink-...@chromium.org, agriev...@chromium.org, blink-rev...@chromium.org

Attention needed from Keigo Oka and Tsuyoshi Horo

Daniel Cheng added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Daniel Cheng . resolved

Load balancing this to a storage owner

(I'll stamp if it's needed)

Open in Gerrit

Related details

Attention is currently required from:

Keigo Oka
Tsuyoshi Horo

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tsuyoshi Horo (Gerrit)

unread,

Jan 22, 2026, 8:25:49 PMJan 22

to Keigo Oka, Chromium LUCI CQ, Daniel Cheng, AyeAye, nyquis...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, pasko...@chromium.org, blink-...@chromium.org, agriev...@chromium.org, blink-rev...@chromium.org

Attention needed from Keigo Oka

Tsuyoshi Horo added 1 comment

File third_party/blink/renderer/core/html/forms/file_input_type.cc

Line 327, Patchset 4 (Latest): !file->get_native_file()->base_subdirs.empty()) {

Tsuyoshi Horo . unresolved

Please add a test case to verify this change in
third_party/blink/renderer/core/html/forms/file_input_type_test.cc.

Open in Gerrit

Related details

Attention is currently required from:

Keigo Oka

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Keigo Oka (Gerrit)

unread,

Jan 25, 2026, 9:48:03 PMJan 25

to Tsuyoshi Horo, Chromium LUCI CQ, Daniel Cheng, AyeAye, nyquis...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, pasko...@chromium.org, blink-...@chromium.org, agriev...@chromium.org, blink-rev...@chromium.org

Attention needed from Tsuyoshi Horo

Keigo Oka voted and added 1 comment

Votes added by Keigo Oka

Auto-Submit	+1
Commit-Queue	+1

1 comment

File third_party/blink/renderer/core/html/forms/file_input_type.cc

Line 327, Patchset 4: !file->get_native_file()->base_subdirs.empty()) {

Tsuyoshi Horo . resolved

Please add a test case to verify this change in
third_party/blink/renderer/core/html/forms/file_input_type_test.cc.

Keigo Oka

Done

Open in Gerrit

Related details

Attention is currently required from:

Tsuyoshi Horo

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tsuyoshi Horo (Gerrit)

unread,

Jan 26, 2026, 2:32:26 AMJan 26

to Keigo Oka, Chromium LUCI CQ, Daniel Cheng, AyeAye, nyquis...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, pasko...@chromium.org, blink-...@chromium.org, agriev...@chromium.org, blink-rev...@chromium.org

Attention needed from Keigo Oka

Tsuyoshi Horo added 2 comments

File third_party/blink/renderer/core/html/forms/file_input_type.cc

Line 323, Patchset 5 (Latest):

#if BUILDFLAG(IS_ANDROID)
      // Android content-URIs do not use tree paths with separators like posix
      // so we build relative path using base_subdirs.

Tsuyoshi Horo . unresolved

Please update comments.

File third_party/blink/renderer/core/html/forms/file_input_type_test.cc

Line 100, Patchset 5 (Latest): base::FilePath("content://authority/id-base"));

Tsuyoshi Horo . unresolved

Sorry, I don't follow perfectly, but even in the case where /SAF/authority/tree/id-123 is passed, is base_dir still provided as a content:// URL?

Open in Gerrit

Related details

Attention is currently required from:

Keigo Oka

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Keigo Oka (Gerrit)

unread,

Jan 27, 2026, 7:26:34 PMJan 27

to Tsuyoshi Horo, Chromium LUCI CQ, Daniel Cheng, AyeAye, nyquis...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, pasko...@chromium.org, blink-...@chromium.org, agriev...@chromium.org, blink-rev...@chromium.org

Attention needed from Tsuyoshi Horo

Keigo Oka voted and added 2 comments

Votes added by Keigo Oka

Auto-Submit	+1
Commit-Queue	+1

2 comments

File third_party/blink/renderer/core/html/forms/file_input_type.cc

Line 323, Patchset 5:#if BUILDFLAG(IS_ANDROID)


      // Android content-URIs do not use tree paths with separators like posix
      // so we build relative path using base_subdirs.

Tsuyoshi Horo . resolved

Please update comments.

Keigo Oka

Done

File third_party/blink/renderer/core/html/forms/file_input_type_test.cc

Line 100, Patchset 5: base::FilePath("content://authority/id-base"));

Tsuyoshi Horo . resolved

Sorry, I don't follow perfectly, but even in the case where /SAF/authority/tree/id-123 is passed, is base_dir still provided as a content:// URL?

Keigo Oka

Thanks for catching the issue. updated.

Open in Gerrit

Related details

Attention is currently required from:

Tsuyoshi Horo

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tsuyoshi Horo (Gerrit)

unread,

Jan 27, 2026, 8:04:54 PMJan 27

to Keigo Oka, Chromium LUCI CQ, Daniel Cheng, AyeAye, nyquis...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, pasko...@chromium.org, blink-...@chromium.org, agriev...@chromium.org, blink-rev...@chromium.org

Attention needed from Keigo Oka

Tsuyoshi Horo voted and added 3 comments

Votes added by Tsuyoshi Horo

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Tsuyoshi Horo . resolved

lgtm with nits.

Thank you.

File third_party/blink/renderer/core/html/forms/file_input_type_test.cc

Line 91, Patchset 6 (Latest): std::string base_dir = virtual_document_path

Tsuyoshi Horo . unresolved

nit: `const std::string_view`

Line 94, Patchset 6 (Latest): String path = virtual_document_path ? "/SAF/authority/tree/id-base/123"

Tsuyoshi Horo . unresolved

nit: `const String`

Open in Gerrit

Related details

Attention is currently required from:

Keigo Oka

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Keigo Oka (Gerrit)

unread,

Jan 27, 2026, 11:18:15 PMJan 27

to Tsuyoshi Horo, Chromium LUCI CQ, Daniel Cheng, AyeAye, nyquis...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, pasko...@chromium.org, blink-...@chromium.org, agriev...@chromium.org, blink-rev...@chromium.org

Keigo Oka voted and added 2 comments

Votes added by Keigo Oka

Auto-Submit	+1
Commit-Queue	+2

2 comments

File third_party/blink/renderer/core/html/forms/file_input_type_test.cc

Line 91, Patchset 6: std::string base_dir = virtual_document_path

Tsuyoshi Horo . resolved

nit: `const std::string_view`

Keigo Oka

Done

Line 94, Patchset 6: String path = virtual_document_path ? "/SAF/authority/tree/id-base/123"

Tsuyoshi Horo . resolved

nit: `const String`

Keigo Oka

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Keigo Oka (Gerrit)

unread,

Jan 27, 2026, 11:20:12 PMJan 27

to Tsuyoshi Horo, Chromium LUCI CQ, Daniel Cheng, AyeAye, nyquis...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, pasko...@chromium.org, blink-...@chromium.org, agriev...@chromium.org, blink-rev...@chromium.org

Attention needed from Daniel Cheng

Keigo Oka added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Keigo Oka . resolved

Daniel, could you stamp?

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Jan 28, 2026, 2:01:28 AMJan 28

to Keigo Oka, Daniel Cheng, Tsuyoshi Horo, Chromium LUCI CQ, AyeAye, nyquis...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, pasko...@chromium.org, blink-...@chromium.org, agriev...@chromium.org, blink-rev...@chromium.org

Attention needed from Keigo Oka

Daniel Cheng voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Keigo Oka

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 28, 2026, 2:49:16 AMJan 28

to Keigo Oka, Daniel Cheng, Tsuyoshi Horo, AyeAye, nyquis...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, yfriedm...@chromium.org, pasko...@chromium.org, blink-...@chromium.org, agriev...@chromium.org, blink-rev...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Fix File.webkitRelativePath for virtual paths on Android

When directory upload is used on Android (in desktop mode), the
base directory path might be a virtual path (i.e. starting with /SAF/)
instead of a raw content URI. In this case, FileInputType was failing
to use the provided base_subdirs to construct the relative path, falling
back to string substring manipulation which is incorrect for virtual paths
(as the file path is still a content URI).

This CL allows using base_subdirs if it is populated, regardless of
whether the base directory is a content URI or not. This ensures
webkitRelativePath is correctly constructed using the ancestors list
provided by the browser process.

Fixed: 472236838
Test: Open drive.google.com, upload a folder, confirm a folder with the
folder name is created.

Change-Id: I75e739f2f2e965f84d42742909bcad291bb3031b

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7508805

Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Auto-Submit: Keigo Oka <o...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1575740}

Files:

M third_party/blink/renderer/core/html/forms/file_input_type.cc
M third_party/blink/renderer/core/html/forms/file_input_type_test.cc

Change size: S

Delta: 2 files changed, 28 insertions(+), 17 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng, +1 by Tsuyoshi Horo

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Fix File.webkitRelativePath for virtual paths on Android [chromium/src : main]

Keigo Oka (Gerrit)

Keigo Oka abandoned this change

Related details

Daniel Cheng (Gerrit)

Daniel Cheng added 1 comment

Related details

Tsuyoshi Horo (Gerrit)

Tsuyoshi Horo added 1 comment

Related details

Keigo Oka (Gerrit)

Keigo Oka voted and added 1 comment

Votes added by Keigo Oka

1 comment

Related details

Tsuyoshi Horo (Gerrit)

Tsuyoshi Horo added 2 comments

Related details

Keigo Oka (Gerrit)

Keigo Oka voted and added 2 comments

Votes added by Keigo Oka

2 comments

Related details

Tsuyoshi Horo (Gerrit)

Tsuyoshi Horo voted and added 3 comments

Votes added by Tsuyoshi Horo

3 comments

Related details

Keigo Oka (Gerrit)

Keigo Oka voted and added 2 comments

Votes added by Keigo Oka

2 comments

Related details

Keigo Oka (Gerrit)

Keigo Oka added 1 comment

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information