Replace Blink.[Offscreen]Canvas.ContextType metrics with UseCounter [chromium/src : main]
0 views
Skip to first unread message
Justin Novosad (Gerrit)
Sep 10, 2021, 2:55:42 PM9/10/21
to Kai Ninomiya, Aaron Krajeski, Xida Chen, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, ipc-securi...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, lucmult...@chromium.org
Attention is currently required from: Kai Ninomiya, Aaron Krajeski, Xida Chen.
Justin Novosad would like Kai Ninomiya, Aaron Krajeski and Xida Chen to review this change.
Replace Blink.[Offscreen]Canvas.ContextType metrics with UseCounter
Before this CL, the Blink.[Offscreen]Canvas.ContextType histograms we
counting individual context creations. This made it hard to evaluate
the prevalence of these Web Platform features. The CL replaces those
histograms with new features that are captured by the
Blink.UseCounter.Features histogram.
This CL also eliminates the CanvasRenderingContext::ContextType enum
because it was redundant with the CanvasRenderingAPI enum. The
coexistence of the two type made the code unnecessarily confusing.
Bug: 1247663
Change-Id: I3f0ee08166ff75cd1db65afdd1928b3f2dc2c59a
---
M third_party/blink/public/mojom/web_feature/web_feature.mojom
M third_party/blink/renderer/core/html/canvas/canvas_performance_monitor.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_factory.h
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context.h
M third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.h
M third_party/blink/renderer/modules/webgl/webgl2_rendering_context.h
M third_party/blink/renderer/modules/webgl/webgl_rendering_context.h
M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.cc
M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.h
M tools/metrics/histograms/enums.xml
M tools/metrics/histograms/metadata/blink/histograms.xml
17 files changed, 208 insertions(+), 158 deletions(-)
To view, visit change 3152436. To unsubscribe, or for help writing mail filters, visit settings.
Justin Novosad (Gerrit)
Sep 10, 2021, 2:55:52 PM9/10/21
to asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, ipc-securi...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, lucmult...@chromium.org, Aaron Krajeski, Kai Ninomiya, Xida Chen, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org
Attention is currently required from: Kai Ninomiya, Aaron Krajeski, Xida Chen.
Justin Novosad (Gerrit)
Sep 10, 2021, 2:56:42 PM9/10/21
to asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, ipc-securi...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, lucmult...@chromium.org
Attention is currently required from: Kai Ninomiya, Aaron Krajeski, Xida Chen.
Justin Novosad uploaded patch set #2 to this change.
Replace Blink.[Offscreen]Canvas.ContextType metrics with UseCounter
Before this CL, the Blink.[Offscreen]Canvas.ContextType histograms we
counting individual context creations. This made it hard to evaluate
the prevalence of these Web Platform features. The CL replaces those
histograms with new features that are captured by the
Blink.UseCounter.Features histogram.
This CL also eliminates the CanvasRenderingContext::ContextType enum
because it was redundant with the CanvasRenderingAPI enum. The
coexistence of the two types made the code unnecessarily complex.
Bug: 1247663
Change-Id: I3f0ee08166ff75cd1db65afdd1928b3f2dc2c59a
---
M third_party/blink/public/mojom/web_feature/web_feature.mojom
M third_party/blink/renderer/core/html/canvas/canvas_performance_monitor.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_factory.h
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context.h
M third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.h
M third_party/blink/renderer/modules/webgl/webgl2_rendering_context.h
M third_party/blink/renderer/modules/webgl/webgl_rendering_context.h
M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.cc
M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.h
M tools/metrics/histograms/enums.xml
M tools/metrics/histograms/metadata/blink/histograms.xml
17 files changed, 208 insertions(+), 158 deletions(-)
To view, visit change 3152436. To unsubscribe, or for help writing mail filters, visit settings.
Kai Ninomiya (Gerrit)
Sep 10, 2021, 3:01:08 PM9/10/21
to Justin Novosad, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, ipc-securi...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, lucmult...@chromium.org, Aaron Krajeski, Xida Chen, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org
Attention is currently required from: Aaron Krajeski, Xida Chen, Justin Novosad.
Patch set 2:Code-Review +1
Aaron Krajeski (Gerrit)
Sep 13, 2021, 7:15:03 AM9/13/21
to Justin Novosad, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, ipc-securi...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, lucmult...@chromium.org, Kai Ninomiya, Xida Chen, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org
Attention is currently required from: Xida Chen, Justin Novosad.
Patch set 2:Code-Review +1
To view, visit change 3152436. To unsubscribe, or for help writing mail filters, visit settings.
Xida Chen (Gerrit)
Sep 13, 2021, 7:24:46 AM9/13/21
to Justin Novosad, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, ipc-securi...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, lucmult...@chromium.org, Aaron Krajeski, Kai Ninomiya, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org
Attention is currently required from: Justin Novosad.
Patch set 2:Code-Review +1
1 comment:
Patchset:
histograms/ LGTM
To view, visit change 3152436. To unsubscribe, or for help writing mail filters, visit settings.
Justin Novosad (Gerrit)
Sep 13, 2021, 1:43:39 PM9/13/21
to Caleb Raitto, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, ipc-securi...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, lucmult...@chromium.org, Xida Chen, Aaron Krajeski, Kai Ninomiya
Attention is currently required from: Caleb Raitto.
Justin Novosad would like Caleb Raitto to review this change.
Replace Blink.[Offscreen]Canvas.ContextType metrics with UseCounter
Before this CL, the Blink.[Offscreen]Canvas.ContextType histograms we
counting individual context creations. This made it hard to evaluate
the prevalence of these Web Platform features. The CL replaces those
histograms with new features that are captured by the
Blink.UseCounter.Features histogram.
This CL also eliminates the CanvasRenderingContext::ContextType enum
because it was redundant with the CanvasRenderingAPI enum. The
coexistence of the two types made the code unnecessarily complex.
Bug: 1247663
Change-Id: I3f0ee08166ff75cd1db65afdd1928b3f2dc2c59a
---
M chrome/browser/privacy_budget/privacy_budget_browsertest.cc
M third_party/blink/public/mojom/web_feature/web_feature.mojom
M third_party/blink/renderer/core/html/canvas/canvas_performance_monitor.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_factory.h
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context.h
M third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.h
M third_party/blink/renderer/modules/webgl/webgl2_rendering_context.h
M third_party/blink/renderer/modules/webgl/webgl_rendering_context.h
M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.cc
M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.h
M tools/metrics/histograms/enums.xml
M tools/metrics/histograms/metadata/blink/histograms.xml
18 files changed, 211 insertions(+), 159 deletions(-)
Caleb Raitto (Gerrit)
Sep 14, 2021, 4:51:00 PM9/14/21
to Justin Novosad, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, ipc-securi...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, lucmult...@chromium.org, Xida Chen, Aaron Krajeski, Kai Ninomiya, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org
Attention is currently required from: Justin Novosad.
Patch set 3:Code-Review +1
1 comment:
Patchset:
LGTM for //chrome/browser/privacy_budget change.
To view, visit change 3152436. To unsubscribe, or for help writing mail filters, visit settings.
Justin Novosad (Gerrit)
Sep 15, 2021, 2:08:38 PM9/15/21
to asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, ipc-securi...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, lucmult...@chromium.org, Caleb Raitto, Xida Chen, Aaron Krajeski, Kai Ninomiya, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org
Attention is currently required from: Justin Novosad.
Patch set 4:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Sep 15, 2021, 4:24:15 PM9/15/21
to Justin Novosad, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, ipc-securi...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, lucmult...@chromium.org, Caleb Raitto, Xida Chen, Aaron Krajeski, Kai Ninomiya, Chromium Metrics Reviews, chromium...@chromium.org
Chromium LUCI CQ submitted this change.
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: tools/metrics/histograms/enums.xml
Insertions: 12, Deletions: 10.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/public/mojom/web_feature/web_feature.mojom
Insertions: 12, Deletions: 10.
The diff is too large to show. Please review the diff.
```
Approvals:
Xida Chen: Looks good to me
Kai Ninomiya: Looks good to me
Aaron Krajeski: Looks good to me
Caleb Raitto: Looks good to me
Justin Novosad: Commit
Replace Blink.[Offscreen]Canvas.ContextType metrics with UseCounter
Before this CL, the Blink.[Offscreen]Canvas.ContextType histograms we
counting individual context creations. This made it hard to evaluate
the prevalence of these Web Platform features. The CL replaces those
histograms with new features that are captured by the
Blink.UseCounter.Features histogram.
This CL also eliminates the CanvasRenderingContext::ContextType enum
because it was redundant with the CanvasRenderingAPI enum. The
coexistence of the two types made the code unnecessarily complex.
Bug: 1247663
Change-Id: I3f0ee08166ff75cd1db65afdd1928b3f2dc2c59a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152436
Commit-Queue: Justin Novosad <ju...@chromium.org>
Reviewed-by: Caleb Raitto <cara...@chromium.org>
Reviewed-by: Kai Ninomiya <kai...@chromium.org>
Reviewed-by: Aaron Krajeski <aar...@chromium.org>
Reviewed-by: Xida Chen <xida...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#921824}
---
M chrome/browser/privacy_budget/privacy_budget_browsertest.cc
M third_party/blink/public/mojom/web_feature/web_feature.mojom
M third_party/blink/renderer/core/html/canvas/canvas_performance_monitor.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_factory.h
M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
M third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context.h
M third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.h
M third_party/blink/renderer/modules/webgl/webgl2_rendering_context.h
M third_party/blink/renderer/modules/webgl/webgl_rendering_context.h
M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.cc
M third_party/blink/renderer/modules/webgpu/gpu_canvas_context.h
M tools/metrics/histograms/enums.xml
M tools/metrics/histograms/metadata/blink/histograms.xml
18 files changed, 211 insertions(+), 159 deletions(-)
Reply all
Reply to author
Forward
0 new messages