Put back enum array, to keep Le Petit Bistro in business [chromium/src : main]
0 views
Skip to first unread message
Mason Freed (Gerrit)
Mar 6, 2026, 2:15:48 PM (11 hours ago) Mar 6
to Khushal Sagar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Khushal Sagar
Mason Freed voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Khushal Sagar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Khushal Sagar (Gerrit)
Mar 6, 2026, 2:29:23 PM (11 hours ago) Mar 6
to Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Mason Freed
Khushal Sagar voted![]( "Open in Gerrit")
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Mar 6, 2026, 2:48:44 PM (10 hours ago) Mar 6
to Khushal Sagar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Khushal Sagar
Mason Freed voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mason Freed
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mason Freed . resolved
Chromium LUCI CQ on behalf of Khushal Commit-Queue 0 (vote reset)
(Performed by Chromium LUCI CQ on behalf of Khushal)
I have no idea what happened there, but it looks like you need to +1 it again?
Related details
Attention is currently required from:
- Khushal Sagar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Mar 6, 2026, 3:42:40 PM (9 hours ago) Mar 6
to Khushal Sagar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Khushal Sagar
Mason Freed voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Khushal Sagar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 6, 2026, 3:46:12 PM (9 hours ago) Mar 6
to Mason Freed, Khushal Sagar, AyeAye, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Put back enum array, to keep Le Petit Bistro in business
Temporarily reverting the removal of the `enum` array in the
WebMCP input schema, because it seems to help the model on
this page:
https://googlechromelabs.github.io/webmcp-tools/demos/french-bistro/
Bug: 489746716, 490215222
Change-Id: I5304fd11f976fae82bd6ad08abf1d93ea0f38650
Auto-Submit: Mason Freed <mas...@chromium.org>
Reviewed-by: Khushal Sagar <khusha...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1595624}
Files:
- M third_party/blink/renderer/core/html/forms/form_mcp_schema.cc
- M third_party/blink/renderer/core/html/forms/form_mcp_schema.h
- M third_party/blink/renderer/core/html/forms/html_form_mcp_tool_test.cc
Change size: M
Delta: 3 files changed, 42 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mason Freed, +1 by Khushal Sagar
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages