Reorder members of HTMLSelectElement [chromium/src : main]

[Ian Kilpatrick (Gerrit)]

Attention needed from Joey Arhar

Ian Kilpatrick voted and added 1 comment

Votes added by Ian Kilpatrick

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Ian Kilpatrick . resolved

oh wow w/o this was 592 bytes (with 584).

HTMLSelectElement is quite large :).

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia88fdbf8d82d0aabccea5aa1f84f4dd14910845e

Gerrit-Change-Number: 7408759

Gerrit-PatchSet: 2

Gerrit-Owner: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Comment-Date: Fri, 09 Jan 2026 17:43:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Joey Arhar (Gerrit)]

Joey Arhar voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia88fdbf8d82d0aabccea5aa1f84f4dd14910845e

Gerrit-Change-Number: 7408759

Gerrit-PatchSet: 2

Gerrit-Owner: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Comment-Date: Fri, 09 Jan 2026 17:54:25 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Reorder members of HTMLSelectElement

This patch has no behavior changes.

This patch reorders the members of HTMLSelectElement to go from largest
to smallest in order to optimize packing of fields and potentially
reduce memory usage, and also adds some comments to the members
explaining what they are for.

This patch also corrects the indentation of some code in OptionList
which I forgot to do when removing a flag.

Change-Id: Ia88fdbf8d82d0aabccea5aa1f84f4dd14910845e

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7408759

Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>

Commit-Queue: Joey Arhar <jar...@chromium.org>

Reviewed-by: Joey Arhar <jar...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1567024}

Files:

• M third_party/blink/renderer/core/html/forms/html_select_element.cc
• M third_party/blink/renderer/core/html/forms/html_select_element.h
• M third_party/blink/renderer/core/html/forms/option_list.cc

Change size: M

Delta: 3 files changed, 39 insertions(+), 37 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Ian Kilpatrick, +1 by Joey Arhar

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia88fdbf8d82d0aabccea5aa1f84f4dd14910845e

Gerrit-Change-Number: 7408759

Gerrit-PatchSet: 3

Gerrit-Owner: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>