David Baron (Gerrit)

unread,

Jun 23, 2025, 8:26:26 PMJun 23

to David Baron, AyeAye, chromium...@chromium.org, mac-r...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Attention needed from Joey Arhar

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Joey Arhar

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Baron (Gerrit)

unread,

Jun 24, 2025, 1:31:06 PMJun 24

to David Baron, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, mac-r...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Attention needed from David Baron and Joey Arhar

Message from David Baron

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

David Baron
Joey Arhar

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Joey Arhar (Gerrit)

unread,

Jun 24, 2025, 1:43:48 PMJun 24

to David Baron, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, mac-r...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Attention needed from David Baron

Joey Arhar voted and added 1 comment

Votes added by Joey Arhar

Code-Review

+1

1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 959, Patchset 3 (Latest): name: "ColorInputDatalistLooksNormal",

Joey Arhar . unresolved

Want to add a comment with a link to the bug?

Open in Gerrit

Related details

Attention is currently required from:

David Baron

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Baron (Gerrit)

unread,

Jun 24, 2025, 1:56:28 PMJun 24

to David Baron, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, mac-r...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

David Baron voted and added 1 comment

Votes added by David Baron

Commit-Queue

+2

1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 959, Patchset 3: name: "ColorInputDatalistLooksNormal",

Joey Arhar . resolved

Want to add a comment with a link to the bug?

David Baron

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 24, 2025, 2:49:07 PMJun 24

to David Baron, AyeAye, chromium...@chromium.org, mac-r...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/blink/renderer/platform/runtime_enabled_features.json5
Insertions: 1, Deletions: 0.

@@ -956,6 +956,7 @@
       status: "stable",
     },
     {
+      // Killswitch for https://crbug.com/414827239
       name: "ColorInputDatalistLooksNormal",
       status: "stable",
     },
```

Change information

Commit message:

Make <input type=color> with a datalist look like other color inputs.

Fixed: 414827239

Change-Id: Idcacf6e569f0f2247026109813ff38e7c45e212b

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6664420

Reviewed-by: Joey Arhar <jar...@chromium.org>

Commit-Queue: David Baron <dba...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1478082}

Files:

M content/test/data/forms/form_controls_browsertest_color_input.png
M content/test/data/forms/form_controls_browsertest_color_input_chromeos.png
M content/test/data/forms/form_controls_browsertest_color_input_ios.png
M content/test/data/forms/form_controls_browsertest_color_input_linux.png
M content/test/data/forms/form_controls_browsertest_color_input_mac.png
M content/test/data/forms/form_controls_browsertest_color_input_win.png
M third_party/blink/renderer/core/html/forms/color_input_type.cc
M third_party/blink/renderer/core/html/resources/html.css
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M third_party/blink/web_tests/flag-specific/highdpi/fast/forms/color-scheme/color/color-suggestion-picker-appearance-with-scrollbar-expected.png
M third_party/blink/web_tests/flag-specific/highdpi/fast/forms/color/input-appearance-color-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color-scheme/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color-scheme/color/color-suggestion-picker-appearance-with-scrollbar-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-empty-list-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-one-row-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-set-type-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-two-rows-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-value-attribute-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color/input-appearance-color-expected.png
M third_party/blink/web_tests/platform/linux/virtual/controls-refresh-hc/fast/forms/color-scheme/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/linux/virtual/controls-refresh-hc/fast/forms/color-scheme/color/color-suggestion-picker-appearance-with-scrollbar-expected.png
M third_party/blink/web_tests/platform/linux/virtual/dark-color-scheme/fast/forms/color-scheme/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/linux/virtual/dark-color-scheme/fast/forms/color-scheme/color/color-suggestion-picker-appearance-with-scrollbar-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color-scheme/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color-scheme/color/color-suggestion-picker-appearance-with-scrollbar-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-empty-list-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-one-row-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-two-rows-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-value-attribute-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color/input-appearance-color-expected.png
M third_party/blink/web_tests/platform/mac/virtual/controls-refresh-hc/fast/forms/color-scheme/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/mac/virtual/controls-refresh-hc/fast/forms/color-scheme/color/color-suggestion-picker-appearance-with-scrollbar-expected.png
M third_party/blink/web_tests/platform/mac/virtual/dark-color-scheme/fast/forms/color-scheme/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/mac/virtual/dark-color-scheme/fast/forms/color-scheme/color/color-suggestion-picker-appearance-with-scrollbar-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color-scheme/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color-scheme/color/color-suggestion-picker-appearance-with-scrollbar-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/color-suggestion-picker-appearance-empty-list-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/color-suggestion-picker-appearance-one-row-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/color-suggestion-picker-appearance-set-type-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/color-suggestion-picker-appearance-two-rows-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/color-suggestion-picker-appearance-value-attribute-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/color-suggestion-picker-appearance-zoom125-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color/input-appearance-color-expected.png
M third_party/blink/web_tests/platform/win/virtual/controls-refresh-hc/fast/forms/color-scheme/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/win/virtual/controls-refresh-hc/fast/forms/color-scheme/color/color-suggestion-picker-appearance-with-scrollbar-expected.png
M third_party/blink/web_tests/platform/win/virtual/dark-color-scheme/fast/forms/color-scheme/color/color-suggestion-picker-appearance-expected.png
M third_party/blink/web_tests/platform/win/virtual/dark-color-scheme/fast/forms/color-scheme/color/color-suggestion-picker-appearance-with-scrollbar-expected.png

Change size: S

Delta: 64 files changed, 22 insertions(+), 12 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Joey Arhar

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,

Jun 24, 2025, 6:43:38 PMJun 24

to David Baron, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, mac-r...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

luci-bi...@appspot.gserviceaccount.com has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Make <input type=color> with a datalist look like other color inputs. [chromium/src : main]

David Baron (Gerrit)

New activity on the change

Related details

David Baron (Gerrit)

Message from David Baron

Related details

Joey Arhar (Gerrit)

Joey Arhar voted and added 1 comment

Votes added by Joey Arhar

1 comment

Related details

David Baron (Gerrit)

David Baron voted and added 1 comment

Votes added by David Baron

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information

luci-bisection@appspot.gserviceaccount.com (Gerrit)

luci-bi...@appspot.gserviceaccount.com has created a revert of this change

Related details