base::MetricsSubSampler -> base::ShouldRecordSubsampledMetric() [1/N] [chromium/src : main]

0 views

Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,

May 11, 2026, 1:01:21 PM (yesterday) May 11

to Benoit Lize, Jonathan Ross, Colin Blundell, Olivier Li, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, grt+...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org

Attention needed from Benoit Lize, Jonathan Ross and Olivier Li

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Etienne Pierre-Doray . resolved

base/task LGTM

Open in Gerrit

Related details

Attention is currently required from:

Benoit Lize
Jonathan Ross
Olivier Li

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jonathan Ross (Gerrit)

unread,

May 11, 2026, 1:30:42 PM (yesterday) May 11

to Benoit Lize, Etienne Pierre-Doray, Colin Blundell, Olivier Li, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, grt+...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org

Attention needed from Benoit Lize and Olivier Li

Jonathan Ross added 1 comment

File cc/trees/layer_tree_host_impl.h

Line 853, Patchset 6 (Latest): const LayerTreeHostImplClient* client_for_testing() const { return client_; }

Jonathan Ross . unresolved

Looks like `LayerTreeHostImplClient` was removed