New dialog focus steps using Flat Tree [chromium/src : main]
Di Zhang (Gerrit)
Di Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Di Zhang
| Commit-Queue | +1 |
1 comment
status: "stable",WIP: Turning it on to make sure the UI tests are passing.
Related details
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Di Zhang added 1 comment![]( "Open in Gerrit")
WIP: Turning it on to make sure the UI tests are passing.
Looks like some tests weirdly fail on "linux-chromeos-rel", but it seems to be because of how the bot is ran. Moving back to experimental for now.
Related details
- Joey Arhar
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Joey Arhar voted and added 2 comments![]( "Open in Gerrit")
Votes added by Joey Arhar
| Code-Review | +1 |
2 comments
Do the changes in this file need to be flag guarded?
Can we just make this a test case of dialog-focus-shadow.html? Or are you trying to keep that one marked as passing in the other browsers?
Related details
- Di Zhang
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Di Zhang added 1 comment![]( "Open in Gerrit")
Can we just make this a test case of dialog-focus-shadow.html? Or are you trying to keep that one marked as passing in the other browsers?
Everything in that test file has the shadow tree inside the dialog. This test is for when the dialog is inside the shadow tree. So the query for focus-me is outside the dialog. But yes, I can also rewrite that test file a bit and make this work. :)
Related details
- Joey Arhar
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Di Zhang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Di Zhang
| Commit-Queue | +1 |
2 comments
Do the changes in this file need to be flag guarded?
Good point, added.
Di ZhangCan we just make this a test case of dialog-focus-shadow.html? Or are you trying to keep that one marked as passing in the other browsers?
Everything in that test file has the shadow tree inside the dialog. This test is for when the dialog is inside the shadow tree. So the query for focus-me is outside the dialog. But yes, I can also rewrite that test file a bit and make this work. :)
Done
Related details
- Joey Arhar
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Joey Arhar voted and added 2 comments![]( "Open in Gerrit")
Votes added by Joey Arhar
| Code-Review | +1 |
2 comments
I'm guessing this makes a test pass when the new behavior is enabled. Does it affect the behavior without the new flag enabled? I'm worried that this could break the new tab page on stable if the tabindex=-1 does something important with the flag turned off.
Hmm since the other browsers currently pass this test and it was part of interop before, maybe we shouldn't change it in wpt itself until we have agreement. I could imagine people getting unhappy that we made other browsers start failing these tests.
Sorry that I just asked you to move the other subtest into here, I wasn't sure that the current state of things was 😅
Related details
- Di Zhang
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Di Zhang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Di Zhang
| Commit-Queue | +1 |
2 comments
I'm guessing this makes a test pass when the new behavior is enabled. Does it affect the behavior without the new flag enabled? I'm worried that this could break the new tab page on stable if the tabindex=-1 does something important with the flag turned off.
Good point, I have decided to move the webui test changes to a separate CL:
https://chromium-review.googlesource.com/c/chromium/src/+/6127288
I will ask them how safe this change is or if there is a better way around it...
Hmm since the other browsers currently pass this test and it was part of interop before, maybe we shouldn't change it in wpt itself until we have agreement. I could imagine people getting unhappy that we made other browsers start failing these tests.
Sorry that I just asked you to move the other subtest into here, I wasn't sure that the current state of things was 😅
Yeah, adding that test would make this test fail. But so would the existing changes I just made. Either way, we will need their ok. I definitely don't want to merge this until the spec has agreement. But this is the first step...
I will keep this as is for now so they can see all the failing subtests.
Related details
- Joey Arhar
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Joey Arhar voted Code-Review+1![]( "Open in Gerrit")
- Di Zhang
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/51033.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
- Di Zhang
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Di Zhang abandoned this change![]( "Open in Gerrit")
Related details
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |