[Sanitizer] Remove custom element state, when created by is= [chromium/src : main]
0 views
Skip to first unread message
Daniel Vogelheim (Gerrit)
May 29, 2026, 4:21:13 PM (3 days ago) May 29
to Daniel Vogelheim, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Noam Rosenthal
Daniel Vogelheim added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Daniel Vogelheim . resolved
Noam, ptal. Does the approach make sense?
Also, any ideas about the scoped custom registry test?
File third_party/blink/web_tests/external/wpt/sanitizer-api/sethtml-with-custom-elements.tentative.html
Line 37, Patchset 3 (Latest):
test(t => {Daniel Vogelheim . unresolved
This test fails, and apparently always has. I'm not sure it does anything useful. Can I delte it? Or is there a good way to fix it?
Related details
Attention is currently required from:
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noam Rosenthal (Gerrit)
5:27 AM (10 hours ago) 5:27 AM
to Daniel Vogelheim, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Daniel Vogelheim
Noam Rosenthal added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Noam Rosenthal . resolved
I think this sanitizer special casing is better than doing this later in the element setting. So generally good. Found a few missing test cases that might affect implementation though.
File third_party/blink/web_tests/external/wpt/sanitizer-api/sethtml-with-custom-elements.tentative.html
Line 72, Patchset 3 (Latest):
}, "Custom element via is-attribute, where is attribute is removed.");Noam Rosenthal . unresolved
Maybe add a test that does this but allows x-div
Line 80, Patchset 3 (Latest):
}, "Custom element via is-attribute, where is attribute is allowed, but the element is not.");Noam Rosenthal . unresolved
Maybe add a test that asserts this with replaceElementWithChildren and removeElements
Related details
Attention is currently required from:
- Daniel Vogelheim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Vogelheim (Gerrit)
11:06 AM (4 hours ago) 11:06 AM
to Daniel Vogelheim, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Noam Rosenthal
Daniel Vogelheim voted and added 3 comments![]( "Open in Gerrit")
Votes added by Daniel Vogelheim
| Commit-Queue | +1 |
3 comments
File third_party/blink/web_tests/external/wpt/sanitizer-api/sethtml-with-custom-elements.tentative.html
This test fails, and apparently always has. I'm not sure it does anything useful. Can I delte it? Or is there a good way to fix it?
Daniel Vogelheim
I removed this.
Line 72, Patchset 3:
}, "Custom element via is-attribute, where is attribute is removed.");Noam Rosenthal . resolved
Maybe add a test that does this but allows x-div
Daniel Vogelheim
Done
Line 80, Patchset 3:
}, "Custom element via is-attribute, where is attribute is allowed, but the element is not.");Noam Rosenthal . resolved
Maybe add a test that asserts this with replaceElementWithChildren and removeElements
Attention is currently required from:
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noam Rosenthal (Gerrit)
11:14 AM (4 hours ago) 11:14 AM
to Daniel Vogelheim, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Daniel Vogelheim
Noam Rosenthal voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Vogelheim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
11:28 AM (4 hours ago) 11:28 AM
to Daniel Vogelheim, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Daniel Vogelheim
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60316.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Daniel Vogelheim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Vogelheim (Gerrit)
11:51 AM (4 hours ago) 11:51 AM
to Daniel Vogelheim, Blink W3C Test Autoroller, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Daniel Vogelheim voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:57 AM (4 hours ago) 11:57 AM
to Daniel Vogelheim, Blink W3C Test Autoroller, Noam Rosenthal, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, loading-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Sanitizer] Remove custom element state, when created by is=
The HTML parse will process the is= attribute and put the element into
custom element state. When later on the is= attribute is removed by the
Sanitizer, the element is still upgraded because it's been marked as
a custom element.
This change prevents the is=-related custom element to be processed,
when the streaming Sanitizer will remove it.
Bug: 492963096, 513844247, 517171036
Change-Id: I7b10f55b6dd9d568336c731ee8a8c2a52254371f
Reviewed-by: Noam Rosenthal <nrose...@google.com>
Commit-Queue: Daniel Vogelheim <voge...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1639435}
Files:
- M third_party/blink/renderer/core/html/parser/html_construction_site.cc
- M third_party/blink/renderer/core/sanitizer/sanitizer.cc
- M third_party/blink/renderer/core/sanitizer/sanitizer.h
- D third_party/blink/web_tests/external/wpt/sanitizer-api/sanitizer-custom-elements-is.tentative-expected.txt
- D third_party/blink/web_tests/external/wpt/sanitizer-api/sethtml-with-custom-elements-expected.txt
- M third_party/blink/web_tests/external/wpt/sanitizer-api/sethtml-with-custom-elements.html
Change size: L
Delta: 6 files changed, 189 insertions(+), 62 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Noam Rosenthal
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
2:04 PM (1 hour ago) 2:04 PM
to Chromium LUCI CQ, Daniel Vogelheim, Noam Rosenthal, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, loading-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/60316
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages