Use hit testing for APC visible bounding boxes [chromium/src : main]

0 views

Skip to first unread message

Aaron Leventhal (Gerrit)

unread,

Oct 17, 2025, 5:19:23 PM (2 days ago) Oct 17

to Philip Rogers, Khushal Sagar, Andrew Verge, AyeAye, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, mfoltz+wa...@chromium.org, aleventh...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mfoltz...@chromium.org, zol...@webkit.org

Attention needed from Andrew Verge, Khushal Sagar and Philip Rogers

Aaron Leventhal added 2 comments

File third_party/blink/renderer/core/html/media/media_video_visibility_tracker.h

Line 145, Patchset 1: const HitTestRequest::HitTestGeometry& geometry);

AI Code Reviewer . resolved

Blink Style Guide: Naming - May leave obvious parameter names out of function declarations. The parameter name `geometry` is obvious from its type `HitTestRequest::HitTestGeometry` and can be omitted in the function declaration.
_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason
This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Aaron Leventhal

Done

File third_party/blink/renderer/modules/content_extraction/ai_page_content_agent.h

Line 166, Patchset 1: const Node& node,

AI Code Reviewer . resolved

Blink Style Guide: Naming - May leave obvious parameter names out of function declarations. The parameter names `node`, `dom_node_id`, and `geometry` are redundant given their types and can be omitted in the header file.
_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason
This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Aaron Leventhal

Done

Open in Gerrit

Related details

Attention is currently required from:

Andrew Verge
Khushal Sagar
Philip Rogers

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages