Move the AdTracker into its own directory [chromium/src : main]

0 views
Skip to first unread message

Josh Karlin (Gerrit)

unread,
10:24 AM (13 hours ago) 10:24 AM
to Josh Karlin, Nate Chapin, Chromium LUCI CQ, David Bokan, chromium...@chromium.org, Yao Xiao, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtapuska+...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Nate Chapin

Josh Karlin added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Josh Karlin . resolved

Nate, PTAL, thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Nate Chapin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic243ac8c7a114d613777a2b788b631251696c84f
Gerrit-Change-Number: 7639470
Gerrit-PatchSet: 2
Gerrit-Owner: Josh Karlin <jka...@chromium.org>
Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Mar 2026 15:24:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Chapin (Gerrit)

unread,
1:30 PM (10 hours ago) 1:30 PM
to Josh Karlin, Chromium LUCI CQ, David Bokan, chromium...@chromium.org, Yao Xiao, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtapuska+...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Josh Karlin

Nate Chapin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Josh Karlin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic243ac8c7a114d613777a2b788b631251696c84f
    Gerrit-Change-Number: 7639470
    Gerrit-PatchSet: 2
    Gerrit-Owner: Josh Karlin <jka...@chromium.org>
    Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Yao Xiao <yao...@chromium.org>
    Gerrit-Attention: Josh Karlin <jka...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 18:30:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Josh Karlin (Gerrit)

    unread,
    1:42 PM (10 hours ago) 1:42 PM
    to Josh Karlin, Daniel Cheng, Nate Chapin, Chromium LUCI CQ, David Bokan, chromium...@chromium.org, Yao Xiao, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtapuska+...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
    Attention needed from Daniel Cheng

    Josh Karlin added 1 comment

    Patchset-level comments
    Josh Karlin . resolved

    Daniel, PTAL ad presubmit/ thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic243ac8c7a114d613777a2b788b631251696c84f
    Gerrit-Change-Number: 7639470
    Gerrit-PatchSet: 2
    Gerrit-Owner: Josh Karlin <jka...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Yao Xiao <yao...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 18:42:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Josh Karlin (Gerrit)

    unread,
    2:04 PM (9 hours ago) 2:04 PM
    to Josh Karlin, Daniel Cheng, Nate Chapin, Chromium LUCI CQ, David Bokan, chromium...@chromium.org, Yao Xiao, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtapuska+...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
    Attention needed from Daniel Cheng

    Josh Karlin voted Auto-Submit+1

    Auto-Submit+1
    Gerrit-Comment-Date: Fri, 06 Mar 2026 19:04:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Josh Karlin (Gerrit)

    unread,
    9:20 PM (2 hours ago) 9:20 PM
    to Josh Karlin, Daniel Cheng, Nate Chapin, Chromium LUCI CQ, David Bokan, chromium...@chromium.org, Yao Xiao, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtapuska+...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
    Attention needed from Daniel Cheng

    Josh Karlin voted Auto-Submit+0

    Auto-Submit+0
    Gerrit-Comment-Date: Sat, 07 Mar 2026 02:20:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages