Decouple permission element limits by source type [chromium/src : main]

0 views
Skip to first unread message

AI Code Reviewer (Gerrit)

unread,
Sep 17, 2025, 5:53:01 AM (3 days ago) Sep 17
to Thomas Nguyen, Chromium IPC Reviews, Camille Lamy, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, Permissions Reviews, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org
Attention needed from Camille Lamy, Joey Arhar and Thomas Nguyen

AI Code Reviewer added 1 comment

File third_party/blink/renderer/modules/clipboard/mock_clipboard_permission_service.h
Line 36, Patchset 3 (Latest): mojom::blink::EmbeddedPermissionRequestDescriptorPtr descriptor,
AI Code Reviewer . unresolved

Blink Style Guide: Naming - May leave obvious parameter names out of function declarations. The parameter name 'descriptor' is redundant given the descriptive type 'EmbeddedPermissionRequestDescriptorPtr'. Consider omitting the name in the declaration.

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:
  • Camille Lamy
  • Joey Arhar
  • Thomas Nguyen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9d77717ad49a7b25c539a165e023a8c1ce63ec43
Gerrit-Change-Number: 6955089
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Nguyen <tun...@chromium.org>
Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: gwsq
Gerrit-Attention: Camille Lamy <cl...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Sep 2025 09:52:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Nguyen (Gerrit)

unread,
Sep 17, 2025, 5:56:15 AM (3 days ago) Sep 17
to AI Code Reviewer, Chromium IPC Reviews, Camille Lamy, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, Permissions Reviews, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org
Attention needed from Camille Lamy and Joey Arhar

Thomas Nguyen added 1 comment

File third_party/blink/renderer/modules/clipboard/mock_clipboard_permission_service.h
Line 36, Patchset 3: mojom::blink::EmbeddedPermissionRequestDescriptorPtr descriptor,
AI Code Reviewer . resolved

Blink Style Guide: Naming - May leave obvious parameter names out of function declarations. The parameter name 'descriptor' is redundant given the descriptive type 'EmbeddedPermissionRequestDescriptorPtr'. Consider omitting the name in the declaration.

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Thomas Nguyen

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Camille Lamy
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9d77717ad49a7b25c539a165e023a8c1ce63ec43
Gerrit-Change-Number: 6955089
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Nguyen <tun...@chromium.org>
Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: gwsq
Gerrit-Attention: Camille Lamy <cl...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Sep 2025 09:55:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Camille Lamy (Gerrit)

unread,
Sep 17, 2025, 8:53:13 AM (3 days ago) Sep 17
to Thomas Nguyen, AI Code Reviewer, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, Permissions Reviews, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org
Attention needed from Joey Arhar and Thomas Nguyen

Camille Lamy voted and added 1 comment

Votes added by Camille Lamy

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Camille Lamy . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
  • Thomas Nguyen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9d77717ad49a7b25c539a165e023a8c1ce63ec43
Gerrit-Change-Number: 6955089
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Nguyen <tun...@chromium.org>
Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: gwsq
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Sep 2025 12:52:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Sep 18, 2025, 1:31:40 PM (2 days ago) Sep 18
to Thomas Nguyen, Ravjit Uppal, Camille Lamy, AI Code Reviewer, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, Permissions Reviews, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org
Attention needed from Ravjit Uppal and Thomas Nguyen

Joey Arhar voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ravjit Uppal
  • Thomas Nguyen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9d77717ad49a7b25c539a165e023a8c1ce63ec43
Gerrit-Change-Number: 6955089
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Nguyen <tun...@chromium.org>
Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: gwsq
Gerrit-Attention: Ravjit Uppal <rav...@chromium.org>
Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Sep 2025 17:31:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ravjit Uppal (Gerrit)

unread,
Sep 19, 2025, 8:23:22 AM (yesterday) Sep 19
to Thomas Nguyen, Camille Lamy, AI Code Reviewer, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, Permissions Reviews, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org
Attention needed from Thomas Nguyen

Ravjit Uppal voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Nguyen
Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Sep 2025 12:23:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages