[PDF Ink Signatures] Make only one metadata entry [chromium/src : main]

0 views

Skip to first unread message

Lei Zhang (Gerrit)

unread,

May 29, 2026, 6:05:16 PM (3 days ago) May 29

to April Kallmeyer, Andy Phan, Lei Zhang, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, pdf-r...@chromium.org

Attention needed from Andy Phan and April Kallmeyer

Lei Zhang added 3 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Lei Zhang . resolved

Need to figure out how to resolve this vs. crrev.com/c/7870032.

File pdf/pdfium/pdfium_engine.cc

Line 5319, Patchset 5 (Latest): FPDFPageObj_AddExistingMark(text_object.get(), mark);

Lei Zhang . unresolved

Make sure this call succeeded.

File pdf/pdfium/pdfium_ink_reader.cc

Line 379, Patchset 5 (Latest): // Extract attributes from the mark. Only the first text object should have

Lei Zhang . unresolved

Update?

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
April Kallmeyer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages