Add initial base appearance UA-styles for textarea [chromium/src : main]
0 views
Skip to first unread message
Luke (Gerrit)
Mar 4, 2026, 1:20:28 PM (2 days ago) Mar 4
to AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Mar 5, 2026, 2:15:05 PM (yesterday) Mar 5
to Luke, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Luke
Joey Arhar added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/resources/html.css
Line 461, Patchset 5 (Latest):
color: -internal-auto-base(FieldText, unset);Joey Arhar . unresolved
it looks like color is being set for input elements twice, once here and again in the new input, textarea rule added below
Related details
Attention is currently required from:
- Luke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Luke (Gerrit)
Mar 5, 2026, 2:37:53 PM (yesterday) Mar 5
to AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
Luke added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/resources/html.css
it looks like color is being set for input elements twice, once here and again in the new input, textarea rule added below
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
1:34 PM (10 hours ago) 1:34 PM
to Luke, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Luke
Joey Arhar voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joey Arhar
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/core/html/resources/html.css
Line 479, Patchset 6 (Latest):
column-count: initial !important;
-webkit-rtl-ordering: logical;
cursor: text;
white-space: pre-wrap;
word-wrap: break-word;
font-family: monospace;Joey Arhar . unresolved
So we still want all these properties set for base appearance? I don't know what column-count does, but maybe there's a good reason for it to be hard coded to initial...?
Related details
Attention is currently required from:
- Luke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Luke (Gerrit)
2:28 PM (9 hours ago) 2:28 PM
to AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
Luke added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/resources/html.css
Line 479, Patchset 6 (Latest):
column-count: initial !important;
-webkit-rtl-ordering: logical;
cursor: text;
white-space: pre-wrap;
word-wrap: break-word;
font-family: monospace;Joey Arhar . unresolved
So we still want all these properties set for base appearance? I don't know what column-count does, but maybe there's a good reason for it to be hard coded to initial...?
Luke
Probably not all of then, but I'm not sure either way so I'm gonna leave them for now. There's no specced styles for text fields yet so we'll have more clarity once that's done.
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Luke (Gerrit)
2:29 PM (9 hours ago) 2:29 PM
to AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
Luke added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/resources/html.css
Line 479, Patchset 6 (Latest):
column-count: initial !important;
-webkit-rtl-ordering: logical;
cursor: text;
white-space: pre-wrap;
word-wrap: break-word;
font-family: monospace;Joey Arhar . resolved
LukeSo we still want all these properties set for base appearance? I don't know what column-count does, but maybe there's a good reason for it to be hard coded to initial...?
Probably not all of then, but I'm not sure either way so I'm gonna leave them for now. There's no specced styles for text fields yet so we'll have more clarity once that's done.
Luke
Done
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Luke (Gerrit)
2:29 PM (9 hours ago) 2:29 PM
to AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
Luke voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
2:40 PM (9 hours ago) 2:40 PM
to Luke, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/58335.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:46 PM (9 hours ago) 2:46 PM
to Luke, Blink W3C Test Autoroller, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add initial base appearance UA-styles for textarea
Also update a few base appearance input styles
Future patches will adjust the pseudo-elements that apply.
These changes are gated behind the AppearanceBase flag.
See https://drafts.csswg.org/css-forms-1
Bug: 450139531
Change-Id: I12a9961dcc45e7bdd56af5d4782a4c7f873373b7
Commit-Queue: Luke <lwa...@igalia.com>
Reviewed-by: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1595582}
Files:
- M third_party/blink/renderer/core/html/forms/html_text_area_element.cc
- M third_party/blink/renderer/core/html/forms/html_text_area_element.h
- M third_party/blink/renderer/core/html/resources/html.css
- M third_party/blink/web_tests/external/wpt/css/css-forms/input-text-base-appearance-rendering-ref.html
- A third_party/blink/web_tests/external/wpt/css/css-forms/textarea-base-appearance-rendering-ref.tentative.html
- A third_party/blink/web_tests/external/wpt/css/css-forms/textarea-base-appearance-rendering.tentative.html
- M third_party/blink/web_tests/external/wpt/html/semantics/forms/customizable-combobox/customizable-combobox-appearance.html
- M third_party/blink/web_tests/external/wpt/html/semantics/forms/customizable-combobox/resources/customizable-combobox-styles.css
Change size: M
Delta: 8 files changed, 93 insertions(+), 17 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joey Arhar
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
7:47 PM (4 hours ago) 7:47 PM
to Luke, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/58335
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages