Remove comment about tab for customizable select in-page [chromium/src : main]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
Jun 18, 2025, 5:04:10 PMJun 18
to AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Joey Arhar

Mason Freed voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7ef2c24a78ecc1f9f9805362938ecdef9fae030d
Gerrit-Change-Number: 6635532
Gerrit-PatchSet: 1
Gerrit-Owner: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Jun 2025 21:04:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Jun 18, 2025, 5:04:23 PMJun 18
to AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-rev...@chromium.org
Attention needed from Joey Arhar

Mason Freed added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mason Freed . resolved

Sorry for the huge delay

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7ef2c24a78ecc1f9f9805362938ecdef9fae030d
Gerrit-Change-Number: 6635532
Gerrit-PatchSet: 1
Gerrit-Owner: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Jun 2025 21:04:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Jun 24, 2025, 5:35:17 PMJun 24
to Mason Freed, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, blink-rev...@chromium.org

Joey Arhar voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7ef2c24a78ecc1f9f9805362938ecdef9fae030d
Gerrit-Change-Number: 6635532
Gerrit-PatchSet: 1
Gerrit-Owner: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Jun 2025 21:35:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 24, 2025, 6:20:23 PMJun 24
to Mason Freed, AyeAye, blink-...@chromium.org, blink-rev...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove comment about tab for customizable select in-page

The change this comment is asking for was already implemented in
commit d39068c6213a270d0cb8c6ac1db0f2877fdff36b
Bug: 357649033
Change-Id: I7ef2c24a78ecc1f9f9805362938ecdef9fae030d
Commit-Queue: Joey Arhar <jar...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1478223}
Files:
  • M third_party/blink/renderer/core/html/forms/html_option_element.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mason Freed
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7ef2c24a78ecc1f9f9805362938ecdef9fae030d
Gerrit-Change-Number: 6635532
Gerrit-PatchSet: 2
Gerrit-Owner: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages