Md Hasibul Hasan (Gerrit)

unread,

Apr 18, 2024, 9:16:05 PMApr 18

to Kent Tamura, Daniel Cheng, Chromium IPC Reviews, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Luna Lu, Hiroki Nakagawa, Rijubrata Bhaumik, antoniosartori+wa...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, core-timi...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jsbell+ser...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, poscia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Chromium IPC Reviews, Daniel Cheng and Kent Tamura

Md Hasibul Hasan added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Md Hasibul Hasan . resolved

Hello Reviewers,
I need two CR+1 and CQ+2 to land a patch as I am not a committer. That's why I am adding multiple reviewers.

Kindly take a look when available.
Also kindly start a dry run as I do not have try job access.

Thanks!!

Open in Gerrit

Related details

Attention is currently required from:

Chromium IPC Reviews
Daniel Cheng
Kent Tamura

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Apr 18, 2024, 9:19:58 PMApr 18

to Md Hasibul Hasan, Chromium IPC Reviews, Chromium LUCI CQ, Kent Tamura, Daniel Cheng, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Luna Lu, Hiroki Nakagawa, Rijubrata Bhaumik, antoniosartori+wa...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, core-timi...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jsbell+ser...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, poscia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Daniel Cheng and Md Hasibul Hasan

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: dch...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): dch...@chromium.org

Note: IPC gwsq added no new reviewers; existing reviewers satisfied requirements!

Reviewer source(s):
dch...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Md Hasibul Hasan

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kent Tamura (Gerrit)

unread,

Apr 18, 2024, 9:32:03 PMApr 18

to Md Hasibul Hasan, Kent Tamura, Chromium IPC Reviews, Chromium LUCI CQ, Daniel Cheng, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Luna Lu, Hiroki Nakagawa, Rijubrata Bhaumik, antoniosartori+wa...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, core-timi...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jsbell+ser...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, poscia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Daniel Cheng and Md Hasibul Hasan

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Code-Review

+1

1 comment

File third_party/blink/renderer/platform/wtf/text/string_utf8_adaptor.h

Line 56, Patchset 3 (Latest): std::string_view AsStringPiece() const {

Kent Tamura . unresolved

The method should be renamed to `AsStringView()`.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Md Hasibul Hasan

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Apr 19, 2024, 1:33:42 AMApr 19

to Md Hasibul Hasan, Daniel Cheng, Kent Tamura, Chromium IPC Reviews, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Luna Lu, Hiroki Nakagawa, Rijubrata Bhaumik, antoniosartori+wa...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, core-timi...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jsbell+ser...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, poscia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Md Hasibul Hasan

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Daniel Cheng . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Md Hasibul Hasan

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Md Hasibul Hasan (Gerrit)

unread,

Apr 19, 2024, 1:07:41 PMApr 19

to Gyuyoung Kim, AyeAye, Daniel Cheng, Kent Tamura, Chromium IPC Reviews, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Luna Lu, Hiroki Nakagawa, Rijubrata Bhaumik, apaselti...@chromium.org, devtools-re...@chromium.org, blink-revi...@chromium.org, antoniosartori+wa...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, core-timi...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jsbell+ser...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, poscia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Daniel Cheng and Kent Tamura

Md Hasibul Hasan added 2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Md Hasibul Hasan . resolved

Renamed AsStringPiece to AsStringView.

Kindly take another look when available.

Thanks!!

File third_party/blink/renderer/platform/wtf/text/string_utf8_adaptor.h

Line 56, Patchset 3: std::string_view AsStringPiece() const {

Kent Tamura . resolved

The method should be renamed to `AsStringView()`.

Md Hasibul Hasan

Renamed.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Kent Tamura

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Apr 19, 2024, 1:32:00 PMApr 19

to Md Hasibul Hasan, Daniel Cheng, Gyuyoung Kim, AyeAye, Kent Tamura, Chromium IPC Reviews, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Luna Lu, Hiroki Nakagawa, Rijubrata Bhaumik, apaselti...@chromium.org, devtools-re...@chromium.org, blink-revi...@chromium.org, antoniosartori+wa...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, core-timi...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jsbell+ser...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, poscia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Kent Tamura and Md Hasibul Hasan

Daniel Cheng voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Kent Tamura
Md Hasibul Hasan

satisfied_requirement

unsatisfied_requirement

open

diffy

Kent Tamura (Gerrit)

unread,

Apr 19, 2024, 6:54:31 PMApr 19

to Md Hasibul Hasan, Kent Tamura, Helmut Januschka, Daniel Cheng, Gyuyoung Kim, AyeAye, Chromium IPC Reviews, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Luna Lu, Hiroki Nakagawa, Rijubrata Bhaumik, apaselti...@chromium.org, devtools-re...@chromium.org, blink-revi...@chromium.org, antoniosartori+wa...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, core-timi...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jsbell+ser...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, poscia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Daniel Cheng, Helmut Januschka and Md Hasibul Hasan

Kent Tamura voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Helmut Januschka
Md Hasibul Hasan

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Apr 19, 2024, 8:17:49 PMApr 19

to Md Hasibul Hasan, Kent Tamura, Helmut Januschka, Daniel Cheng, Gyuyoung Kim, AyeAye, Chromium IPC Reviews, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Luna Lu, Hiroki Nakagawa, Rijubrata Bhaumik, apaselti...@chromium.org, devtools-re...@chromium.org, blink-revi...@chromium.org, antoniosartori+wa...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, core-timi...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jsbell+ser...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, poscia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Helmut Januschka and Md Hasibul Hasan

Daniel Cheng voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 19, 2024, 9:00:35 PMApr 19

to Md Hasibul Hasan, Kent Tamura, Helmut Januschka, Daniel Cheng, Gyuyoung Kim, AyeAye, Chromium IPC Reviews, Alexis Menard, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Luna Lu, Hiroki Nakagawa, Rijubrata Bhaumik, apaselti...@chromium.org, devtools-re...@chromium.org, blink-revi...@chromium.org, antoniosartori+wa...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, core-timi...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, jsbell+ser...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, poscia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

[Blink] Convert StringPiece to std::string_view in //third_party/blink

The changes of this CL are made using the following script with some
minor changes.

Used printf for writing into files instead of echo as it was not
skipping special characters like "\n" and messing up files.

Script: https://issues.chromium.org/issues/40506050#comment347

Removed header "base/strings/string_piece.h"
Added header "<string_view>" where applicable
Replaced base::StringPiece16 with std::u16string_view
Replaced base::StringPiece with std::string_view

Bug: 40506050

Change-Id: Ie12d796a4f720d214d5c1f35a45bfea9b6cd554f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462849

Reviewed-by: Kent Tamura <tk...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1290276}

Files:

M third_party/blink/common/custom_handlers/protocol_handler_utils.cc
M third_party/blink/common/fenced_frame/fenced_frame_utils.cc
M third_party/blink/common/interest_group/ad_display_size_utils.cc
M third_party/blink/common/loader/mime_sniffing_throttle_unittest.cc
M third_party/blink/common/loader/mime_sniffing_url_loader.cc
M third_party/blink/common/loader/record_load_histograms.cc
M third_party/blink/common/loader/throttling_url_loader.cc
M third_party/blink/common/origin_trials/persistent_origin_trials.cc
M third_party/blink/common/origin_trials/trial_token.cc
M third_party/blink/common/origin_trials/trial_token_unittest.cc
M third_party/blink/common/origin_trials/trial_token_validator.cc
M third_party/blink/common/origin_trials/trial_token_validator_unittest.cc
M third_party/blink/common/privacy_budget/identifiability_metric_builder_unittest.cc
M third_party/blink/common/privacy_budget/identifiability_metrics_unittest.cc
M third_party/blink/common/privacy_budget/identifiable_token_unittest.cc
M third_party/blink/common/service_worker/service_worker_router_rule_mojom_traits_unittest.cc
M third_party/blink/common/shared_storage/module_script_downloader.cc
M third_party/blink/common/shared_storage/shared_storage_utils.cc
M third_party/blink/common/storage_key/storage_key.cc
M third_party/blink/common/storage_key/storage_key_unittest.cc
M third_party/blink/common/thread_safe_browser_interface_broker_proxy.cc
M third_party/blink/common/unique_name/unique_name_helper.cc
M third_party/blink/common/unique_name/unique_name_helper_unittest.cc
M third_party/blink/common/web_package/web_package_request_matcher.cc
M third_party/blink/public/common/custom_handlers/protocol_handler_utils.h
M third_party/blink/public/common/interest_group/ad_display_size_utils.h
M third_party/blink/public/common/loader/mime_sniffing_url_loader.h
M third_party/blink/public/common/loader/throttling_url_loader.h
M third_party/blink/public/common/loader/url_loader_throttle.h
M third_party/blink/public/common/manifest/manifest_mojom_traits.h
M third_party/blink/public/common/manifest/manifest_util.h
M third_party/blink/public/common/origin_trials/origin_trial_policy.h
M third_party/blink/public/common/origin_trials/origin_trials.h
M third_party/blink/public/common/origin_trials/trial_token.h
M third_party/blink/public/common/origin_trials/trial_token_validator.h
M third_party/blink/public/common/permissions_policy/policy_helper_public.h
M third_party/blink/public/common/privacy_budget/identifiable_token.h
M third_party/blink/public/common/privacy_budget/identifiable_token_builder.h
M third_party/blink/public/common/safe_url_pattern_mojom_traits.h
M third_party/blink/public/common/shared_storage/shared_storage_utils.h
M third_party/blink/public/common/storage_key/storage_key.h
M third_party/blink/public/common/thread_safe_browser_interface_broker_proxy.h
M third_party/blink/public/common/unique_name/unique_name_helper.h
M third_party/blink/public/platform/web_dedicated_or_shared_worker_fetch_context.h
M third_party/blink/renderer/build/scripts/templates/origin_trials.cc.tmpl
M third_party/blink/renderer/core/css/style_perftest.cc
M third_party/blink/renderer/core/frame/attribution_src_loader.cc
M third_party/blink/renderer/core/html/html_perftest.cc
M third_party/blink/renderer/core/loader/anchor_element_interaction_test.cc
M third_party/blink/renderer/core/loader/url_matcher.cc
M third_party/blink/renderer/core/loader/url_matcher.h
M third_party/blink/renderer/core/origin_trials/origin_trial_context.cc
M third_party/blink/renderer/core/origin_trials/origin_trial_context_test.cc
M third_party/blink/renderer/core/timing/background_tracing_helper.cc
M third_party/blink/renderer/core/timing/background_tracing_helper.h
M third_party/blink/renderer/core/timing/background_tracing_helper_test.cc
M third_party/blink/renderer/core/url_pattern/url_pattern_component.cc
M third_party/blink/renderer/modules/ad_auction/validate_blink_interest_group_test.cc
M third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc
M third_party/blink/renderer/modules/file_system_access/file_system_underlying_sink.cc
M third_party/blink/renderer/modules/mediarecorder/media_recorder_handler.cc
M third_party/blink/renderer/modules/mediarecorder/media_recorder_handler.h
M third_party/blink/renderer/modules/mediarecorder/media_recorder_handler_unittest.cc
M third_party/blink/renderer/modules/mediarecorder/video_track_recorder_unittest.cc
M third_party/blink/renderer/modules/mediastream/media_stream_audio_processor.cc
M third_party/blink/renderer/modules/navigatorcontentutils/navigator_content_utils.cc
M third_party/blink/renderer/modules/nfc/ndef_record.cc
M third_party/blink/renderer/modules/service_worker/service_worker_router_type_converter_test.cc
M third_party/blink/renderer/platform/bindings/parkable_string.cc
M third_party/blink/renderer/platform/exported/file_path_conversion.cc
M third_party/blink/renderer/platform/exported/url_conversion.cc
M third_party/blink/renderer/platform/instrumentation/tracing/traced_value.cc
M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
M third_party/blink/renderer/platform/loader/fetch/url_loader/dedicated_or_shared_worker_fetch_context_impl.h
M third_party/blink/renderer/platform/loader/fetch/url_loader/navigation_body_loader_unittest.cc
M third_party/blink/renderer/platform/loader/fetch/url_loader/request_conversion.cc
M third_party/blink/renderer/platform/loader/fetch/url_loader/url_loader_unittest.cc
M third_party/blink/renderer/platform/loader/link_header.cc
M third_party/blink/renderer/platform/mojo/security_origin_mojom_traits.h
M third_party/blink/renderer/platform/network/http_parsers.cc
M third_party/blink/renderer/platform/network/http_parsers_test.cc
M third_party/blink/renderer/platform/network/network_utils.cc
M third_party/blink/renderer/platform/peerconnection/fake_connection_test_base.h
M third_party/blink/renderer/platform/peerconnection/rtc_stats.cc
M third_party/blink/renderer/platform/region_capture_crop_id.cc
M third_party/blink/renderer/platform/weborigin/known_ports.cc
M third_party/blink/renderer/platform/weborigin/kurl.cc
M third_party/blink/renderer/platform/weborigin/kurl_test.cc
M third_party/blink/renderer/platform/weborigin/security_origin_test.cc
M third_party/blink/renderer/platform/wtf/text/string_utf8_adaptor.h
M third_party/blink/renderer/platform/wtf/text/wtf_string.cc
M third_party/blink/renderer/platform/wtf/text/wtf_string.h
M third_party/blink/renderer/platform/wtf/uuid.cc

Change size: L

Delta: 94 files changed, 393 insertions(+), 335 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng, +1 by Kent Tamura

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[Blink] Convert StringPiece to std::string_view in //third_party/blink [chromium/src : main]

Md Hasibul Hasan (Gerrit)

Md Hasibul Hasan added 1 comment

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Kent Tamura (Gerrit)

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

1 comment

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

1 comment

Related details

Md Hasibul Hasan (Gerrit)

Md Hasibul Hasan added 2 comments

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted

Related details

Kent Tamura (Gerrit)

Kent Tamura voted Code-Review+1

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information