[SelectMenu] Apply controller code to the author provided shadow DOM. [chromium/src : main]
Ionel Popescu (Gerrit)
Attention is currently required from: Dan Clark, Mason Freed.
Ionel Popescu would like Dan Clark and Mason Freed to review this change.
[SelectMenu] Apply controller code to the author provided shadow DOM.
This change ensure that controller code is applied to the author
provided shadow DOM by having the mutation observer watch
changes for the shadow root.
Because of that we can't rely on the slotchange event to catch
when the default parts were replaced as we would have duplicate
notifications. In order to do that
HTMLSelectMenuElement::SelectMutationCallback should be extended to
handle the case when a node with slot attribute is inserted/removed
even if its part attribute isn't set.
Bug: 1121840
Change-Id: I20ec7a00b8a3a130740a4dc0354bba0563ebb0a1
---
M third_party/blink/renderer/core/html/forms/html_select_menu_element.cc
M third_party/blink/renderer/core/html/forms/html_select_menu_element.h
A third_party/blink/web_tests/external/wpt/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative-expected.txt
M third_party/blink/web_tests/external/wpt/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative.html
D third_party/blink/web_tests/external/wpt/html/semantics/forms/the-selectmenu-element/selectmenu-shadow-root-replacement.tentative-expected.txt
M third_party/blink/web_tests/external/wpt/html/semantics/forms/the-selectmenu-element/selectmenu-shadow-root-replacement.tentative.html
6 files changed, 52 insertions(+), 54 deletions(-)
To view, visit change 3166023. To unsubscribe, or for help writing mail filters, visit settings.
Ionel Popescu (Gerrit)
Attention is currently required from: Dan Clark, Mason Freed.
1 comment:
Patchset:
PTAL, thanks!
To view, visit change 3166023. To unsubscribe, or for help writing mail filters, visit settings.
Blink WPT Bot (Gerrit)
Attention is currently required from: Dan Clark, Mason Freed.
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/30827.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Dan Clark (Gerrit)
Attention is currently required from: Ionel Popescu, Mason Freed.
Patch set 1:Code-Review +1
1 comment:
Patchset:
LGTM, thanks!
In order to do that HTMLSelectMenuElement::SelectMutationCallback should be extended to handle the case when a node with slot attribute is inserted/removed even if its part attribute isn't set.
I think we might also need to start watching for `slot` attribute changes in the observer to catch cases where an existing element under the <selectmenu> has its `slot` attribute added/removed/changed.
To view, visit change 3166023. To unsubscribe, or for help writing mail filters, visit settings.
Ionel Popescu (Gerrit)
Attention is currently required from: Mason Freed.
1 comment:
Patchset:
LGTM, thanks! […]
I agree, I am planning to address this in a future CL. thanks!
To view, visit change 3166023. To unsubscribe, or for help writing mail filters, visit settings.
Mason Freed (Gerrit)
Attention is currently required from: Ionel Popescu.
Patch set 1:Code-Review +1
1 comment:
Patchset:
LGTM! Nice change.
To view, visit change 3166023. To unsubscribe, or for help writing mail filters, visit settings.
Ionel Popescu (Gerrit)
Attention is currently required from: Ionel Popescu.
Patch set 1:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
[SelectMenu] Apply controller code to the author provided shadow DOM.
This change ensure that controller code is applied to the author
provided shadow DOM by having the mutation observer watch
changes for the shadow root.
Because of that we can't rely on the slotchange event to catch
when the default parts were replaced as we would have duplicate
notifications. In order to do that
HTMLSelectMenuElement::SelectMutationCallback should be extended to
handle the case when a node with slot attribute is inserted/removed
even if its part attribute isn't set.
Bug: 1121840
Change-Id: I20ec7a00b8a3a130740a4dc0354bba0563ebb0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3166023
Reviewed-by: Dan Clark <dan...@microsoft.com>
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Ionel Popescu <iopo...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#922716}
---
M third_party/blink/renderer/core/html/forms/html_select_menu_element.cc
M third_party/blink/renderer/core/html/forms/html_select_menu_element.h
A third_party/blink/web_tests/external/wpt/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative-expected.txt
M third_party/blink/web_tests/external/wpt/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative.html
D third_party/blink/web_tests/external/wpt/html/semantics/forms/the-selectmenu-element/selectmenu-shadow-root-replacement.tentative-expected.txt
M third_party/blink/web_tests/external/wpt/html/semantics/forms/the-selectmenu-element/selectmenu-shadow-root-replacement.tentative.html
6 files changed, 52 insertions(+), 54 deletions(-)
Blink WPT Bot (Gerrit)
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/30827