Do not pause the Player when element is moved to a different document [chromium/src : main]
0 views
Skip to first unread message
Javier Fernandez (Gerrit)
May 10, 2026, 4:40:27 PM (2 days ago) May 10
to Dale Curtis, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Dale Curtis
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Dale Curtis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Javier Fernandez (Gerrit)
May 11, 2026, 7:59:30 AM (yesterday) May 11
to Dale Curtis, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Dale Curtis and Javier Fernandez
Message from Javier Fernandez![]( "Open in Gerrit")
Attention is currently required from:
- Dale Curtis
- Javier Fernandez
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
May 11, 2026, 12:58:58 PM (yesterday) May 11
to Javier Fernandez, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Javier Fernandez
Dale Curtis added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/media/html_media_element.cc
Line 718, Patchset 4 (Latest):
paused_ = false;Dale Curtis . unresolved
Play/pause state is pretty complicated. I'm not sure it's sufficient to just set this back to false. It probably at least needs `SetPaused(false)` and more likely `PlayInternal`. Can you investigate a bit more here?
Related details
Attention is currently required from:
- Javier Fernandez
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Javier Fernandez (Gerrit)
May 11, 2026, 1:12:13 PM (yesterday) May 11
to Dale Curtis, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Dale Curtis
Javier Fernandez added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/media/html_media_element.cc
Line 718, Patchset 4 (Latest):
paused_ = false;Dale Curtis . unresolved
Play/pause state is pretty complicated. I'm not sure it's sufficient to just set this back to false. It probably at least needs `SetPaused(false)` and more likely `PlayInternal`. Can you investigate a bit more here?
Javier Fernandez
I see, I've been perhaps too focused on the specific test failing. I may need a more complete test case to understand all the implications of the play / pause logic. Any idea is welcome.
I'm going to investigate it further in any case. Thanks for the review.
Related details
Attention is currently required from:
- Dale Curtis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages