[html-in-canvas] Support offscreen canvas in a worker thread [chromium/src : main]

0 views
Skip to first unread message

Philip Rogers (Gerrit)

unread,
Apr 1, 2026, 8:00:27 PM (10 hours ago) Apr 1
to Stephen Chenney, Stefan Zager, Stephen Chenney, Dirk Schulze, Hiroki Nakagawa, AyeAye, Philip Jägenstedt, Chromium LUCI CQ, AI Code Reviewer, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kenjibah...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, shimazu+se...@chromium.org, kinuko+ser...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jmedle...@chromium.org

Philip Rogers added 2 comments

File third_party/blink/renderer/platform/graphics/paint/effect_paint_property_node.h
Line 392, Patchset 8: return state_.canvas_child_state.transform_origin;
Philip Rogers . resolved

preserve the logic in HTMLCanvasElement::TakeGridScaleFactorSnapshot

Line 158, Patchset 8: CanvasChildState canvas_child_state;
Philip Rogers . resolved

todo: break this out into a unique ptr.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I78037b55987045c209a158421130b939394653f0
Gerrit-Change-Number: 7708746
Gerrit-PatchSet: 17
Gerrit-Owner: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Philip Jägenstedt <foo...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@google.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 00:00:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Apr 1, 2026, 8:00:35 PM (10 hours ago) Apr 1
to Stephen Chenney, Stefan Zager, Stephen Chenney, Dirk Schulze, Hiroki Nakagawa, AyeAye, Philip Jägenstedt, Chromium LUCI CQ, AI Code Reviewer, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kenjibah...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, shimazu+se...@chromium.org, kinuko+ser...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jmedle...@chromium.org

Philip Rogers voted Commit-Queue+1

Commit-Queue+1
Gerrit-Comment-Date: Thu, 02 Apr 2026 00:00:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages