Support colorspace and alpha attributes on <input type=color> [chromium/src : main]

0 views
Skip to first unread message

Jason Leo (Gerrit)

unread,
Jun 17, 2026, 8:31:25 PM (7 days ago) Jun 17
to Mason Freed, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Mason Freed

Jason Leo added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
Gerrit-Change-Number: 7952977
Gerrit-PatchSet: 6
Gerrit-Owner: Jason Leo <cg...@chromium.org>
Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Jun 2026 00:30:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jason Leo (Gerrit)

unread,
Jun 17, 2026, 8:32:23 PM (7 days ago) Jun 17
to David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from David Baron

Jason Leo added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • David Baron
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
Gerrit-Change-Number: 7952977
Gerrit-PatchSet: 6
Gerrit-Owner: Jason Leo <cg...@chromium.org>
Gerrit-Reviewer: David Baron <dba...@chromium.org>
Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
Gerrit-Attention: David Baron <dba...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Jun 2026 00:31:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jason Leo (Gerrit)

unread,
Jun 22, 2026, 1:46:57 AM (3 days ago) Jun 22
to David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from David Baron and Joey Arhar

Jason Leo added 1 comment

Patchset-level comments
Jason Leo . resolved

Please take a look, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • David Baron
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
Gerrit-Change-Number: 7952977
Gerrit-PatchSet: 6
Gerrit-Owner: Jason Leo <cg...@chromium.org>
Gerrit-Reviewer: David Baron <dba...@chromium.org>
Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: David Baron <dba...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Jun 2026 05:46:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Baron (Gerrit)

unread,
Jun 22, 2026, 2:50:41 PM (2 days ago) Jun 22
to Jason Leo, David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Jason Leo and Joey Arhar

David Baron added 7 comments

Patchset-level comments
David Baron . resolved

I think this largely looks good to me, with a few comments below.

I did a decent amount of spec reading (and made [one spec PR](https://github.com/whatwg/html/pull/12606)!) although I don't think I reviewed all of the relevant pieces of spec. But hopefully the tests have good enough coverage!

Commit Message
Line 16, Patchset 6 (Latest):ChromeStatus: https://chromestatus.com/feature/5736024861966336
David Baron . unresolved

Side comment: It might be good to give this chromestatus entry a more descriptive name. (`InputTypeColorEnhancements` should still be the finch feature name.)

Also, this `Chromestatus:` line could be a proper git footer if you want, adjacent to `Bug:` and `Change-Id:`.

File third_party/blink/renderer/core/html/forms/color_input_type.h
Line 95, Patchset 6 (Latest): // attributes, per the value sanitization algorithm for type=color.
David Baron . unresolved

More directly I think this is https://html.spec.whatwg.org/multipage/input.html#serialize-a-color-well-control-color which is just a part of the value sanitization algorithm.

Line 93, Patchset 6 (Latest): bool AlphaAttributeEnabled() const;
David Baron . unresolved

I'm a bit worried `AlphaAttributeEnabled` sounds too much like a test for whether a feature is enabled. Maybe something more like `HasAlphaComponent` would be better?

File third_party/blink/renderer/core/html/forms/color_input_type.cc
Line 319, Patchset 6 (Latest): AddWarningToConsole(
"The specified value %s does not conform to the required format. The "
"format is \"#rrggbb\" where rr, gg, bb are two-digit hexadecimal "
"numbers.",
David Baron . unresolved

I think this warning could use some updates?

Line 360, Patchset 6 (Latest): GetElement().SetNonDirtyValue(
David Baron . unresolved

I didn't see a test for this case of reparsing the original value rather than the current one. If there indeed isn't one, could you add one? (It could cite https://github.com/whatwg/html/issues/12057 .)

File third_party/blink/renderer/core/html/forms/html_input_element.cc
Line 1011, Patchset 6 (Latest): if (RuntimeEnabledFeatures::InputTypeColorEnhancementsEnabled()) {
David Baron . unresolved

I think this `RuntimeEnabledFeatures` check belongs better inside `ColorInputType::ColorSpaceOrAlphaAttributeChanged`

Open in Gerrit

Related details

Attention is currently required from:
  • Jason Leo
  • Joey Arhar
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
    Gerrit-Change-Number: 7952977
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jason Leo <cg...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Attention: Joey Arhar <jar...@chromium.org>
    Gerrit-Attention: Jason Leo <cg...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Jun 2026 18:50:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joey Arhar (Gerrit)

    unread,
    Jun 22, 2026, 5:23:51 PM (2 days ago) Jun 22
    to Jason Leo, David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Jason Leo

    Joey Arhar added 1 comment

    Commit Message
    Joey Arhar . unresolved

    Are you planning to make additional changes to the color picker to allow the user to choose alpha?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jason Leo
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
    Gerrit-Change-Number: 7952977
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jason Leo <cg...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Attention: Jason Leo <cg...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Jun 2026 21:23:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jason Leo (Gerrit)

    unread,
    Jun 23, 2026, 12:00:33 AM (2 days ago) Jun 23
    to David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Jason Leo added 2 comments

    Patchset-level comments
    Jason Leo . resolved

    Will address reviews later today.

    Commit Message
    Joey Arhar . resolved

    Are you planning to make additional changes to the color picker to allow the user to choose alpha?

    Jason Leo

    I am planning to do it in the following CLs, so the answer is yes :)

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
    Gerrit-Change-Number: 7952977
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jason Leo <cg...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Comment-Date: Tue, 23 Jun 2026 03:59:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Joey Arhar <jar...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jason Leo (Gerrit)

    unread,
    Jun 23, 2026, 10:36:29 AM (2 days ago) Jun 23
    to David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from David Baron

    Jason Leo added 6 comments

    Commit Message

    Side comment: It might be good to give this chromestatus entry a more descriptive name. (`InputTypeColorEnhancements` should still be the finch feature name.)

    Also, this `Chromestatus:` line could be a proper git footer if you want, adjacent to `Bug:` and `Change-Id:`.

    Jason Leo

    Done

    File third_party/blink/renderer/core/html/forms/color_input_type.h
    Line 95, Patchset 6: // attributes, per the value sanitization algorithm for type=color.
    David Baron . resolved

    More directly I think this is https://html.spec.whatwg.org/multipage/input.html#serialize-a-color-well-control-color which is just a part of the value sanitization algorithm.

    Jason Leo

    Done

    Line 93, Patchset 6: bool AlphaAttributeEnabled() const;
    David Baron . resolved

    I'm a bit worried `AlphaAttributeEnabled` sounds too much like a test for whether a feature is enabled. Maybe something more like `HasAlphaComponent` would be better?

    Jason Leo

    Done

    File third_party/blink/renderer/core/html/forms/color_input_type.cc
    Line 319, Patchset 6: AddWarningToConsole(

    "The specified value %s does not conform to the required format. The "
    "format is \"#rrggbb\" where rr, gg, bb are two-digit hexadecimal "
    "numbers.",
    David Baron . resolved

    I think this warning could use some updates?

    Jason Leo

    Done

    Line 360, Patchset 6: GetElement().SetNonDirtyValue(
    David Baron . resolved

    I didn't see a test for this case of reparsing the original value rather than the current one. If there indeed isn't one, could you add one? (It could cite https://github.com/whatwg/html/issues/12057 .)

    Jason Leo

    added one

    File third_party/blink/renderer/core/html/forms/html_input_element.cc
    Line 1011, Patchset 6: if (RuntimeEnabledFeatures::InputTypeColorEnhancementsEnabled()) {
    David Baron . resolved

    I think this `RuntimeEnabledFeatures` check belongs better inside `ColorInputType::ColorSpaceOrAlphaAttributeChanged`

    Jason Leo

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Baron
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
      Gerrit-Change-Number: 7952977
      Gerrit-PatchSet: 8
      Gerrit-Owner: Jason Leo <cg...@chromium.org>
      Gerrit-Reviewer: David Baron <dba...@chromium.org>
      Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Attention: David Baron <dba...@chromium.org>
      Gerrit-Comment-Date: Tue, 23 Jun 2026 14:35:53 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: David Baron <dba...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      David Baron (Gerrit)

      unread,
      Jun 23, 2026, 11:06:00 AM (2 days ago) Jun 23
      to Jason Leo, David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Jason Leo

      David Baron voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jason Leo
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
      Gerrit-Change-Number: 7952977
      Gerrit-PatchSet: 8
      Gerrit-Owner: Jason Leo <cg...@chromium.org>
      Gerrit-Reviewer: David Baron <dba...@chromium.org>
      Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Attention: Jason Leo <cg...@chromium.org>
      Gerrit-Comment-Date: Tue, 23 Jun 2026 15:05:49 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Jun 23, 2026, 11:26:01 AM (2 days ago) Jun 23
      to Jason Leo, David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Jason Leo

      Message from Blink W3C Test Autoroller

      Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60837.

      When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

      WPT Export docs:
      https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jason Leo
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
      Gerrit-Change-Number: 7952977
      Gerrit-PatchSet: 8
      Gerrit-Owner: Jason Leo <cg...@chromium.org>
      Gerrit-Reviewer: David Baron <dba...@chromium.org>
      Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-Comment-Date: Tue, 23 Jun 2026 15:25:35 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Jason Leo (Gerrit)

      unread,
      Jun 23, 2026, 12:48:46 PM (2 days ago) Jun 23
      to (Julie)Jeongeun Kim, Kevin Babbitt, Blink W3C Test Autoroller, David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from David Baron

      Jason Leo added 1 comment

      Patchset-level comments
      File-level comment, Patchset 9 (Latest):
      Jason Leo . resolved

      @dba...@chromium.org sorry, need restamp

      Open in Gerrit

      Related details

      Attention is currently required from:
      • David Baron
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
        Gerrit-Change-Number: 7952977
        Gerrit-PatchSet: 9
        Gerrit-Owner: Jason Leo <cg...@chromium.org>
        Gerrit-Reviewer: David Baron <dba...@chromium.org>
        Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
        Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
        Gerrit-Attention: David Baron <dba...@chromium.org>
        Gerrit-Comment-Date: Tue, 23 Jun 2026 16:48:06 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        David Baron (Gerrit)

        unread,
        Jun 24, 2026, 9:40:31 AM (17 hours ago) Jun 24
        to Jason Leo, David Baron, (Julie)Jeongeun Kim, Kevin Babbitt, Blink W3C Test Autoroller, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
        Attention needed from Jason Leo

        David Baron voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Jason Leo
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
          Gerrit-Change-Number: 7952977
          Gerrit-PatchSet: 9
          Gerrit-Owner: Jason Leo <cg...@chromium.org>
          Gerrit-Reviewer: David Baron <dba...@chromium.org>
          Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
          Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
          Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
          Gerrit-Attention: Jason Leo <cg...@chromium.org>
          Gerrit-Comment-Date: Wed, 24 Jun 2026 13:40:23 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Jason Leo (Gerrit)

          unread,
          Jun 24, 2026, 12:53:23 PM (14 hours ago) Jun 24
          to David Baron, (Julie)Jeongeun Kim, Kevin Babbitt, Blink W3C Test Autoroller, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

          Jason Leo voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention set is empty
          Gerrit-Comment-Date: Wed, 24 Jun 2026 16:52:51 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Jason Leo (Gerrit)

          unread,
          Jun 24, 2026, 1:54:15 PM (13 hours ago) Jun 24
          to David Baron, (Julie)Jeongeun Kim, Kevin Babbitt, Blink W3C Test Autoroller, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

          Jason Leo voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention set is empty
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
          Gerrit-Change-Number: 7952977
          Gerrit-PatchSet: 10
          Gerrit-Owner: Jason Leo <cg...@chromium.org>
          Gerrit-Reviewer: David Baron <dba...@chromium.org>
          Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
          Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
          Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
          Gerrit-Comment-Date: Wed, 24 Jun 2026 17:53:40 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Jun 24, 2026, 2:27:23 PM (12 hours ago) Jun 24
          to Jason Leo, David Baron, (Julie)Jeongeun Kim, Akihiro Ota, Kevin Babbitt, Blink W3C Test Autoroller, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

          Chromium LUCI CQ submitted the change with unreviewed changes

          Unreviewed changes

          9 is the latest approved patch-set.
          The change was submitted with unreviewed changes in the following files:

          ```
          The name of the file: third_party/blink/web_tests/external/wpt/html/dom/idlharness.https_include=HTML.+-expected.txt
          Insertions: 1, Deletions: 3.

          The diff is too large to show. Please review the diff.
          ```

          Change information

          Commit message:
          Support colorspace and alpha attributes on <input type=color>

          Adds the colorspace/colorSpace[1] and alpha[2] content/IDL attributes
          behind the experimental InputTypeColorEnhancements flag, letting color
          inputs serialize wide-gamut (Display P3) and alpha-bearing values per
          the HTML spec. Achromatic sRGB colors are converted to Display P3
          directly to avoid float-matrix white-point drift.


          [1]: https://html.spec.whatwg.org/multipage/input.html#dom-input-colorspace
          [2]: https://html.spec.whatwg.org/multipage/input.html#attr-input-alpha
          Bug: 368059226
          Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
          Commit-Queue: Jason Leo <cg...@chromium.org>
          Reviewed-by: David Baron <dba...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1651849}
          Files:
          • M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
          • M third_party/blink/renderer/core/html/forms/color_input_type.cc
          • M third_party/blink/renderer/core/html/forms/color_input_type.h
          • M third_party/blink/renderer/core/html/forms/html_input_element.cc
          • M third_party/blink/renderer/core/html/forms/html_input_element.idl
          • M third_party/blink/renderer/core/html/forms/input_type.cc
          • M third_party/blink/renderer/core/html/forms/input_type.h
          • M third_party/blink/renderer/core/html/html_attribute_names.json5
          • M third_party/blink/renderer/core/html/keywords.json5
          • M third_party/blink/renderer/platform/runtime_enabled_features.json5
          • M third_party/blink/web_tests/accessibility/color-well-expected.txt
          • M third_party/blink/web_tests/external/wpt/html/dom/idlharness.https_include=HTML.+-expected.txt
          • D third_party/blink/web_tests/external/wpt/html/semantics/forms/the-input-element/color-attributes.window-expected.txt
          • D third_party/blink/web_tests/external/wpt/html/semantics/forms/the-input-element/color.window-expected.txt
          • M third_party/blink/web_tests/external/wpt/html/semantics/forms/the-input-element/color.window.js
          • M third_party/blink/web_tests/fast/css/placeholder-shown-basics-expected.txt
          • M third_party/blink/web_tests/fast/forms/ValidityState-stepMismatch-expected.txt
          • M third_party/blink/web_tests/fast/forms/color/color-value-sanitization-expected.txt
          • M third_party/blink/web_tests/fast/forms/input-valueasnumber-unsupported-expected.txt
          • M third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
          • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
          Change size: L
          Delta: 21 files changed, 193 insertions(+), 465 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by David Baron
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
          Gerrit-Change-Number: 7952977
          Gerrit-PatchSet: 11
          Gerrit-Owner: Jason Leo <cg...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: David Baron <dba...@chromium.org>
          Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
          Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          open
          diffy
          satisfied_requirement

          Blink W3C Test Autoroller (Gerrit)

          unread,
          Jun 24, 2026, 6:13:25 PM (9 hours ago) Jun 24
          to Chromium LUCI CQ, Jason Leo, David Baron, (Julie)Jeongeun Kim, Kevin Babbitt, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

          Message from Blink W3C Test Autoroller

          The exported PR, https://github.com/web-platform-tests/wpt/pull/60837, has failed the following check(s) on GitHub:

          lint (https://github.com/web-platform-tests/wpt/runs/83278786743)

          These failures will block the export. They may represent new or existing problems; please take a look at the output and see if it can be fixed. Unresolved failures will be looked at by the Ecosystem-Infra sheriff after this CL has been landed in Chromium; if you need earlier help please contact blin...@chromium.org.

          Any suggestions to improve this service are welcome; crbug.com/1027618.

          Gerrit CL SHA: Latest

          Open in Gerrit

          Related details

          Attention set is empty
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ib94a600e3b5be2872ab114d30f3681b72e81fef3
          Gerrit-Change-Number: 7952977
          Gerrit-PatchSet: 11
          Gerrit-Owner: Jason Leo <cg...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: David Baron <dba...@chromium.org>
          Gerrit-Reviewer: Jason Leo <cg...@chromium.org>
          Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
          Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
          Gerrit-Comment-Date: Wed, 24 Jun 2026 22:13:13 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy

          Blink W3C Test Autoroller (Gerrit)

          unread,
          Jun 24, 2026, 6:29:34 PM (8 hours ago) Jun 24
          to Chromium LUCI CQ, Jason Leo, David Baron, (Julie)Jeongeun Kim, Kevin Babbitt, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, dtseng...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, josiah...@chromium.org, abigailbk...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

          Message from Blink W3C Test Autoroller

          The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/60837

          Gerrit-Comment-Date: Wed, 24 Jun 2026 22:29:23 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages