Revert "Don't expose pseudo element to web via event.target and .currentTarget" [chromium/src : refs/branch-heads/7258]

0 views

Skip to first unread message

Chromium LUCI CQ (Gerrit)

unread,

Jun 24, 2025, 5:26:17 PMJun 24

to Srinivas Sista, Daniil Sakhapov, Kentaro Hara, Alexis Menard, Raphael Kubo da Costa, Olga Gerchikov, David Bokan, Alex Keng, AyeAye, Rubber Stamper, kouhei...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, speed-metrics...@chromium.org, blink-rev...@chromium.org, steimel+watch...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-revi...@chromium.org, hiroshig...@chromium.org, dtapuska+...@chromium.org, dom+...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Revert "Don't expose pseudo element to web via event.target and .currentTarget"

This reverts commit 45fd03eab27d2cd1cd99f78741649d6ff9a3d078.

Reason for revert: crash at prod

Bug: 420463805
Original change's description:
> Don't expose pseudo element to web via event.target and .currentTarget
>
> The only possible cases now are ::scroll-marker and ::scroll-button().
>
> Also, this CL changes internal call sites of target() to RawTarget(),
> as internally we need to work with pseudo elements.
>
> Bug: 420463805
> Change-Id: Ica69a3de925d04524cad97c8fd75657c71515d1f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633705
> Reviewed-by: Mason Freed <mas...@chromium.org>
> Commit-Queue: Daniil Sakhapov <sakh...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1477142}

(cherry picked from commit 65d9d5de8d6aec5f4d702640583a7f6a4f3f330a)

Bug: 420463805

Change-Id: Ia099b1357a13d517adea5f563bd5f27f3fb86743

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6663864

Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Reviewed-by: Rune Lillesveen <fut...@chromium.org>

Commit-Queue: Daniil Sakhapov <sakh...@chromium.org>

Cr-Original-Commit-Position: refs/heads/main@{#1477918}

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6669273

Owners-Override: Srinivas Sista <sriniv...@chromium.org>

Commit-Queue: Srinivas Sista <sriniv...@chromium.org>

Cr-Commit-Position: refs/branch-heads/7258@{#12}

Cr-Branched-From: f600d0656fd5b5fe4a82981f533d31ed6939e2e4-refs/heads/main@{#1477651}

Files:

M third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc
M third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
M third_party/blink/renderer/core/dom/events/event.cc
M third_party/blink/renderer/core/dom/events/event.h
M third_party/blink/renderer/core/dom/events/event_dispatcher.cc
M third_party/blink/renderer/core/dom/events/event_queue.cc
M third_party/blink/renderer/core/dom/events/scoped_event_queue.cc
M third_party/blink/renderer/core/dom/node.cc
M third_party/blink/renderer/core/dom/scripted_animation_controller.cc
M third_party/blink/renderer/core/dom/scroll_button_pseudo_element.cc
M third_party/blink/renderer/core/dom/scroll_marker_pseudo_element.cc
M third_party/blink/renderer/core/editing/commands/insert_commands.cc
M third_party/blink/renderer/core/editing/editor.cc
M third_party/blink/renderer/core/editing/editor_key_bindings.cc
M third_party/blink/renderer/core/events/mouse_event.cc
M third_party/blink/renderer/core/html/forms/html_form_control_element.cc
M third_party/blink/renderer/core/html/forms/html_form_element.cc
M third_party/blink/renderer/core/html/forms/html_label_element.cc
M third_party/blink/renderer/core/html/forms/range_input_type.cc
M third_party/blink/renderer/core/html/forms/select_type.cc
M third_party/blink/renderer/core/html/html_anchor_element.cc
M third_party/blink/renderer/core/html/html_summary_element.cc
M third_party/blink/renderer/core/html/media/media_document.cc
M third_party/blink/renderer/core/input/event_handler.cc
M third_party/blink/renderer/core/page/context_menu_controller.cc
M third_party/blink/renderer/core/page/focusgroup_controller.cc
M third_party/blink/renderer/core/page/spatial_navigation_controller.cc
M third_party/blink/renderer/core/timing/soft_navigation_heuristics.cc
M third_party/blink/renderer/core/timing/window_performance.cc
M third_party/blink/renderer/modules/media_controls/elements/media_control_playback_speed_list_element.cc
M third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc
M third_party/blink/renderer/modules/media_controls/elements/media_control_text_track_list_element.cc
M third_party/blink/renderer/modules/media_controls/elements/media_control_track_selector_list_element.cc
M third_party/blink/renderer/modules/media_controls/media_controls_shared_helper.cc
D third_party/blink/web_tests/external/wpt/css/css-overflow/scroll-button-event-target.html
D third_party/blink/web_tests/external/wpt/css/css-overflow/scroll-marker-event-target.html

Change size: L

Delta: 36 files changed, 71 insertions(+), 257 deletions(-)

Branch: refs/branch-heads/7258

Submit Requirements:

Code-Review: Bot-Commit+1 by Rubber Stamper

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages