[html-in-canvas] Preserve is2D in getElementTransform [chromium/src : main]

0 views
Skip to first unread message

Philip Rogers (Gerrit)

unread,
May 11, 2026, 11:45:44 PM (13 hours ago) May 11
to Stefan Zager, Stephen Chenney, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager and Stephen Chenney

Philip Rogers voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Stefan Zager
  • Stephen Chenney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If4976082d9e1f557aa6d10ec62a984d308595a1e
Gerrit-Change-Number: 7839518
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Comment-Date: Tue, 12 May 2026 03:45:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
12:27 AM (12 hours ago) 12:27 AM
to Florin Malita, android-bu...@system.gserviceaccount.com, Kevin huerta, Chromium LUCI CQ, Stefan Zager, Stephen Chenney, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager and Stephen Chenney

Philip Rogers added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Philip Rogers . resolved

A Florin review is always welcome, but in this case, I think it was requested by mistake. fmalita -> cc to not waste his time.

Open in Gerrit

Related details

Attention is currently required from:
  • Stefan Zager
  • Stephen Chenney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If4976082d9e1f557aa6d10ec62a984d308595a1e
Gerrit-Change-Number: 7839518
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Comment-Date: Tue, 12 May 2026 04:27:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephen Chenney (Gerrit)

unread,
8:32 AM (4 hours ago) 8:32 AM
to Philip Rogers, Florin Malita, android-bu...@system.gserviceaccount.com, Kevin huerta, Chromium LUCI CQ, Stefan Zager, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Philip Rogers and Stefan Zager

Stephen Chenney voted and added 1 comment

Votes added by Stephen Chenney

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Stephen Chenney . resolved

LGTM. I would prefer a way to default to "take the is2d from the transform passed in" and then a different version with an is2d override parameter, but this is OK.

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
  • Stefan Zager
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If4976082d9e1f557aa6d10ec62a984d308595a1e
    Gerrit-Change-Number: 7839518
    Gerrit-PatchSet: 5
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Florin Malita <fma...@chromium.org>
    Gerrit-CC: Kevin huerta <kevinh...@gmail.com>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Attention: Stefan Zager <sza...@chromium.org>
    Gerrit-Comment-Date: Tue, 12 May 2026 12:32:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    8:52 AM (4 hours ago) 8:52 AM
    to Philip Rogers, Stephen Chenney, Florin Malita, android-bu...@system.gserviceaccount.com, Kevin huerta, Stefan Zager, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [html-in-canvas] Preserve is2D in getElementTransform

    getElementTransform incorrectly initialized the returned DOMMatrix with
    is2D always set to true. This caused 3D matrices to lose their 3D
    components, resulting in incorrect scaling for webgl/webgpu. This patch
    fixes the issue by explicitly passing the Is2dTransform() state to the
    DOMMatrix constructor.

    To prevent this issue from affecting others in the future, the default
    is2D value has been removed from the DOMMatrix/DOMMatrixReadOnly ctors.
    Fixed: 512171941
    Change-Id: If4976082d9e1f557aa6d10ec62a984d308595a1e
    Reviewed-by: Stephen Chenney <sche...@chromium.org>
    Commit-Queue: Stephen Chenney <sche...@chromium.org>
    Auto-Submit: Philip Rogers <p...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1629255}
    Files:
    • M third_party/blink/renderer/core/geometry/dom_matrix.cc
    • M third_party/blink/renderer/core/geometry/dom_matrix.h
    • M third_party/blink/renderer/core/geometry/dom_matrix_read_only.cc
    • M third_party/blink/renderer/core/geometry/dom_matrix_read_only.h
    • M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
    • M third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
    • M third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
    • M third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/drawElementImage-returned-matrix-worker.html
    • M third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/get-element-transform.html
    Change size: M
    Delta: 9 files changed, 54 insertions(+), 12 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Stephen Chenney
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If4976082d9e1f557aa6d10ec62a984d308595a1e
    Gerrit-Change-Number: 7839518
    Gerrit-PatchSet: 6
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages