Only process mouse events in `MaybeReportAnchorElementPointerEvent` [chromium/src : main]

Iman Saboori (Gerrit)

unread,

Mar 22, 2023, 3:57:36 PMMar 22

to Dave Tapuska, Jeremy Roman, blink-rev...@chromium.org, blink-...@chromium.org

Attention is currently required from: Dave Tapuska, Jeremy Roman.

Iman Saboori would like Dave Tapuska and Jeremy Roman to review this change.

Only process mouse events in `MaybeReportAnchorElementPointerEvent`

Touch start event is only passed to the main thread if there is a JS
event listener for it (crbug.com/1425870). Only process the `mouse`
events for now, till that bug is fixed.

Bug: 1423508
Change-Id: I51f4b41232f7746faf77a5623069e35b2d128afa
---
M third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc
M third_party/blink/renderer/core/html/anchor_element_metrics_sender_test.cc
2 files changed, 86 insertions(+), 0 deletions(-)

To view, visit change 4361080. To unsubscribe, or for help writing mail filters, visit settings.

Iman Saboori (Gerrit)

unread,

Mar 22, 2023, 3:57:41 PMMar 22

to blink-rev...@chromium.org, blink-...@chromium.org, Dave Tapuska, Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Dave Tapuska, Jeremy Roman.

View Change

To view, visit change 4361080. To unsubscribe, or for help writing mail filters, visit settings.

Jeremy Roman (Gerrit)

unread,

Mar 22, 2023, 4:11:40 PMMar 22

to Iman Saboori, blink-rev...@chromium.org, blink-...@chromium.org, Dave Tapuska, Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Dave Tapuska, Iman Saboori.

View Change

1 comment:

Patchset:
- Patch Set #2:
  Can you expand on the motivation for this a little? Is it problematic in some way to lose data for such pages, and less problematic to _also_ lose data for pages which do have touch/pointer event listeners?

To view, visit change 4361080. To unsubscribe, or for help writing mail filters, visit settings.

Iman Saboori (Gerrit)

unread,

Mar 22, 2023, 4:52:23 PMMar 22

to blink-rev...@chromium.org, blink-...@chromium.org, Dave Tapuska, Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Dave Tapuska, Jeremy Roman.

View Change

1 comment:

Patchset:
- Patch Set #2:
  Can you expand on the motivation for this a little? Is it problematic in some way to lose data for s […]
  I've updated the comment section.

To view, visit change 4361080. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward