Make clicking on options in customizable combobox choose the option [chromium/src : main]
0 views
Skip to first unread message
David Baron (Gerrit)
Apr 1, 2026, 11:03:30 AM (19 hours ago) Apr 1
to David Baron, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
David Baron voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Baron
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/core/html/forms/text_field_input_type.cc
Line 406, Patchset 3:
HidePopoverTransitionBehavior::kNoEventsNoWaiting,David Baron . resolved
Joey ArharAny particular reason this one is `kNoEventsNoWaiting` but the other isn't? (I realize this is an existing thing...)
David BaronOther places that hide popovers and need to make sure that they can't be canceled do this I think, but now that I think about it I don't see any reason why we would have to prevent this from being kept open, so I'll change it to fire events.
Acknowledged
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Apr 1, 2026, 12:54:20 PM (18 hours ago) Apr 1
to David Baron, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Joey Arhar voted![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 1, 2026, 12:59:33 PM (17 hours ago) Apr 1
to David Baron, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Make clicking on options in customizable combobox choose the option
Without this patch, clicking on combobox options doesn't copy their text
into the text input.
Bug: 453705243
Change-Id: I62f30f02c83efa98f3c9fe9a8134350496cf5a8b
Reviewed-by: David Baron <dba...@chromium.org>
Commit-Queue: Joey Arhar <jar...@chromium.org>
Reviewed-by: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1608611}
Files:
- M third_party/blink/renderer/core/html/forms/html_data_list_element.cc
- M third_party/blink/renderer/core/html/forms/html_data_list_element.h
- M third_party/blink/renderer/core/html/forms/html_option_element.cc
- M third_party/blink/renderer/core/html/forms/html_option_element.h
- M third_party/blink/renderer/core/html/forms/text_field_input_type.cc
- M third_party/blink/web_tests/external/wpt/html/semantics/forms/customizable-combobox/active-option-pseudo.tentative.html
- A third_party/blink/web_tests/external/wpt/html/semantics/forms/customizable-combobox/customizable-combobox-pointer-behavior.tentative.html
Change size: M
Delta: 7 files changed, 136 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joey Arhar, +1 by David Baron
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 1, 2026, 2:36:58 PM (16 hours ago) Apr 1
to Chromium LUCI CQ, David Baron, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/58914
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages