[Contextual Tasks] Hide the lens button when in full tab [chromium/src : main]
0 views
Skip to first unread message
Josiah Kiehl (Gerrit)
Dec 22, 2025, 8:20:35 PM (9 hours ago) Dec 22
to James Maclean, David Bokan, Kevin Babbitt, Chromium Metrics Reviews, Wang, Wei4, Christian Biesinger, Victor Tan, Simon Hangl, Ian Vollick, Peter Williamson, Ryan Sultanem, Jiewei Qian, Olga Gerchikov, Nate Chapin, Stephen Chenney, Menard, Alexis, Urvang Joshi, Avi Drissman, srirama chandra sekhar, Mirko Bonadei, Yoav Weiss (@Shopify), Javier Fernandez, Hans Wennborg, Rijubrata Bhaumik, Nikhil Nayunigari, Hu, Ningxin, Hiroki Nakagawa, Mike Taylor, Daniel Cheng, Kaan Icer, Peter Beverloo, Dirk Schulze, Andrew Rayskiy, Sadrul Chowdhury, Zijie He, Kenneth R Christiansen, Dirk Pranke, Raphael Kubo da Costa, Arnaud Mandy, Kentaro Hara, James Su, Enterprise Policy Reviews, Hongchan Choi, Jerome Jiang, (Julie)Jeongeun Kim, AyeAye, Juan Mojica, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, feature-me...@chromium.org, mpdento...@chromium.org, jdeblas...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, iwells...@chromium.org, extension...@chromium.org, sky+...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, gavin...@chromium.org, srahim...@chromium.org, erickun...@chromium.org, fdoray...@chromium.org, cros-setti...@google.com, xinghui...@chromium.org, jackshira+w...@google.com, rginda...@chromium.org, fenced-fra...@chromium.org, halliwe...@chromium.org, jiajunz+wat...@google.com, prerenderi...@chromium.org, nyquis...@chromium.org, derinel+wat...@google.com, ios-web-view...@google.com, martijn...@martijnc.be, ios-revie...@chromium.org, alexmo...@chromium.org, hanxi...@chromium.org, ashleynewson+w...@chromium.org, francisjp...@google.com, blink-rev...@chromium.org, webapks-...@chromium.org, liu+wa...@chromium.org, jbauma...@chromium.org, kuragin+web-ap...@chromium.org, tluk+...@chromium.org, penghu...@chromium.org, filesapp...@chromium.org, dmurph+watch...@chromium.org, vakh+safe_br...@chromium.org, print-rev...@chromium.org, tgupta...@chromium.org, blink-re...@chromium.org, dcheng+c...@chromium.org, crmulli...@chromium.org, cbe-cep-eng...@google.com, jorgel...@chromium.org, chromium-a...@chromium.org, yhanad...@chromium.org, shgar+aut...@google.com, ios-rev...@chromium.org, eme-r...@chromium.org, asumane...@google.com, ortuno+w...@chromium.org, cros-report...@google.com, yuezhang...@chromium.org, ajwong...@chromium.org, dtapuska+ch...@chromium.org, rrsilva+wat...@google.com, jmedle...@chromium.org, donnd...@chromium.org, lwinston+watc...@google.com, kmg+...@google.com, ejcaruso+wa...@chromium.org, speed-metr...@chromium.org, njeunje+...@chromium.org, kenok...@google.com, croissant-...@chromium.org, loyso...@chromium.org, jeffreycohen+watc...@chromium.org, creis...@chromium.org, headless...@chromium.org, cwalle...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, chrome-waff...@google.com, siyua+aut...@chromium.org, spang...@chromium.org, siashah+au...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, marimatthew+watc...@google.com, armalhotra+a...@google.com, chrome-intelligence-te...@google.com, jshin...@chromium.org, core-timi...@chromium.org, jatapiaro+wat...@google.com, subresource-f...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, feature-v...@chromium.org, shimazu...@chromium.org, davidj...@chromium.org, cros-enterpris...@chromium.org, chromeos-kio...@google.com, blink-reviews-p...@chromium.org, devtools...@chromium.org, niharm...@google.com, grt+...@chromium.org, apavlo...@chromium.org, jophba...@chromium.org, edgesto...@microsoft.com, tranbaod...@chromium.org, druber...@chromium.org, zol...@webkit.org, hirokisa...@chromium.org, chrome-intell...@chromium.org, toyosh...@chromium.org, gavinp...@chromium.org, kainin...@chromium.org, ayman...@chromium.org, yhiran...@chromium.org, dfried...@chromium.org, jackshira+wa...@google.com, chlily...@chromium.org, dewitt...@chromium.org, lens-chrome...@google.com, jdh+wa...@chromium.org, eic+...@google.com, penghuan...@chromium.org, bmcquad...@chromium.org, mercer...@google.com, giovax...@chromium.org, dmurph+wat...@chromium.org, lizeb...@chromium.org, mar...@chromium.org, chrome-tab-group-en...@google.com, rmcelra...@chromium.org, lighthouse-eng-extern...@google.com, permissio...@chromium.org, peilinwa...@google.com, jessemcke...@google.com, borealis-re...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, moqati-team+chr...@google.com, katie...@chromium.org, dtapuska+...@chromium.org, khorimoto+wa...@chromium.org, drott+bl...@chromium.org, petewi...@chromium.org, kouhei...@chromium.org, dmurph+wa...@chromium.org, jz...@chromium.org, asvitkine...@chromium.org, apaselti...@chromium.org, nwoked...@chromium.org, npm+...@chromium.org, stanfie...@google.com, enne...@chromium.org, thefro...@chromium.org, keithle...@chromium.org, roagarw...@chromium.org, blink-revi...@chromium.org, anastas...@google.com, crostin...@chromium.org, fuzzin...@chromium.org, tracing...@chromium.org, cblume...@chromium.org, jdonnel...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, sloboda...@chromium.org, blink-rev...@chromium.org, pkotwic...@chromium.org, chromotin...@chromium.org, dtraino...@chromium.org, harringt...@chromium.org, jonmann+wa...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, blink-revi...@chromium.org, ffred...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, twifka...@chromium.org, zackha...@chromium.org, cfredri...@chromium.org, jasonrobe...@google.com, scheduler...@chromium.org, ramyagopa...@google.com, csharris...@chromium.org, chromiumme...@microsoft.com, ydago...@chromium.org, tbarzi...@chromium.org, scheduler-...@chromium.org, horo+...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, olka+...@chromium.org, dominicc+...@chromium.org, ricea...@chromium.org, fmalit...@chromium.org, hsuregan+wat...@chromium.org, kinuko+ser...@chromium.org, yusufo...@chromium.org, ozone-...@chromium.org, michaelchec...@google.com, dmurph+watc...@chromium.org, rkgibso...@chromium.org, gogeral...@chromium.org, shannc...@chromium.org, chadduffin+w...@chromium.org, chadduffin+wa...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, yuzo+...@chromium.org, shimazu+se...@chromium.org, twelling...@chromium.org, chfreme...@chromium.org, aleventh...@chromium.org, omnibox-...@chromium.org, blink-...@chromium.org, amaliev+...@chromium.org, cros-print...@google.com, marinacio...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, torne...@chromium.org, meilian...@chromium.org, osaul+aut...@google.com, droger+w...@chromium.org, boujan...@google.com, johnche...@chromium.org, svend+w...@chromium.org, net-r...@chromium.org, estali...@chromium.org, thegreenf...@chromium.org, webauthn...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, ntp-dev...@chromium.org, rsesek...@chromium.org, abigailbk...@google.com, bcb+watch-pl...@chromium.org, dibyapal+wa...@chromium.org, gangwu...@chromium.org, pasko...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, ananyasee...@google.com, phoglun...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, knollr+wat...@chromium.org, yigu+...@chromium.org, jkeitel+watch-...@google.com, kenjibah...@chromium.org, dullweb...@chromium.org, chrome-gr...@chromium.org, blink-re...@chromium.org, dmurph+watching...@chromium.org, tmartino+tran...@chromium.org, mfoltz+wa...@chromium.org, hansberry+wa...@chromium.org, chromeos-ca...@google.com, max+watc...@igalia.com, shuche...@chromium.org, nicolas...@chromium.org, estaab...@chromium.org, web-schedulin...@chromium.org, bnc+...@chromium.org, mickeybu...@chromium.org, christia...@chromium.org, cambickel...@google.com, roblia...@chromium.org, gavin...@chromium.org, mattreyno...@chromium.org, stevenjb+wa...@chromium.org, nona+...@chromium.org, gab+...@chromium.org, webap...@microsoft.com, yongshun+...@google.com, dmurph+watchi...@chromium.org, mreichhoff+watc...@chromium.org, bartek...@chromium.org, vasilii+watchlis...@chromium.org, yfriedm...@chromium.org, browser-comp...@chromium.org, ender...@chromium.org, hiroshig...@chromium.org, mdjone...@chromium.org, nickdiego+wa...@igalia.com, pdf-r...@chromium.org, fgal...@chromium.org, asvitki...@chromium.org, lucasrada...@google.com, tburkar...@chromium.org, peter+watch...@chromium.org, chrstn...@google.com, media-cro...@chromium.org, blink-revie...@chromium.org, devtools-re...@chromium.org, gavinp+p...@chromium.org, dom+...@chromium.org, khorimoto+w...@chromium.org, minap+watch-p...@google.com, nator...@chromium.org, hayato...@chromium.org, fuchsia...@chromium.org, trewin...@google.com, yhanada+...@chromium.org, blink-re...@chromium.org, rayanka...@chromium.org, translat...@chromium.org, hsuregan+wa...@chromium.org, media-wi...@chromium.org, nikhilcn+wat...@google.com, jiajunz+wa...@google.com, mgiuca...@chromium.org, philli...@chromium.org, josiah...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, agriev...@chromium.org, vinnypersky+...@google.com, speed-metrics...@chromium.org, yhanada+...@chromium.org, storage...@chromium.org, marq+...@chromium.org, hashimo...@chromium.org, blink-revi...@chromium.org, zelin+watch-we...@chromium.org, language...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, oshima...@chromium.org
Attention needed from Juan Mojica
Josiah Kiehl added 1 comment![]( "Open in Gerrit")
File ui/webui/resources/cr_components/composebox/composebox.ts
Line 91, Patchset 10:
lensButtonTriggersOverlay: {type: Boolean},Juan Mojica . unresolved
Josiah KiehlI don't think we ever expect this button not to trigger the overlay.
I thought it triggers a file upload in NTP and Omnibox?
Related details
Attention is currently required from:
- Juan Mojica
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Josiah Kiehl (Gerrit)
Dec 22, 2025, 8:20:51 PM (9 hours ago) Dec 22
to James Maclean, David Bokan, Kevin Babbitt, Chromium Metrics Reviews, Wang, Wei4, Christian Biesinger, Victor Tan, Simon Hangl, Ian Vollick, Peter Williamson, Ryan Sultanem, Jiewei Qian, Olga Gerchikov, Nate Chapin, Stephen Chenney, Menard, Alexis, Urvang Joshi, Avi Drissman, srirama chandra sekhar, Mirko Bonadei, Yoav Weiss (@Shopify), Javier Fernandez, Hans Wennborg, Rijubrata Bhaumik, Nikhil Nayunigari, Hu, Ningxin, Hiroki Nakagawa, Mike Taylor, Daniel Cheng, Kaan Icer, Peter Beverloo, Dirk Schulze, Andrew Rayskiy, Sadrul Chowdhury, Zijie He, Kenneth R Christiansen, Dirk Pranke, Raphael Kubo da Costa, Arnaud Mandy, Kentaro Hara, James Su, Enterprise Policy Reviews, Hongchan Choi, Jerome Jiang, (Julie)Jeongeun Kim, AyeAye, Juan Mojica, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, feature-me...@chromium.org, mpdento...@chromium.org, jdeblas...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, iwells...@chromium.org, extension...@chromium.org, sky+...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, gavin...@chromium.org, srahim...@chromium.org, erickun...@chromium.org, fdoray...@chromium.org, cros-setti...@google.com, xinghui...@chromium.org, jackshira+w...@google.com, rginda...@chromium.org, fenced-fra...@chromium.org, halliwe...@chromium.org, jiajunz+wat...@google.com, prerenderi...@chromium.org, nyquis...@chromium.org, derinel+wat...@google.com, ios-web-view...@google.com, martijn...@martijnc.be, ios-revie...@chromium.org, alexmo...@chromium.org, hanxi...@chromium.org, ashleynewson+w...@chromium.org, francisjp...@google.com, blink-rev...@chromium.org, webapks-...@chromium.org, liu+wa...@chromium.org, jbauma...@chromium.org, kuragin+web-ap...@chromium.org, tluk+...@chromium.org, penghu...@chromium.org, filesapp...@chromium.org, dmurph+watch...@chromium.org, vakh+safe_br...@chromium.org, print-rev...@chromium.org, tgupta...@chromium.org, blink-re...@chromium.org, dcheng+c...@chromium.org, crmulli...@chromium.org, cbe-cep-eng...@google.com, jorgel...@chromium.org, chromium-a...@chromium.org, yhanad...@chromium.org, shgar+aut...@google.com, ios-rev...@chromium.org, eme-r...@chromium.org, asumane...@google.com, ortuno+w...@chromium.org, cros-report...@google.com, yuezhang...@chromium.org, ajwong...@chromium.org, dtapuska+ch...@chromium.org, rrsilva+wat...@google.com, jmedle...@chromium.org, donnd...@chromium.org, lwinston+watc...@google.com, kmg+...@google.com, ejcaruso+wa...@chromium.org, speed-metr...@chromium.org, njeunje+...@chromium.org, kenok...@google.com, croissant-...@chromium.org, loyso...@chromium.org, jeffreycohen+watc...@chromium.org, creis...@chromium.org, headless...@chromium.org, cwalle...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, chrome-waff...@google.com, siyua+aut...@chromium.org, spang...@chromium.org, siashah+au...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, marimatthew+watc...@google.com, armalhotra+a...@google.com, chrome-intelligence-te...@google.com, jshin...@chromium.org, core-timi...@chromium.org, jatapiaro+wat...@google.com, subresource-f...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, feature-v...@chromium.org, shimazu...@chromium.org, davidj...@chromium.org, cros-enterpris...@chromium.org, chromeos-kio...@google.com, blink-reviews-p...@chromium.org, devtools...@chromium.org, niharm...@google.com, grt+...@chromium.org, apavlo...@chromium.org, jophba...@chromium.org, edgesto...@microsoft.com, tranbaod...@chromium.org, druber...@chromium.org, zol...@webkit.org, hirokisa...@chromium.org, chrome-intell...@chromium.org, toyosh...@chromium.org, gavinp...@chromium.org, kainin...@chromium.org, ayman...@chromium.org, yhiran...@chromium.org, dfried...@chromium.org, jackshira+wa...@google.com, chlily...@chromium.org, dewitt...@chromium.org, lens-chrome...@google.com, jdh+wa...@chromium.org, eic+...@google.com, penghuan...@chromium.org, bmcquad...@chromium.org, mercer...@google.com, giovax...@chromium.org, dmurph+wat...@chromium.org, lizeb...@chromium.org, mar...@chromium.org, chrome-tab-group-en...@google.com, rmcelra...@chromium.org, lighthouse-eng-extern...@google.com, permissio...@chromium.org, peilinwa...@google.com, jessemcke...@google.com, borealis-re...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, moqati-team+chr...@google.com, katie...@chromium.org, dtapuska+...@chromium.org, khorimoto+wa...@chromium.org, drott+bl...@chromium.org, petewi...@chromium.org, kouhei...@chromium.org, dmurph+wa...@chromium.org, jz...@chromium.org, asvitkine...@chromium.org, apaselti...@chromium.org, nwoked...@chromium.org, npm+...@chromium.org, stanfie...@google.com, enne...@chromium.org, thefro...@chromium.org, keithle...@chromium.org, roagarw...@chromium.org, blink-revi...@chromium.org, anastas...@google.com, crostin...@chromium.org, fuzzin...@chromium.org, tracing...@chromium.org, cblume...@chromium.org, jdonnel...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, sloboda...@chromium.org, blink-rev...@chromium.org, pkotwic...@chromium.org, chromotin...@chromium.org, dtraino...@chromium.org, harringt...@chromium.org, jonmann+wa...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, blink-revi...@chromium.org, ffred...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, twifka...@chromium.org, zackha...@chromium.org, cfredri...@chromium.org, jasonrobe...@google.com, scheduler...@chromium.org, ramyagopa...@google.com, csharris...@chromium.org, chromiumme...@microsoft.com, ydago...@chromium.org, tbarzi...@chromium.org, scheduler-...@chromium.org, horo+...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, olka+...@chromium.org, dominicc+...@chromium.org, ricea...@chromium.org, fmalit...@chromium.org, hsuregan+wat...@chromium.org, kinuko+ser...@chromium.org, yusufo...@chromium.org, ozone-...@chromium.org, michaelchec...@google.com, dmurph+watc...@chromium.org, rkgibso...@chromium.org, gogeral...@chromium.org, shannc...@chromium.org, chadduffin+w...@chromium.org, chadduffin+wa...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, yuzo+...@chromium.org, shimazu+se...@chromium.org, twelling...@chromium.org, chfreme...@chromium.org, aleventh...@chromium.org, omnibox-...@chromium.org, blink-...@chromium.org, amaliev+...@chromium.org, cros-print...@google.com, marinacio...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, torne...@chromium.org, meilian...@chromium.org, osaul+aut...@google.com, droger+w...@chromium.org, boujan...@google.com, johnche...@chromium.org, svend+w...@chromium.org, net-r...@chromium.org, estali...@chromium.org, thegreenf...@chromium.org, webauthn...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, ntp-dev...@chromium.org, rsesek...@chromium.org, abigailbk...@google.com, bcb+watch-pl...@chromium.org, dibyapal+wa...@chromium.org, gangwu...@chromium.org, pasko...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, ananyasee...@google.com, phoglun...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, knollr+wat...@chromium.org, yigu+...@chromium.org, jkeitel+watch-...@google.com, kenjibah...@chromium.org, dullweb...@chromium.org, chrome-gr...@chromium.org, blink-re...@chromium.org, dmurph+watching...@chromium.org, tmartino+tran...@chromium.org, mfoltz+wa...@chromium.org, hansberry+wa...@chromium.org, chromeos-ca...@google.com, max+watc...@igalia.com, shuche...@chromium.org, nicolas...@chromium.org, estaab...@chromium.org, web-schedulin...@chromium.org, bnc+...@chromium.org, mickeybu...@chromium.org, christia...@chromium.org, cambickel...@google.com, roblia...@chromium.org, gavin...@chromium.org, mattreyno...@chromium.org, stevenjb+wa...@chromium.org, nona+...@chromium.org, gab+...@chromium.org, webap...@microsoft.com, yongshun+...@google.com, dmurph+watchi...@chromium.org, mreichhoff+watc...@chromium.org, bartek...@chromium.org, vasilii+watchlis...@chromium.org, yfriedm...@chromium.org, browser-comp...@chromium.org, ender...@chromium.org, hiroshig...@chromium.org, mdjone...@chromium.org, nickdiego+wa...@igalia.com, pdf-r...@chromium.org, fgal...@chromium.org, asvitki...@chromium.org, lucasrada...@google.com, tburkar...@chromium.org, peter+watch...@chromium.org, chrstn...@google.com, media-cro...@chromium.org, blink-revie...@chromium.org, devtools-re...@chromium.org, gavinp+p...@chromium.org, dom+...@chromium.org, khorimoto+w...@chromium.org, minap+watch-p...@google.com, nator...@chromium.org, hayato...@chromium.org, fuchsia...@chromium.org, trewin...@google.com, yhanada+...@chromium.org, blink-re...@chromium.org, rayanka...@chromium.org, translat...@chromium.org, hsuregan+wa...@chromium.org, media-wi...@chromium.org, nikhilcn+wat...@google.com, jiajunz+wa...@google.com, mgiuca...@chromium.org, philli...@chromium.org, josiah...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, agriev...@chromium.org, vinnypersky+...@google.com, speed-metrics...@chromium.org, yhanada+...@chromium.org, storage...@chromium.org, marq+...@chromium.org, hashimo...@chromium.org, blink-revi...@chromium.org, zelin+watch-we...@chromium.org, language...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, oshima...@chromium.org
Attention needed from Juan Mojica
Josiah Kiehl added 1 comment![]( "Open in Gerrit")
File ui/webui/resources/cr_components/composebox/composebox.ts
Line 91, Patchset 10:
lensButtonTriggersOverlay: {type: Boolean},Juan Mojica . unresolved
Josiah KiehlI don't think we ever expect this button not to trigger the overlay.
I thought it triggers a file upload in NTP and Omnibox?
Josiah Kiehl
Or perhaps just NTP?
Juan Mojica (Gerrit)
Dec 22, 2025, 8:30:36 PM (9 hours ago) Dec 22
to Josiah Kiehl, James Maclean, David Bokan, Kevin Babbitt, Chromium Metrics Reviews, Wang, Wei4, Christian Biesinger, Victor Tan, Simon Hangl, Ian Vollick, Peter Williamson, Ryan Sultanem, Jiewei Qian, Olga Gerchikov, Nate Chapin, Stephen Chenney, Menard, Alexis, Urvang Joshi, Avi Drissman, srirama chandra sekhar, Mirko Bonadei, Yoav Weiss (@Shopify), Javier Fernandez, Hans Wennborg, Rijubrata Bhaumik, Nikhil Nayunigari, Hu, Ningxin, Hiroki Nakagawa, Mike Taylor, Daniel Cheng, Kaan Icer, Peter Beverloo, Dirk Schulze, Andrew Rayskiy, Sadrul Chowdhury, Zijie He, Kenneth R Christiansen, Dirk Pranke, Raphael Kubo da Costa, Arnaud Mandy, Kentaro Hara, James Su, Enterprise Policy Reviews, Hongchan Choi, Jerome Jiang, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, feature-me...@chromium.org, mpdento...@chromium.org, jdeblas...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, iwells...@chromium.org, extension...@chromium.org, sky+...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, gavin...@chromium.org, srahim...@chromium.org, erickun...@chromium.org, fdoray...@chromium.org, cros-setti...@google.com, xinghui...@chromium.org, jackshira+w...@google.com, rginda...@chromium.org, fenced-fra...@chromium.org, halliwe...@chromium.org, jiajunz+wat...@google.com, prerenderi...@chromium.org, nyquis...@chromium.org, derinel+wat...@google.com, ios-web-view...@google.com, martijn...@martijnc.be, ios-revie...@chromium.org, alexmo...@chromium.org, hanxi...@chromium.org, ashleynewson+w...@chromium.org, francisjp...@google.com, blink-rev...@chromium.org, webapks-...@chromium.org, liu+wa...@chromium.org, jbauma...@chromium.org, kuragin+web-ap...@chromium.org, tluk+...@chromium.org, penghu...@chromium.org, filesapp...@chromium.org, dmurph+watch...@chromium.org, vakh+safe_br...@chromium.org, print-rev...@chromium.org, tgupta...@chromium.org, blink-re...@chromium.org, dcheng+c...@chromium.org, crmulli...@chromium.org, cbe-cep-eng...@google.com, jorgel...@chromium.org, chromium-a...@chromium.org, yhanad...@chromium.org, shgar+aut...@google.com, ios-rev...@chromium.org, eme-r...@chromium.org, asumane...@google.com, ortuno+w...@chromium.org, cros-report...@google.com, yuezhang...@chromium.org, ajwong...@chromium.org, dtapuska+ch...@chromium.org, rrsilva+wat...@google.com, jmedle...@chromium.org, donnd...@chromium.org, lwinston+watc...@google.com, kmg+...@google.com, ejcaruso+wa...@chromium.org, speed-metr...@chromium.org, njeunje+...@chromium.org, kenok...@google.com, croissant-...@chromium.org, loyso...@chromium.org, jeffreycohen+watc...@chromium.org, creis...@chromium.org, headless...@chromium.org, cwalle...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, chrome-waff...@google.com, siyua+aut...@chromium.org, spang...@chromium.org, siashah+au...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, marimatthew+watc...@google.com, armalhotra+a...@google.com, chrome-intelligence-te...@google.com, jshin...@chromium.org, core-timi...@chromium.org, jatapiaro+wat...@google.com, subresource-f...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, feature-v...@chromium.org, shimazu...@chromium.org, davidj...@chromium.org, cros-enterpris...@chromium.org, chromeos-kio...@google.com, blink-reviews-p...@chromium.org, devtools...@chromium.org, niharm...@google.com, grt+...@chromium.org, apavlo...@chromium.org, jophba...@chromium.org, edgesto...@microsoft.com, tranbaod...@chromium.org, druber...@chromium.org, zol...@webkit.org, hirokisa...@chromium.org, chrome-intell...@chromium.org, toyosh...@chromium.org, gavinp...@chromium.org, kainin...@chromium.org, ayman...@chromium.org, yhiran...@chromium.org, dfried...@chromium.org, jackshira+wa...@google.com, chlily...@chromium.org, dewitt...@chromium.org, lens-chrome...@google.com, jdh+wa...@chromium.org, eic+...@google.com, penghuan...@chromium.org, bmcquad...@chromium.org, mercer...@google.com, giovax...@chromium.org, dmurph+wat...@chromium.org, lizeb...@chromium.org, mar...@chromium.org, chrome-tab-group-en...@google.com, rmcelra...@chromium.org, lighthouse-eng-extern...@google.com, permissio...@chromium.org, peilinwa...@google.com, jessemcke...@google.com, borealis-re...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, moqati-team+chr...@google.com, katie...@chromium.org, dtapuska+...@chromium.org, khorimoto+wa...@chromium.org, drott+bl...@chromium.org, petewi...@chromium.org, kouhei...@chromium.org, dmurph+wa...@chromium.org, jz...@chromium.org, asvitkine...@chromium.org, apaselti...@chromium.org, nwoked...@chromium.org, npm+...@chromium.org, stanfie...@google.com, enne...@chromium.org, thefro...@chromium.org, keithle...@chromium.org, roagarw...@chromium.org, blink-revi...@chromium.org, anastas...@google.com, crostin...@chromium.org, fuzzin...@chromium.org, tracing...@chromium.org, cblume...@chromium.org, jdonnel...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, sloboda...@chromium.org, blink-rev...@chromium.org, pkotwic...@chromium.org, chromotin...@chromium.org, dtraino...@chromium.org, harringt...@chromium.org, jonmann+wa...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, blink-revi...@chromium.org, ffred...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, twifka...@chromium.org, zackha...@chromium.org, cfredri...@chromium.org, jasonrobe...@google.com, scheduler...@chromium.org, ramyagopa...@google.com, csharris...@chromium.org, chromiumme...@microsoft.com, ydago...@chromium.org, tbarzi...@chromium.org, scheduler-...@chromium.org, horo+...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, olka+...@chromium.org, dominicc+...@chromium.org, ricea...@chromium.org, fmalit...@chromium.org, hsuregan+wat...@chromium.org, kinuko+ser...@chromium.org, yusufo...@chromium.org, ozone-...@chromium.org, michaelchec...@google.com, dmurph+watc...@chromium.org, rkgibso...@chromium.org, gogeral...@chromium.org, shannc...@chromium.org, chadduffin+w...@chromium.org, chadduffin+wa...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, yuzo+...@chromium.org, shimazu+se...@chromium.org, twelling...@chromium.org, chfreme...@chromium.org, aleventh...@chromium.org, omnibox-...@chromium.org, blink-...@chromium.org, amaliev+...@chromium.org, cros-print...@google.com, marinacio...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, torne...@chromium.org, meilian...@chromium.org, osaul+aut...@google.com, droger+w...@chromium.org, boujan...@google.com, johnche...@chromium.org, svend+w...@chromium.org, net-r...@chromium.org, estali...@chromium.org, thegreenf...@chromium.org, webauthn...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, ntp-dev...@chromium.org, rsesek...@chromium.org, abigailbk...@google.com, bcb+watch-pl...@chromium.org, dibyapal+wa...@chromium.org, gangwu...@chromium.org, pasko...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, ananyasee...@google.com, phoglun...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, knollr+wat...@chromium.org, yigu+...@chromium.org, jkeitel+watch-...@google.com, kenjibah...@chromium.org, dullweb...@chromium.org, chrome-gr...@chromium.org, blink-re...@chromium.org, dmurph+watching...@chromium.org, tmartino+tran...@chromium.org, mfoltz+wa...@chromium.org, hansberry+wa...@chromium.org, chromeos-ca...@google.com, max+watc...@igalia.com, shuche...@chromium.org, nicolas...@chromium.org, estaab...@chromium.org, web-schedulin...@chromium.org, bnc+...@chromium.org, mickeybu...@chromium.org, christia...@chromium.org, cambickel...@google.com, roblia...@chromium.org, gavin...@chromium.org, mattreyno...@chromium.org, stevenjb+wa...@chromium.org, nona+...@chromium.org, gab+...@chromium.org, webap...@microsoft.com, yongshun+...@google.com, dmurph+watchi...@chromium.org, mreichhoff+watc...@chromium.org, bartek...@chromium.org, vasilii+watchlis...@chromium.org, yfriedm...@chromium.org, browser-comp...@chromium.org, ender...@chromium.org, hiroshig...@chromium.org, mdjone...@chromium.org, nickdiego+wa...@igalia.com, pdf-r...@chromium.org, fgal...@chromium.org, asvitki...@chromium.org, lucasrada...@google.com, tburkar...@chromium.org, peter+watch...@chromium.org, chrstn...@google.com, media-cro...@chromium.org, blink-revie...@chromium.org, devtools-re...@chromium.org, gavinp+p...@chromium.org, dom+...@chromium.org, khorimoto+w...@chromium.org, minap+watch-p...@google.com, nator...@chromium.org, hayato...@chromium.org, fuchsia...@chromium.org, trewin...@google.com, yhanada+...@chromium.org, blink-re...@chromium.org, rayanka...@chromium.org, translat...@chromium.org, hsuregan+wa...@chromium.org, media-wi...@chromium.org, nikhilcn+wat...@google.com, jiajunz+wa...@google.com, mgiuca...@chromium.org, philli...@chromium.org, josiah...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, agriev...@chromium.org, vinnypersky+...@google.com, speed-metrics...@chromium.org, yhanada+...@chromium.org, storage...@chromium.org, marq+...@chromium.org, hashimo...@chromium.org, blink-revi...@chromium.org, zelin+watch-we...@chromium.org, language...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, oshima...@chromium.org
Attention needed from Josiah Kiehl
Juan Mojica voted and added 1 comment![]( "Open in Gerrit")
Votes added by Juan Mojica
| Code-Review | +1 |
1 comment
File ui/webui/resources/cr_components/composebox/composebox.ts
Line 91, Patchset 10:
lensButtonTriggersOverlay: {type: Boolean},Juan Mojica . resolved
Josiah KiehlI don't think we ever expect this button not to trigger the overlay.
Josiah KiehlI thought it triggers a file upload in NTP and Omnibox?
Or perhaps just NTP?
Juan Mojica
Oh you may be right. Sorry I am not familiar with those flows.
Related details
Attention is currently required from:
- Josiah Kiehl
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
Reply all
Reply to author
Forward
0 new messages