Delete ElementInternals.type-related code [chromium/src : main]

0 views
Skip to first unread message

Ana Sollano Kim (Gerrit)

unread,
Mar 5, 2026, 12:42:37 PM (yesterday) Mar 5
to Dan Clark, Mason Freed, Leo Lee, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Clark, Leo Lee and Mason Freed

Ana Sollano Kim voted and added 1 comment

Votes added by Ana Sollano Kim

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Ana Sollano Kim . resolved

PTAL 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Dan Clark
  • Leo Lee
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie30f9f24b99650728b3160fed46b4f995b131b25
Gerrit-Change-Number: 7632546
Gerrit-PatchSet: 4
Gerrit-Owner: Ana Sollano Kim <anso...@microsoft.com>
Gerrit-Reviewer: Ana Sollano Kim <anso...@microsoft.com>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Leo Lee <leo...@microsoft.com>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Dan Clark <dan...@microsoft.com>
Gerrit-Attention: Leo Lee <leo...@microsoft.com>
Gerrit-Comment-Date: Thu, 05 Mar 2026 17:42:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dan Clark (Gerrit)

unread,
3:10 PM (8 hours ago) 3:10 PM
to Ana Sollano Kim, Mason Freed, Leo Lee, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Ana Sollano Kim, Leo Lee and Mason Freed

Dan Clark voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ana Sollano Kim
  • Leo Lee
  • Mason Freed
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie30f9f24b99650728b3160fed46b4f995b131b25
    Gerrit-Change-Number: 7632546
    Gerrit-PatchSet: 4
    Gerrit-Owner: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Reviewer: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Leo Lee <leo...@microsoft.com>
    Gerrit-Attention: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Leo Lee <leo...@microsoft.com>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 20:09:56 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mason Freed (Gerrit)

    unread,
    3:26 PM (8 hours ago) 3:26 PM
    to Ana Sollano Kim, Dan Clark, Leo Lee, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Ana Sollano Kim and Leo Lee

    Mason Freed voted and added 1 comment

    Votes added by Mason Freed

    Code-Review+1

    1 comment

    Patchset-level comments
    Mason Freed . resolved

    Nice cleanup! Sorry for all the work implementing this only to rip it out. 😞

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ana Sollano Kim
    • Leo Lee
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie30f9f24b99650728b3160fed46b4f995b131b25
    Gerrit-Change-Number: 7632546
    Gerrit-PatchSet: 4
    Gerrit-Owner: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Reviewer: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Leo Lee <leo...@microsoft.com>
    Gerrit-Attention: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Attention: Leo Lee <leo...@microsoft.com>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 20:26:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Blink W3C Test Autoroller (Gerrit)

    unread,
    3:39 PM (8 hours ago) 3:39 PM
    to Ana Sollano Kim, Mason Freed, Dan Clark, Leo Lee, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Ana Sollano Kim and Leo Lee

    Message from Blink W3C Test Autoroller

    Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/58338.

    When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

    WPT Export docs:
    https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ana Sollano Kim
    • Leo Lee
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie30f9f24b99650728b3160fed46b4f995b131b25
    Gerrit-Change-Number: 7632546
    Gerrit-PatchSet: 4
    Gerrit-Owner: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Reviewer: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Leo Lee <leo...@microsoft.com>
    Gerrit-Attention: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Attention: Leo Lee <leo...@microsoft.com>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 20:39:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Ana Sollano Kim (Gerrit)

    unread,
    5:58 PM (5 hours ago) 5:58 PM
    to Blink W3C Test Autoroller, Mason Freed, Dan Clark, Leo Lee, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Leo Lee

    Ana Sollano Kim voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Leo Lee
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie30f9f24b99650728b3160fed46b4f995b131b25
    Gerrit-Change-Number: 7632546
    Gerrit-PatchSet: 4
    Gerrit-Owner: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Reviewer: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Leo Lee <leo...@microsoft.com>
    Gerrit-Attention: Leo Lee <leo...@microsoft.com>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 22:58:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Ana Sollano Kim (Gerrit)

    unread,
    5:59 PM (5 hours ago) 5:59 PM
    to Blink W3C Test Autoroller, Mason Freed, Dan Clark, Leo Lee, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Leo Lee

    Ana Sollano Kim added 1 comment

    Patchset-level comments
    Mason Freed . resolved

    Nice cleanup! Sorry for all the work implementing this only to rip it out. 😞

    Ana Sollano Kim

    Ha! I guess sometimes it happens 😢

    Gerrit-Comment-Date: Fri, 06 Mar 2026 22:59:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mason Freed <mas...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    7:47 PM (4 hours ago) 7:47 PM
    to Ana Sollano Kim, Blink W3C Test Autoroller, Mason Freed, Dan Clark, Leo Lee, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Delete ElementInternals.type-related code

    This CL deletes all mentions of ElementInternals.type as well as its
    implementation. This feature was behind a feature flag that was never
    turned on, so we can safely remove code now that we're switching to
    platform-provided behaviors.
    Bug: 422947646
    Change-Id: Ie30f9f24b99650728b3160fed46b4f995b131b25
    Reviewed-by: Mason Freed <mas...@chromium.org>
    Reviewed-by: Dan Clark <dan...@microsoft.com>
    Commit-Queue: Ana Sollano Kim <anso...@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#1595800}
    Files:
    • M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
    • M third_party/blink/renderer/core/html/custom/element_internals.cc
    • M third_party/blink/renderer/core/html/custom/element_internals.h
    • M third_party/blink/renderer/core/html/custom/element_internals.idl
    • M third_party/blink/renderer/core/html/forms/base_button_input_type.cc
    • M third_party/blink/renderer/core/html/forms/base_button_input_type.h
    • M third_party/blink/renderer/core/html/forms/html_form_control_element.cc
    • M third_party/blink/renderer/core/html/forms/html_form_control_element.h
    • M third_party/blink/renderer/core/html/forms/html_input_element.cc
    • M third_party/blink/renderer/core/html/forms/input_type.cc
    • M third_party/blink/renderer/core/html/forms/input_type.h
    • M third_party/blink/renderer/core/html/html_element.cc
    • M third_party/blink/renderer/core/html/html_element.h
    • M third_party/blink/renderer/core/html/keywords.json5
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    • M third_party/blink/web_tests/external/wpt/custom-elements/WEB_FEATURES.yml
    • D third_party/blink/web_tests/external/wpt/custom-elements/behaves-like-button-with-command.tentative.html
    • D third_party/blink/web_tests/external/wpt/custom-elements/behaves-like-button-with-popover.tentative.html
    • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
    Change size: L
    Delta: 19 files changed, 49 insertions(+), 519 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Dan Clark, +1 by Mason Freed
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie30f9f24b99650728b3160fed46b4f995b131b25
    Gerrit-Change-Number: 7632546
    Gerrit-PatchSet: 5
    Gerrit-Owner: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Reviewer: Ana Sollano Kim <anso...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages