Unbounded Element API: Feature Gate & DOM Plumbing [1/N] [chromium/src : main]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
May 8, 2026, 8:39:19 PM (4 days ago) May 8
to android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Joey Arhar

Mason Freed voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I995b11d17ba66b9d66ad73b9c2f0ab935ca47c94
Gerrit-Change-Number: 7833635
Gerrit-PatchSet: 3
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Sat, 09 May 2026 00:39:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
May 11, 2026, 3:39:58 PM (22 hours ago) May 11
to Mason Freed, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Mason Freed

Joey Arhar voted and added 2 comments

Votes added by Joey Arhar

Code-Review+1

2 comments

File third_party/blink/renderer/core/html/resources/html.css
Line 981, Patchset 6 (Latest): visibility: hidden;
Joey Arhar . unresolved

So it will still take up space in the layout of the page? is that desired?

File third_party/blink/web_tests/VirtualTestSuites
File-level comment, Patchset 6 (Latest):
Joey Arhar . unresolved

This test suite is here to make sure that the feature is not accidentally exposed when the flag is turned off, right? want to add a comment saying so...?

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I995b11d17ba66b9d66ad73b9c2f0ab935ca47c94
    Gerrit-Change-Number: 7833635
    Gerrit-PatchSet: 6
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Comment-Date: Mon, 11 May 2026 19:39:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mason Freed (Gerrit)

    unread,
    May 11, 2026, 7:03:21 PM (19 hours ago) May 11
    to android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Mason Freed voted and added 3 comments

    Votes added by Mason Freed

    Auto-Submit+1

    3 comments

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Mason Freed . resolved

    Thanks!

    File third_party/blink/renderer/core/html/resources/html.css
    Line 981, Patchset 6: visibility: hidden;
    Joey Arhar . resolved

    So it will still take up space in the layout of the page? is that desired?

    Mason Freed

    Yeah, that's the idea, so that things don't shift around when it gets shown. It's not explicitly in the top layer or anything, so it shouldn't shift/change when shown.

    See "Default Inactive State" in the design doc.

    File third_party/blink/web_tests/VirtualTestSuites
    File-level comment, Patchset 6:
    Joey Arhar . resolved

    This test suite is here to make sure that the feature is not accidentally exposed when the flag is turned off, right? want to add a comment saying so...?

    Mason Freed

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I995b11d17ba66b9d66ad73b9c2f0ab935ca47c94
      Gerrit-Change-Number: 7833635
      Gerrit-PatchSet: 7
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Mon, 11 May 2026 23:03:11 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Joey Arhar <jar...@chromium.org>
      satisfied_requirement
      open
      diffy

      Mason Freed (Gerrit)

      unread,
      May 11, 2026, 7:04:36 PM (19 hours ago) May 11
      to android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

      Mason Freed voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I995b11d17ba66b9d66ad73b9c2f0ab935ca47c94
      Gerrit-Change-Number: 7833635
      Gerrit-PatchSet: 7
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Mon, 11 May 2026 23:04:12 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      May 11, 2026, 10:17:48 PM (16 hours ago) May 11
      to Mason Freed, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ashleynewson+watch-...@chromium.org, android-web...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      6 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: third_party/blink/web_tests/VirtualTestSuites
      Insertions: 2, Deletions: 0.

      The diff is too large to show. Please review the diff.
      ```

      Change information

      Commit message:
      Unbounded Element API: Feature Gate & DOM Plumbing [1/N]

      This patch introduces the UnboundedElement runtime-enabled feature flag
      and the "unbounded" content attribute, enabling basic HTML parsing and
      default hidden user-agent styles. It also adds DOM reflection via the
      unbounded IDL boolean attribute on HTMLElement behind the runtime flag.

      A basic WPT was added to wpt_internal to verify attribute reflection
      and suppression styling. Additionally, a virtual test suite that
      explicitly disables the feature flag was added to TestLists.

      See go/unbounded-element for the design doc.
      Bug: 508672616
      Change-Id: I995b11d17ba66b9d66ad73b9c2f0ab935ca47c94
      Commit-Queue: Mason Freed <mas...@chromium.org>
      Reviewed-by: Joey Arhar <jar...@chromium.org>
      Auto-Submit: Mason Freed <mas...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1628963}
      Files:
      • M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
      • M third_party/blink/renderer/core/html/html_attribute_names.json5
      • M third_party/blink/renderer/core/html/html_element.idl
      • M third_party/blink/renderer/core/html/resources/html.css
      • M third_party/blink/renderer/platform/runtime_enabled_features.json5
      • M third_party/blink/web_tests/TestLists/content_shell.filter
      • M third_party/blink/web_tests/VirtualTestSuites
      • A third_party/blink/web_tests/virtual/unbounded-element-disabled/README.md
      • A third_party/blink/web_tests/virtual/unbounded-element-disabled/wpt_internal/html/rendering/unbounded_element/unbounded-attribute-expected.txt
      • M third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
      • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
      • A third_party/blink/web_tests/wpt_internal/html/rendering/unbounded_element/unbounded-attribute.html
      Change size: M
      Delta: 12 files changed, 85 insertions(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Joey Arhar
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I995b11d17ba66b9d66ad73b9c2f0ab935ca47c94
      Gerrit-Change-Number: 7833635
      Gerrit-PatchSet: 8
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages