Reland "Optimize scroll-target-group using OrderedScopeTree" [chromium/src : main]

0 views
Skip to first unread message

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 22, 2025, 10:10:15 AM (20 hours ago) Dec 22
to Daniil Sakhapov, AyeAye, Chromium LUCI CQ, Rune Lillesveen, David Bokan, chromium...@chromium.org, Menard, Alexis, blink-rev...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-perf/blink_perf.parser complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/14905e41b10000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I66a0bbc04fb70e4f22bc9d312c9183de79774c30
Gerrit-Change-Number: 7280270
Gerrit-PatchSet: 2
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 15:10:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 22, 2025, 10:26:00 AM (19 hours ago) Dec 22
to Daniil Sakhapov, AyeAye, Chromium LUCI CQ, Rune Lillesveen, David Bokan, chromium...@chromium.org, Menard, Alexis, blink-rev...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-perf/blink_perf.parser complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1562c309b10000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I66a0bbc04fb70e4f22bc9d312c9183de79774c30
Gerrit-Change-Number: 7280270
Gerrit-PatchSet: 2
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 15:25:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 22, 2025, 10:34:14 AM (19 hours ago) Dec 22
to Daniil Sakhapov, AyeAye, Chromium LUCI CQ, Rune Lillesveen, David Bokan, chromium...@chromium.org, Menard, Alexis, blink-rev...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org

Message from chrom...@appspot.gserviceaccount.com

📍 Job linux-perf/speedometer2 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15868889b10000

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I66a0bbc04fb70e4f22bc9d312c9183de79774c30
Gerrit-Change-Number: 7280270
Gerrit-PatchSet: 2
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 15:34:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniil Sakhapov (Gerrit)

unread,
Dec 22, 2025, 11:02:48 AM (19 hours ago) Dec 22
to chrom...@appspot.gserviceaccount.com, AyeAye, Chromium LUCI CQ, Rune Lillesveen, David Bokan, chromium...@chromium.org, Menard, Alexis, blink-rev...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org
Attention needed from Rune Lillesveen

Daniil Sakhapov voted and added 1 comment

Votes added by Daniil Sakhapov

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Daniil Sakhapov . unresolved

Changed the order of ifs to fix the perf regression.

Pinpoint jobs seem to prove the fix works.

Bugs for reference:
https://issues.chromium.org/issues/470321420
https://issues.chromium.org/issues/470401470

Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I66a0bbc04fb70e4f22bc9d312c9183de79774c30
    Gerrit-Change-Number: 7280270
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Dec 2025 16:02:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages