Do not return a union from HTMLElement::innerText() [chromium/src : main]
0 views
Skip to first unread message
Andrey Kosyakov (Gerrit)
Mar 5, 2026, 7:44:40 PM (yesterday) Mar 5
to Nate Chapin, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kouhei...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Nate Chapin
Andrey Kosyakov voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
1:31 PM (10 hours ago) 1:31 PM
to Andrey Kosyakov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kouhei...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Andrey Kosyakov
Nate Chapin voted![]( "Open in Gerrit")
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:49 PM (10 hours ago) 1:49 PM
to Andrey Kosyakov, Nate Chapin, AyeAye, chromium...@chromium.org, kouhei...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Do not return a union from HTMLElement::innerText()
This is a follow-up to https://crrev.com/c/7634373 that fixes two calls
that I missed.
Change-Id: I825d81d4e4b37a752d315c1e5b7ef7edb235d684
Auto-Submit: Andrey Kosyakov <ca...@chromium.org>
Commit-Queue: Nate Chapin <jap...@chromium.org>
Reviewed-by: Nate Chapin <jap...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1595535}
Files:
- M third_party/blink/renderer/core/html/html_element.cc
- M third_party/blink/renderer/core/html/html_element.h
- M third_party/blink/renderer/core/html/html_script_element.cc
- M third_party/blink/renderer/core/html/html_script_element.h
Change size: S
Delta: 4 files changed, 8 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Chapin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages