Use generated IDL enums when setting fields in ScrollIntoViewOptions [chromium/src : main]

0 views
Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,
Sep 18, 2025, 8:49:53 AM (yesterday) Sep 18
to Kent Tamura, Chromium LUCI CQ, David Bokan, chromium...@chromium.org, Alex Keng, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, steimel+watch...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2c56bd0f8c26a82d658c80ece1f75fac32d020a7
Gerrit-Change-Number: 6965237
Gerrit-PatchSet: 1
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Sep 2025 12:49:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Sep 18, 2025, 6:28:10 PM (yesterday) Sep 18
to Fredrik Söderquist, Kent Tamura, Chromium LUCI CQ, David Bokan, chromium...@chromium.org, Alex Keng, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, steimel+watch...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2c56bd0f8c26a82d658c80ece1f75fac32d020a7
    Gerrit-Change-Number: 6965237
    Gerrit-PatchSet: 1
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Alex Keng <shi...@microsoft.com>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Comment-Date: Thu, 18 Sep 2025 22:27:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 18, 2025, 6:54:41 PM (yesterday) Sep 18
    to Fredrik Söderquist, Kent Tamura, David Bokan, chromium...@chromium.org, Alex Keng, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, steimel+watch...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Use generated IDL enums when setting fields in ScrollIntoViewOptions
    Bug: 430171134
    Change-Id: I2c56bd0f8c26a82d658c80ece1f75fac32d020a7
    Reviewed-by: Kent Tamura <tk...@chromium.org>
    Auto-Submit: Fredrik Söderquist <f...@opera.com>
    Commit-Queue: Kent Tamura <tk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1517622}
    Files:
    • M third_party/blink/renderer/core/annotation/annotation_agent_impl_test.cc
    • M third_party/blink/renderer/core/dom/element.cc
    • M third_party/blink/renderer/core/html/forms/html_option_element.cc
    • M third_party/blink/renderer/core/page/scrolling/element_fragment_anchor.cc
    • M third_party/blink/renderer/core/page/scrolling/scroll_into_view_test.cc
    • M third_party/blink/renderer/modules/media_controls/elements/media_control_playback_speed_list_element.cc
    Change size: M
    Delta: 6 files changed, 45 insertions(+), 39 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kent Tamura
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2c56bd0f8c26a82d658c80ece1f75fac32d020a7
    Gerrit-Change-Number: 6965237
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Alex Keng <shi...@microsoft.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages