Remove redundant provider check in HTMLCanvasElement::PaintInternal [chromium/src : main]

0 views

Skip to first unread message

Colin Blundell (Gerrit)

unread,

Jul 22, 2024, 8:22:56 AM (5 days ago) Jul 22

to Jean-Philippe Gravel, Colin Blundell, Chromium LUCI CQ, Tricium, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Jean-Philippe Gravel

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Jean-Philippe Gravel

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 22, 2024, 4:14:12 PM (5 days ago) Jul 22

to Jean-Philippe Gravel, Colin Blundell, Tricium, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Remove redundant provider check in HTMLCanvasElement::PaintInternal

HTMLCanvasElement::FlushRecording cannot delete the host's
CanvasResourceProvider. If the GPU context crashes, the provider object
will only be deleted later, when a frame is presented (when
`PrepareTransferableResource` calls `IsResourceValid()`).

Since HTMLCanvasElement::PaintInternal checks the provider at the
beginning of the function, there is no need to check it again after the
flush.

Bug: 40280152

Change-Id: I82d0c8a38dc0fc76a0803d1e0c499395e8f60642

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5724632

Reviewed-by: Colin Blundell <blun...@chromium.org>

Commit-Queue: Jean-Philippe Gravel <jpgr...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1331275}

Files:

M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc

Change size: XS

Delta: 1 file changed, 2 insertions(+), 7 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Colin Blundell

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages