[rust png] Remove Blink.Canvas.ToDataURLCompressionRatio.PNG UMA. [chromium/src : main]

0 views
Skip to first unread message

Łukasz Anforowicz (Gerrit)

unread,
May 26, 2026, 7:20:33 PMMay 26
to Aaron Krajeski, Luc Nguyen, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Aaron Krajeski and Luc Nguyen

Łukasz Anforowicz voted and added 1 comment

Votes added by Łukasz Anforowicz

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Łukasz Anforowicz . resolved

@aaronhk and @lucnguyen - can you PTAL? I am picking you as reviewers since you've reviewed https://crrev.com/c/6103141. It is almost a clean revert, except that some includes need to stay (e.g. other code is also using `StaticBitmapImage`) and some additional includes added in the meantime can be removed (e.g. `histogram_functions.h` are not used anymore AFAICT).

Disclaimer: CQ dry run passes in patchset 1 but it is still running for later patchsets. But I think this is all okay - the local build works fine and there are no conditionals of `#if`s so I think CQ should also be (eventually) happy.

Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Krajeski
  • Luc Nguyen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9b85d10d4d223371f22c01c880508f044fcd0a33
Gerrit-Change-Number: 7876550
Gerrit-PatchSet: 3
Gerrit-Owner: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
Gerrit-Reviewer: Luc Nguyen <lucn...@google.com>
Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Luc Nguyen <lucn...@google.com>
Gerrit-Attention: Aaron Krajeski <aar...@chromium.org>
Gerrit-Comment-Date: Tue, 26 May 2026 23:20:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Luc Nguyen (Gerrit)

unread,
May 27, 2026, 12:20:59 PMMay 27
to Łukasz Anforowicz, Aaron Krajeski, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Aaron Krajeski

Luc Nguyen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Krajeski
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b85d10d4d223371f22c01c880508f044fcd0a33
    Gerrit-Change-Number: 7876550
    Gerrit-PatchSet: 4
    Gerrit-Owner: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
    Gerrit-Reviewer: Luc Nguyen <lucn...@google.com>
    Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Aaron Krajeski <aar...@chromium.org>
    Gerrit-Comment-Date: Wed, 27 May 2026 16:20:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Łukasz Anforowicz (Gerrit)

    unread,
    Jun 22, 2026, 8:30:18 PM (2 days ago) Jun 22
    to Luc Nguyen, Aaron Krajeski, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Attention needed from Aaron Krajeski

    Łukasz Anforowicz voted and added 1 comment

    Votes added by Łukasz Anforowicz

    Auto-Submit+1
    Commit-Queue+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Łukasz Anforowicz . resolved

    @fmalita, can you PTAL as one of `//third_party/blink/renderer/OWNERS`?

    Gerrit-Comment-Date: Tue, 23 Jun 2026 00:29:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Łukasz Anforowicz (Gerrit)

    unread,
    Jun 24, 2026, 1:26:04 PM (13 hours ago) Jun 24
    to Florin Malita, Luc Nguyen, Aaron Krajeski, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Attention needed from Aaron Krajeski and Florin Malita

    Łukasz Anforowicz added 1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Łukasz Anforowicz . resolved

    @fmalita, can you PTAL as one of `//third_party/blink/renderer/OWNERS`?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Aaron Krajeski
    • Florin Malita
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b85d10d4d223371f22c01c880508f044fcd0a33
    Gerrit-Change-Number: 7876550
    Gerrit-PatchSet: 4
    Gerrit-Owner: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-Reviewer: Aaron Krajeski <aar...@chromium.org>
    Gerrit-Reviewer: Florin Malita <fma...@chromium.org>
    Gerrit-Reviewer: Luc Nguyen <lucn...@google.com>
    Gerrit-Reviewer: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Florin Malita <fma...@chromium.org>
    Gerrit-Attention: Aaron Krajeski <aar...@chromium.org>
    Gerrit-Comment-Date: Wed, 24 Jun 2026 17:25:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages