[M148] [CE] Correct logic of DefaultEventHandler in HTMLUserMediaElement [chromium/src : refs/branch-heads/7778]

0 views
Skip to first unread message

chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Apr 17, 2026, 4:32:05 PM (13 days ago) Apr 17
to Thomas Nguyen, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, permissio...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com, blink-rev...@chromium.org, tommyw+w...@chromium.org, blink-revie...@chromium.org

chrome-che...@chops-service-accounts.iam.gserviceaccount.com voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7778
Gerrit-Change-Id: I84f733a590d24d0fa60c08a49fc3a19b9314c695
Gerrit-Change-Number: 7773729
Gerrit-PatchSet: 2
Gerrit-CC: Thomas Nguyen <tun...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Comment-Date: Fri, 17 Apr 2026 20:32:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Apr 17, 2026, 4:32:23 PM (13 days ago) Apr 17
to Thomas Nguyen, chrome-che...@chops-service-accounts.iam.gserviceaccount.com, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, permissio...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com, blink-rev...@chromium.org, tommyw+w...@chromium.org, blink-revie...@chromium.org

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7778
Gerrit-Change-Id: I84f733a590d24d0fa60c08a49fc3a19b9314c695
Gerrit-Change-Number: 7773729
Gerrit-PatchSet: 2
Gerrit-CC: Thomas Nguyen <tun...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Comment-Date: Fri, 17 Apr 2026 20:32:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 17, 2026, 6:25:52 PM (12 days ago) Apr 17
to Thomas Nguyen, chrome-che...@chops-service-accounts.iam.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, permissio...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com, blink-rev...@chromium.org, tommyw+w...@chromium.org, blink-revie...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[M148] [CE] Correct logic of DefaultEventHandler in HTMLUserMediaElement

Original change's description:
> [CE] Correct logic of DefaultEventHandler in HTMLUserMediaElement
>
> Ensure that HTMLUserMediaElement does not initiate multiple concurrent
> media stream requests. Previously, rapid user activations could trigger
> overlapping requests before the initial one had completed.
>
> Additionally, the activation logic was updated to use the base
> capability element's activation handler, ensuring that permission
> checks and media requests are correctly synchronized with user events.
>
> Fixed: 500303904
>
> Change-Id: I84f733a590d24d0fa60c08a49fc3a19b9314c695
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7734929
> Reviewed-by: Joey Arhar <jar...@chromium.org>
> Commit-Queue: Thomas Nguyen <tun...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1616082}

(cherry picked from commit 52acd3d83186e4e9b69312b04d1859f1879da6f5)
Bug: 503418523,500303904
Change-Id: I84f733a590d24d0fa60c08a49fc3a19b9314c695
Cr-Commit-Position: refs/branch-heads/7778@{#980}
Cr-Branched-From: 77f495ee216d4c3cc784d33658bad4778c0680ee-refs/heads/main@{#1610480}
Files:
  • M chrome/browser/permissions/permission_element_browsertest.cc
  • M chrome/browser/ui/views/permissions/embedded_permission_prompt_interactive_uitest.cc
  • M third_party/blink/renderer/core/html/html_capability_element_base.cc
  • M third_party/blink/renderer/core/html/html_user_media_element.cc
  • M third_party/blink/renderer/core/html/html_user_media_element.h
  • M third_party/blink/renderer/core/html/html_user_media_element_test.cc
  • M third_party/blink/renderer/modules/mediastream/user_media_request_provider_impl.cc
  • M third_party/blink/web_tests/external/wpt/html/semantics/permission-element/usermedia/set-constraints-combinations.tentative.html
  • M third_party/blink/web_tests/external/wpt/html/semantics/permission-element/usermedia/usermedia-constraints-descriptors.tentative.html
  • M third_party/blink/web_tests/external/wpt/html/semantics/permission-element/usermedia/usermedia-no-constraints.tentative.html
Change size: L
Delta: 10 files changed, 122 insertions(+), 155 deletions(-)
Branch: refs/branch-heads/7778
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7778
Gerrit-Change-Id: I84f733a590d24d0fa60c08a49fc3a19b9314c695
Gerrit-Change-Number: 7773729
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages