Introduce ExportedCanvasResource [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
Apr 16, 2026, 8:20:08 PM (13 days ago) Apr 16
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Vasiliy Telezhnikov . resolved
Please, take a look.
Roughly plan:
* Introduce ExportedCanvasResource at the placeholder (this CL)
* Refine it to encapsulate CanvasResource a bit better
* Push the creation all the way down to CRP / ExternalCanvasResource creation
* Inline most of the things from CR to it up to the point where the remaining is either:
* Related to recycling, e.g SyncToken, NotifyLost, etc.
* GetClientSharedImage call
* Other static metadata
* Delay all recycling related calls till dtor
* Grab all static metadata + SI in ctor
* Replace dtor with callback
* Pass callback and metadata in ctor instead of CR.
At this point ExternalCanvasResource practically disappears and CR becomes internal to CRP.
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Apr 17, 2026, 4:08:12 AM (13 days ago) Apr 17
to Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Vasiliy Telezhnikov
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Apr 17, 2026, 9:33:54 AM (13 days ago) Apr 17
to Dave Tapuska, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Dave Tapuska
Vasiliy Telezhnikov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Vasiliy Telezhnikov . resolved
+R Dave for BUILD.gn, please, take a look.
Related details
Attention is currently required from:
- Dave Tapuska
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Apr 17, 2026, 10:20:22 AM (13 days ago) Apr 17
to Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Vasiliy Telezhnikov
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Apr 17, 2026, 10:21:07 AM (13 days ago) Apr 17
to Dave Tapuska, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Vasiliy Telezhnikov . resolved
Thanks for the reviews!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 17, 2026, 10:25:30 AM (13 days ago) Apr 17
to Vasiliy Telezhnikov, Dave Tapuska, Colin Blundell, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Introduce ExportedCanvasResource
At this point it's a wrapper around CanvasResource and is intended to
be used when canvas exports resource for the presentation.
As a first step, we use it inplace of the placeholder frame.
No behaviour change.
Change-Id: I783726f39eb5a282e213ea5d778adb413f319813
Reviewed-by: Colin Blundell <blun...@chromium.org>
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1616535}
Files:
- M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
- M third_party/blink/renderer/core/html/canvas/html_canvas_element.h
- M third_party/blink/renderer/platform/BUILD.gn
- M third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
- A third_party/blink/renderer/platform/graphics/exported_canvas_resource.cc
- A third_party/blink/renderer/platform/graphics/exported_canvas_resource.h
- M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.cc
- M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder.h
- M third_party/blink/renderer/platform/graphics/offscreen_canvas_placeholder_test.cc
Change size: M
Delta: 9 files changed, 117 insertions(+), 17 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell, +1 by Dave Tapuska
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages