Switch HTMLMediaElement to use inline initialization [chromium/src : main]

0 views
Skip to first unread message

Dale Curtis (Gerrit)

unread,
Apr 16, 2026, 4:23:45 PM (6 days ago) Apr 16
to Ted (Chromium) Meyer, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Ted (Chromium) Meyer

Dale Curtis voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ted (Chromium) Meyer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idb17e8df6d598f7200a1b98c8bad561eb12fbf36
Gerrit-Change-Number: 7769509
Gerrit-PatchSet: 1
Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Apr 2026 20:23:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ted (Chromium) Meyer (Gerrit)

unread,
Apr 16, 2026, 5:53:59 PM (6 days ago) Apr 16
to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Dale Curtis

Ted (Chromium) Meyer voted and added 1 comment

Votes added by Ted (Chromium) Meyer

Code-Review+1

1 comment

File third_party/blink/renderer/core/html/media/html_media_element.h
Line 898, Patchset 1 (Latest): bool playing_ : 1 = false;
Ted (Chromium) Meyer . unresolved

WDYT about getting rid of this bitpacking thing. I'm fairly sure clang ignores this unless you have \_\_attribute__((packed)) on here. And it's not like this object is copied around a bunch

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idb17e8df6d598f7200a1b98c8bad561eb12fbf36
    Gerrit-Change-Number: 7769509
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Comment-Date: Thu, 16 Apr 2026 21:53:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dale Curtis (Gerrit)

    unread,
    Apr 20, 2026, 12:50:23 PM (2 days ago) Apr 20
    to Ted (Chromium) Meyer, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org

    Dale Curtis voted and added 1 comment

    Votes added by Dale Curtis

    Auto-Submit+0
    Commit-Queue+2

    1 comment

    File third_party/blink/renderer/core/html/media/html_media_element.h
    Line 898, Patchset 1 (Latest): bool playing_ : 1 = false;
    Ted (Chromium) Meyer . resolved

    WDYT about getting rid of this bitpacking thing. I'm fairly sure clang ignores this unless you have \_\_attribute__((packed)) on here. And it's not like this object is copied around a bunch

    Dale Curtis

    sgtm, but will do that in a different patch just in case it does something.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Idb17e8df6d598f7200a1b98c8bad561eb12fbf36
      Gerrit-Change-Number: 7769509
      Gerrit-PatchSet: 1
      Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
      Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
      Gerrit-Comment-Date: Mon, 20 Apr 2026 16:50:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Ted (Chromium) Meyer <tmath...@chromium.org>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Apr 20, 2026, 2:25:17 PM (2 days ago) Apr 20
      to Dale Curtis, Ted (Chromium) Meyer, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Switch HTMLMediaElement to use inline initialization

      Also fixes missing initialization for `play_promise_error_code_`

      R=tmathmeyer
      Change-Id: Idb17e8df6d598f7200a1b98c8bad561eb12fbf36
      Commit-Queue: Dale Curtis <dalec...@chromium.org>
      Reviewed-by: Ted (Chromium) Meyer <tmath...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1617639}
      Files:
      • M third_party/blink/renderer/core/html/media/html_media_element.cc
      • M third_party/blink/renderer/core/html/media/html_media_element.h
      Change size: M
      Delta: 2 files changed, 38 insertions(+), 73 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Ted (Chromium) Meyer
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Idb17e8df6d598f7200a1b98c8bad561eb12fbf36
      Gerrit-Change-Number: 7769509
      Gerrit-PatchSet: 2
      Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages