Lia Hiscock (Gerrit)

unread,

Mar 30, 2026, 6:52:20 PM (2 days ago) Mar 30

to Lu Huang, Kristin Lee, Chromium LUCI CQ, chromium...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Lu Huang

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Lu Huang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lu Huang (Gerrit)

unread,

Mar 31, 2026, 5:10:44 PM (2 days ago) Mar 31

to Lia Hiscock, Kristin Lee, Chromium LUCI CQ, chromium...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Lia Hiscock

Lu Huang voted and added 1 comment

Votes added by Lu Huang

Code-Review

+1

1 comment

File chrome/browser/web_applications/web_install_service_impl.cc

Line 178, Patchset 3 (Parent): auto* provider = WebAppProvider::GetForWebApps(

Lu Huang . unresolved

Reminder to check if any header includes can be removed.

Open in Gerrit

Related details

Attention is currently required from:

Lia Hiscock

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lia Hiscock (Gerrit)

unread,

Mar 31, 2026, 5:47:38 PM (2 days ago) Mar 31

to Lu Huang, Kristin Lee, Chromium LUCI CQ, chromium...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Lia Hiscock added 1 comment

File chrome/browser/web_applications/web_install_service_impl.cc

Line 178, Patchset 3 (Parent): auto* provider = WebAppProvider::GetForWebApps(

Lu Huang . resolved

Reminder to check if any header includes can be removed.

Lia Hiscock

Done - yup, actually did remember this time, we're good

https://chromium-review.googlesource.com/c/chromium/src/+/7302388/38/chrome/browser/web_applications/web_install_service_impl.cc

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lia Hiscock (Gerrit)

unread,

Mar 31, 2026, 5:51:23 PM (2 days ago) Mar 31

to Daniel Murphy, Mike West, Lu Huang, Kristin Lee, Chromium LUCI CQ, chromium...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Daniel Murphy and Mike West

Lia Hiscock added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Lia Hiscock . resolved

Hi folks! We got another bug filed for the mojo function that backed the "Launch" state checking, so I'm just removing the code completely. (it was already unhooked/not in use). TIA!

https://issues.chromium.org/issues/496193802

Open in Gerrit

Related details

Attention is currently required from:

Daniel Murphy
Mike West

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lu Huang (Gerrit)

unread,

Mar 31, 2026, 6:09:49 PM (2 days ago) Mar 31

to Lia Hiscock, Daniel Murphy, Mike West, Kristin Lee, Chromium LUCI CQ, chromium...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Daniel Murphy, Lia Hiscock and Mike West

Lu Huang added 3 comments

File third_party/blink/renderer/core/html/html_install_element.cc

Line 61, Patchset 3 (Parent):

  // TODO(crbug.com/477643920): Evaluate element behavior with illegal/invalid
  // attributes. (Should we hide or grey out button, etc.).
  mojom::blink::InstallOptionsPtr options = GetCheckedInstallOptions();

  if (!options) {
    // Illegal arguments will never be installed. Skip straight to the
    // IsInstalled result so we can post the UpdateAppearanceTask.
    OnIsInstalledResult(false);
    return;
  }

Lu Huang . unresolved

This check is removed. Is that also intentional?

Line 113, Patchset 3 (Parent): GetTranslatedMessageID(is_installed ? IDS_PERMISSION_REQUEST_LAUNCH

Lu Huang . unresolved

Is this IDS still used? Should it be removed?

Line 126, Patchset 3 (Parent): ? PermissionIconType::kLaunch

Lu Huang . unresolved

Ditto. Is `kLaunch` still used? Should it be removed?

Open in Gerrit

Related details

Attention is currently required from:

Daniel Murphy
Lia Hiscock
Mike West

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lia Hiscock (Gerrit)

unread,

Mar 31, 2026, 6:23:00 PM (2 days ago) Mar 31

to Daniel Murphy, Mike West, Lu Huang, Kristin Lee, Chromium LUCI CQ, chromium...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Daniel Murphy, Lu Huang and Mike West

Lia Hiscock added 3 comments

File third_party/blink/renderer/core/html/html_install_element.cc

Line 61, Patchset 3 (Parent):

  // TODO(crbug.com/477643920): Evaluate element behavior with illegal/invalid
  // attributes. (Should we hide or grey out button, etc.).
  mojom::blink::InstallOptionsPtr options = GetCheckedInstallOptions();

  if (!options) {
    // Illegal arguments will never be installed. Skip straight to the
    // IsInstalled result so we can post the UpdateAppearanceTask.
    OnIsInstalledResult(false);
    return;
  }

Lu Huang . unresolved

This check is removed. Is that also intentional?

Lia Hiscock

Yes. That was there to catch illegal attributes, which would never be installed, so we didn't need to check IsInstalled.

Line 113, Patchset 3 (Parent): GetTranslatedMessageID(is_installed ? IDS_PERMISSION_REQUEST_LAUNCH

Lu Huang . resolved

Is this IDS still used? Should it be removed?

Lia Hiscock

Done

Line 126, Patchset 3 (Parent): ? PermissionIconType::kLaunch

Lu Huang . resolved

Ditto. Is `kLaunch` still used? Should it be removed?

Lia Hiscock

Done

Open in Gerrit

Related details

Attention is currently required from:

Daniel Murphy
Lu Huang
Mike West

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Murphy (Gerrit)

unread,

Mar 31, 2026, 6:32:22 PM (2 days ago) Mar 31

to Lia Hiscock, Daniel Murphy, Mike West, Lu Huang, Kristin Lee, Chromium LUCI CQ, chromium...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Lia Hiscock, Lu Huang and Mike West

Daniel Murphy added 1 comment

File chrome/browser/web_applications/web_install_service_impl.cc

Line 164, Patchset 4 (Parent): GURL install_target;

Daniel Murphy . unresolved

you could 'solve' this for now by just checking the flag here, and returning nothing if it's off.

Open in Gerrit

Related details

Attention is currently required from:

Lia Hiscock
Lu Huang
Mike West

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Murphy (Gerrit)

unread,

Mar 31, 2026, 6:33:00 PM (2 days ago) Mar 31

to Lia Hiscock, Daniel Murphy, Mike West, Lu Huang, Kristin Lee, Chromium LUCI CQ, chromium...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Lia Hiscock, Lu Huang and Mike West

Daniel Murphy voted and added 1 comment

Votes added by Daniel Murphy

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Daniel Murphy . resolved

fine to remove, but maybe we don't need something this drastic with the flag protection

Open in Gerrit

Related details

Attention is currently required from:

Lia Hiscock
Lu Huang
Mike West

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lia Hiscock (Gerrit)

unread,

Mar 31, 2026, 7:21:28 PM (2 days ago) Mar 31

to Daniel Murphy, Mike West, Lu Huang, Kristin Lee, Chromium LUCI CQ, chromium...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Daniel Murphy, Lu Huang and Mike West

Lia Hiscock added 1 comment

File chrome/browser/web_applications/web_install_service_impl.cc

Line 164, Patchset 4 (Parent): GURL install_target;

Daniel Murphy . unresolved

you could 'solve' this for now by just checking the flag here, and returning nothing if it's off.

Lia Hiscock

Hmm, to clarify, are you talking about the base::Feature flag? or the runtime enabled flag?

The base::Feature flag was actually enabled by default as part of our configuration for OT [1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/7080491/46/third_party/blink/renderer/platform/runtime_enabled_features.json5

Open in Gerrit

Related details

Attention is currently required from:

Daniel Murphy
Lu Huang
Mike West

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Murphy (Gerrit)

unread,

Apr 1, 2026, 11:54:04 AM (19 hours ago) Apr 1

to Lia Hiscock, Daniel Murphy, Mike West, Lu Huang, Kristin Lee, Chromium LUCI CQ, chromium...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Lia Hiscock, Lu Huang and Mike West

Daniel Murphy added 1 comment

File chrome/browser/web_applications/web_install_service_impl.cc

Line 164, Patchset 4 (Parent): GURL install_target;

Daniel Murphy . resolved

you could 'solve' this for now by just checking the flag here, and returning nothing if it's off.

Lia Hiscock

Hmm, to clarify, are you talking about the base::Feature flag? or the runtime enabled flag?
The base::Feature flag was actually enabled by default as part of our configuration for OT [1].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/7080491/46/third_party/blink/renderer/platform/runtime_enabled_features.json5

Daniel Murphy

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

Lia Hiscock
Lu Huang
Mike West

satisfied_requirement

unsatisfied_requirement

open

diffy

Lia Hiscock (Gerrit)

unread,

Apr 1, 2026, 4:50:24 PM (14 hours ago) Apr 1

to Robert Paveza, Daniel Murphy, Mike West, Lu Huang, Kristin Lee, Chromium LUCI CQ, chromium...@chromium.org, aixba+wat...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, ipc-securi...@chromium.org, japhet+...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Lu Huang and Mike West

Lia Hiscock added 1 comment

File third_party/blink/renderer/core/html/html_install_element.cc

Line 61, Patchset 3 (Parent):

  // TODO(crbug.com/477643920): Evaluate element behavior with illegal/invalid
  // attributes. (Should we hide or grey out button, etc.).
  mojom::blink::InstallOptionsPtr options = GetCheckedInstallOptions();

  if (!options) {
    // Illegal arguments will never be installed. Skip straight to the
    // IsInstalled result so we can post the UpdateAppearanceTask.
    OnIsInstalledResult(false);
    return;
  }

Lu Huang . resolved

This check is removed. Is that also intentional?

Lia Hiscock

Yes. That was there to catch illegal attributes, which would never be installed, so we didn't need to check IsInstalled.

Lia Hiscock

Resolving for now. Reopen if there are still concerns.

Open in Gerrit

Related details

Attention is currently required from:

Lu Huang
Mike West

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[<install> Element] Remove WebInstallService::IsInstalled [chromium/src : main]

Lia Hiscock (Gerrit)

New activity on the change

Related details

Lu Huang (Gerrit)

Lu Huang voted and added 1 comment

Votes added by Lu Huang

1 comment

Related details

Lia Hiscock (Gerrit)

Lia Hiscock added 1 comment

Related details

Lia Hiscock (Gerrit)

Lia Hiscock added 1 comment

Related details

Lu Huang (Gerrit)

Lu Huang added 3 comments

Related details

Lia Hiscock (Gerrit)

Lia Hiscock added 3 comments

Related details

Daniel Murphy (Gerrit)

Daniel Murphy added 1 comment

Related details

Daniel Murphy (Gerrit)

Daniel Murphy voted and added 1 comment

Votes added by Daniel Murphy

1 comment

Related details

Lia Hiscock (Gerrit)

Lia Hiscock added 1 comment

Related details

Daniel Murphy (Gerrit)

Daniel Murphy added 1 comment

Related details

Lia Hiscock (Gerrit)

Lia Hiscock added 1 comment

Related details